Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(129)

Issue 43991002: commission: Match also with parent categories (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by ced
Modified:
7 months, 2 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M commission.py View 1 chunk +8 lines, -1 line 0 comments Download
M tests/test_commission.py View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6
ced
8 months, 1 week ago (2018-02-13 11:56:32 UTC) #1
reviewbot
https://codereview.tryton.org/43991002/diff/1/commission.py#newcode324 commission.py:324: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/43991002/diff/1/commission.py#newcode335 commission.py:335: E731 ...
8 months, 1 week ago (2018-02-13 12:15:29 UTC) #2
ced
Add test
8 months ago (2018-02-13 17:38:33 UTC) #3
reviewbot
https://codereview.tryton.org/43991002/diff/20001/commission.py#newcode324 commission.py:324: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/43991002/diff/20001/commission.py#newcode335 commission.py:335: E731 ...
8 months ago (2018-02-13 17:51:34 UTC) #4
pokoli
LGTM
8 months ago (2018-02-14 09:21:19 UTC) #5
rietveld-bot_tryton.org
7 months, 2 weeks ago (2018-03-04 00:07:58 UTC) #6
New changeset 83db008a47b1 by Cédric Krier in branch 'default':
Match also with parent categories
http://hg.tryton.org/modules/commission/rev/83db008a47b1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766