Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Issue 443501003: tryton-env: Add secondary quantity to stock lot trace

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by hodeinavarro
Modified:
3 months, 3 weeks ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Apply remarks #

Total comments: 10

Patch Set 3 : Add changelog entry #

Total comments: 1

Patch Set 4 : Apply remarks #

Total comments: 6

Patch Set 5 : Apply remarks #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -1 line) Patch
M modules/stock_lot/stock.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
M modules/stock_secondary_unit/CHANGELOG View 1 2 3 4 1 chunk +2 lines, -0 lines 1 comment Download
M modules/stock_secondary_unit/__init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
M modules/stock_secondary_unit/setup.py View 1 2 3 1 chunk +3 lines, -1 line 1 comment Download
M modules/stock_secondary_unit/stock.py View 1 2 3 4 1 chunk +42 lines, -0 lines 1 comment Download
M modules/stock_secondary_unit/stock.xml View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M modules/stock_secondary_unit/tests/test_module.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M modules/stock_secondary_unit/tryton.cfg View 1 chunk +2 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/view/lot_trace_tree.xml View 1 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 19
hodeinavarro
5 months, 1 week ago (2022-08-23 15:34:55 UTC) #1
pokoli
missing changelog entry https://codereview.tryton.org/443501003/diff/417831003/modules/stock_lot/stock.py File modules/stock_lot/stock.py (right): https://codereview.tryton.org/443501003/diff/417831003/modules/stock_lot/stock.py#newcode160 modules/stock_lot/stock.py:160: move = fields.Many2One('stock.move', 'Move') double quotes ...
5 months, 1 week ago (2022-08-23 15:37:46 UTC) #2
pokoli
https://codereview.tryton.org/443501003/diff/417831003/modules/stock_secondary_unit/stock.xml File modules/stock_secondary_unit/stock.xml (right): https://codereview.tryton.org/443501003/diff/417831003/modules/stock_secondary_unit/stock.xml#newcode40 modules/stock_secondary_unit/stock.xml:40: <field name="name">lot_trace_tree</field> this file is missing https://codereview.tryton.org/443501003/diff/417831003/modules/stock_secondary_unit/stock.xml#newcode42 modules/stock_secondary_unit/stock.xml:42: please ...
5 months, 1 week ago (2022-08-23 15:38:28 UTC) #3
hodeinavarro
Apply remarks
5 months, 1 week ago (2022-08-23 15:43:30 UTC) #4
reviewbot
checks OK URL: https://codereview.tryton.org/443501003
5 months, 1 week ago (2022-08-23 15:43:42 UTC) #5
hodeinavarro
On 2022/08/23 15:37:46, pokoli wrote: > missing changelog entry Where should the changelog be? stock_lot ...
5 months, 1 week ago (2022-08-23 15:44:04 UTC) #6
hodeinavarro
https://codereview.tryton.org/443501003/diff/417831003/modules/stock_lot/stock.py File modules/stock_lot/stock.py (right): https://codereview.tryton.org/443501003/diff/417831003/modules/stock_lot/stock.py#newcode160 modules/stock_lot/stock.py:160: move = fields.Many2One('stock.move', 'Move') On 2022/08/23 15:37:46, pokoli wrote: ...
5 months, 1 week ago (2022-08-23 15:44:38 UTC) #7
pokoli
On 2022/08/23 15:44:04, hodeinavarro wrote: > On 2022/08/23 15:37:46, pokoli wrote: > > missing changelog ...
5 months, 1 week ago (2022-08-23 15:45:29 UTC) #8
hodeinavarro
Add changelog entry
5 months, 1 week ago (2022-08-23 15:48:25 UTC) #9
pokoli
https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondary_unit/stock.py File modules/stock_secondary_unit/stock.py (right): https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondary_unit/stock.py#newcode161 modules/stock_secondary_unit/stock.py:161: digits=(16, Eval('secondary_unit_digits', 2)), you can use: digits='secondary_unit' https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondary_unit/stock.py#newcode164 modules/stock_secondary_unit/stock.py:164: ...
5 months, 1 week ago (2022-08-23 15:52:19 UTC) #10
pokoli
https://codereview.tryton.org/443501003/diff/427591004/modules/stock_secondary_unit/CHANGELOG File modules/stock_secondary_unit/CHANGELOG (right): https://codereview.tryton.org/443501003/diff/427591004/modules/stock_secondary_unit/CHANGELOG#newcode1 modules/stock_secondary_unit/CHANGELOG:1: Version 6.5.0 - 2022-08-23 you do not need to ...
5 months, 1 week ago (2022-08-23 15:52:48 UTC) #11
hodeinavarro
Apply remarks
5 months, 1 week ago (2022-08-23 16:06:05 UTC) #12
hodeinavarro
https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondary_unit/stock.py File modules/stock_secondary_unit/stock.py (right): https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondary_unit/stock.py#newcode161 modules/stock_secondary_unit/stock.py:161: digits=(16, Eval('secondary_unit_digits', 2)), On 2022/08/23 15:52:19, pokoli wrote: > ...
5 months, 1 week ago (2022-08-23 16:06:13 UTC) #13
reviewbot
checks OK URL: https://codereview.tryton.org/443501003
5 months, 1 week ago (2022-08-23 16:10:03 UTC) #14
pokoli
https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondary_unit/CHANGELOG File modules/stock_secondary_unit/CHANGELOG (right): https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondary_unit/CHANGELOG#newcode1 modules/stock_secondary_unit/CHANGELOG:1: * Add secondary_quantity for stock lot trace Add -> ...
5 months, 1 week ago (2022-08-23 16:11:49 UTC) #15
hodeinavarro
Apply remarks
5 months, 1 week ago (2022-08-23 17:07:57 UTC) #16
hodeinavarro
https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondary_unit/CHANGELOG File modules/stock_secondary_unit/CHANGELOG (right): https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondary_unit/CHANGELOG#newcode1 modules/stock_secondary_unit/CHANGELOG:1: * Add secondary_quantity for stock lot trace On 2022/08/23 ...
5 months, 1 week ago (2022-08-23 17:08:05 UTC) #17
reviewbot
checks OK URL: https://codereview.tryton.org/443501003
5 months, 1 week ago (2022-08-23 17:40:42 UTC) #18
ced
3 months, 3 weeks ago (2022-10-10 07:27:57 UTC) #19
https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
File modules/stock_secondary_unit/CHANGELOG (right):

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
modules/stock_secondary_unit/CHANGELOG:1: * Show secondary_quantity in stock lot
trace
Better: Add secondary unit on stock lot trace

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
File modules/stock_secondary_unit/setup.py (right):

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
modules/stock_secondary_unit/setup.py:69: ]
wrong indentation

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
File modules/stock_secondary_unit/stock.py (right):

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
modules/stock_secondary_unit/stock.py:171: def
on_change_with_secondary_quantity(self, name=None):
Why not return self.move.secondary_quantity ?

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
File modules/stock_secondary_unit/view/lot_trace_tree.xml (right):

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
modules/stock_secondary_unit/view/lot_trace_tree.xml:1: <?xml version="1.0"?>
missing copyright header

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
modules/stock_secondary_unit/view/lot_trace_tree.xml:4: <field
name="secondary_quantity" symbol="secondary_unit" optional="1" />
no space before '/>'
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted