tryton-env: Add secondary quantity to stock lot trace

issue11664

[pokoli, 2022-08-23 15:37:46]

missing changelog entry

https://codereview.tryton.org/443501003/diff/417831003/modules/stock_lot/stoc...
File modules/stock_lot/stock.py (right):

https://codereview.tryton.org/443501003/diff/417831003/modules/stock_lot/stoc...
modules/stock_lot/stock.py:160: move = fields.Many2One('stock.move', 'Move')
double quotes for "Move" as its human readable

https://codereview.tryton.org/443501003/diff/417831003/modules/stock_lot/stoc...
modules/stock_lot/stock.py:206: move.move.as_('move'),
should be move.id

[pokoli, 2022-08-23 15:38:28]

https://codereview.tryton.org/443501003/diff/417831003/modules/stock_secondar...
File modules/stock_secondary_unit/stock.xml (right):

https://codereview.tryton.org/443501003/diff/417831003/modules/stock_secondar...
modules/stock_secondary_unit/stock.xml:40: <field
name="name">lot_trace_tree</field>
this file is missing

https://codereview.tryton.org/443501003/diff/417831003/modules/stock_secondar...
modules/stock_secondary_unit/stock.xml:42: 
please remove trailing spaces

[hodeinavarro, 2022-08-23 15:43:30]

Apply remarks

[reviewbot, 2022-08-23 15:43:42]

checks OK
URL: https://codereview.tryton.org/443501003

[hodeinavarro, 2022-08-23 15:44:04]

On 2022/08/23 15:37:46, pokoli wrote:
> missing changelog entry

Where should the changelog be? stock_lot or stock_secondary_unit?

[hodeinavarro, 2022-08-23 15:44:38]

https://codereview.tryton.org/443501003/diff/417831003/modules/stock_lot/stoc...
File modules/stock_lot/stock.py (right):

https://codereview.tryton.org/443501003/diff/417831003/modules/stock_lot/stoc...
modules/stock_lot/stock.py:160: move = fields.Many2One('stock.move', 'Move')
On 2022/08/23 15:37:46, pokoli wrote:
> double quotes for "Move" as its human readable

Done.

https://codereview.tryton.org/443501003/diff/417831003/modules/stock_lot/stoc...
modules/stock_lot/stock.py:206: move.move.as_('move'),
On 2022/08/23 15:37:46, pokoli wrote:
> should be move.id

Done.

https://codereview.tryton.org/443501003/diff/417831003/modules/stock_secondar...
File modules/stock_secondary_unit/stock.xml (right):

https://codereview.tryton.org/443501003/diff/417831003/modules/stock_secondar...
modules/stock_secondary_unit/stock.xml:40: <field
name="name">lot_trace_tree</field>
On 2022/08/23 15:38:28, pokoli wrote:
> this file is missing

Done.

https://codereview.tryton.org/443501003/diff/417831003/modules/stock_secondar...
modules/stock_secondary_unit/stock.xml:42: 
On 2022/08/23 15:38:28, pokoli wrote:
> please remove trailing spaces

Done.

[pokoli, 2022-08-23 15:45:29]

On 2022/08/23 15:44:04, hodeinavarro wrote:
> On 2022/08/23 15:37:46, pokoli wrote:
> > missing changelog entry
> 
> Where should the changelog be? stock_lot or stock_secondary_unit?

stock_secondary_unit which is the one that introduces the new feature.

[hodeinavarro, 2022-08-23 15:48:25]

Add changelog entry

[pokoli, 2022-08-23 15:52:19]

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
File modules/stock_secondary_unit/stock.py (right):

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
modules/stock_secondary_unit/stock.py:161: digits=(16,
Eval('secondary_unit_digits', 2)),
you can use: 

digits='secondary_unit'

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
modules/stock_secondary_unit/stock.py:164: secondary_unit_digits =
fields.Function(
this field is not needed.

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
modules/stock_secondary_unit/stock.py:189: def
on_change_with_secondary_unit_digits(self, name=None):
can be removed

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
File modules/stock_secondary_unit/stock.xml (right):

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
modules/stock_secondary_unit/stock.xml:36: <data depends="stock_lot">
data can not be inside data. It should be in a separate data. 
Otherwise is not correctly parsed.

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
File modules/stock_secondary_unit/tryton.cfg (right):

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
modules/stock_secondary_unit/tryton.cfg:8: stock_lot
Could you add stock_lot as extras in test_module and inlcude trytond_stock_lot
as test_requirement in setup.py? This will allow to test the module with
stock_lot activated and test everything works as expected.

[pokoli, 2022-08-23 15:52:48]

https://codereview.tryton.org/443501003/diff/427591004/modules/stock_secondar...
File modules/stock_secondary_unit/CHANGELOG (right):

https://codereview.tryton.org/443501003/diff/427591004/modules/stock_secondar...
modules/stock_secondary_unit/CHANGELOG:1: Version 6.5.0 - 2022-08-23
you do not need to add the version number. This will be managed by the release
process. Please remove such line.

[hodeinavarro, 2022-08-23 16:06:05]

Apply remarks

[hodeinavarro, 2022-08-23 16:06:13]

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
File modules/stock_secondary_unit/stock.py (right):

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
modules/stock_secondary_unit/stock.py:161: digits=(16,
Eval('secondary_unit_digits', 2)),
On 2022/08/23 15:52:19, pokoli wrote:
> you can use: 
> 
> digits='secondary_unit'

Done.

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
modules/stock_secondary_unit/stock.py:164: secondary_unit_digits =
fields.Function(
On 2022/08/23 15:52:19, pokoli wrote:
> this field is not needed.

Done.

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
modules/stock_secondary_unit/stock.py:189: def
on_change_with_secondary_unit_digits(self, name=None):
On 2022/08/23 15:52:19, pokoli wrote:
> can be removed

Done.

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
File modules/stock_secondary_unit/stock.xml (right):

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
modules/stock_secondary_unit/stock.xml:36: <data depends="stock_lot">
On 2022/08/23 15:52:19, pokoli wrote:
> data can not be inside data. It should be in a separate data. 
> Otherwise is not correctly parsed.

Done.

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
File modules/stock_secondary_unit/tryton.cfg (right):

https://codereview.tryton.org/443501003/diff/431481006/modules/stock_secondar...
modules/stock_secondary_unit/tryton.cfg:8: stock_lot
On 2022/08/23 15:52:19, pokoli wrote:
> Could you add stock_lot as extras in test_module and inlcude trytond_stock_lot
> as test_requirement in setup.py? This will allow to test the module with
> stock_lot activated and test everything works as expected.

Done.

[reviewbot, 2022-08-23 16:10:03]

checks OK
URL: https://codereview.tryton.org/443501003

[pokoli, 2022-08-23 16:11:49]

https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondar...
File modules/stock_secondary_unit/CHANGELOG (right):

https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondar...
modules/stock_secondary_unit/CHANGELOG:1: * Add secondary_quantity for stock lot
trace
Add -> Show?
for -> in

https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondar...
File modules/stock_secondary_unit/stock.py (right):

https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondar...
modules/stock_secondary_unit/stock.py:161: digits='secondary_unit'),
There is no need of extra line

https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondar...
modules/stock_secondary_unit/stock.py:170: @fields.depends('quantity', 'unit',
'secondary_unit', 'move')
there is no need to add move. Better to add secondary_unit_factor and
secondary_unit_rate properties and set move as depends there. Here is an example
on how it can be defined: 

https://github.com/tryton/trytond/commit/a3489cf50eeac5dcd116ee5bafe233c0259d...

[hodeinavarro, 2022-08-23 17:07:57]

Apply remarks

[hodeinavarro, 2022-08-23 17:08:05]

https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondar...
File modules/stock_secondary_unit/CHANGELOG (right):

https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondar...
modules/stock_secondary_unit/CHANGELOG:1: * Add secondary_quantity for stock lot
trace
On 2022/08/23 16:11:49, pokoli wrote:
> Add -> Show?
> for -> in 

Done.

https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondar...
File modules/stock_secondary_unit/stock.py (right):

https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondar...
modules/stock_secondary_unit/stock.py:161: digits='secondary_unit'),
On 2022/08/23 16:11:49, pokoli wrote:
> There is no need of extra line

Done.

https://codereview.tryton.org/443501003/diff/435721003/modules/stock_secondar...
modules/stock_secondary_unit/stock.py:170: @fields.depends('quantity', 'unit',
'secondary_unit', 'move')
On 2022/08/23 16:11:49, pokoli wrote:
> there is no need to add move. Better to add secondary_unit_factor and
> secondary_unit_rate properties and set move as depends there. Here is an
example
> on how it can be defined: 
> 
>
https://github.com/tryton/trytond/commit/a3489cf50eeac5dcd116ee5bafe233c0259d...

Done.

[reviewbot, 2022-08-23 17:40:42]

checks OK
URL: https://codereview.tryton.org/443501003

[ced, 2022-10-10 07:27:57]

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
File modules/stock_secondary_unit/CHANGELOG (right):

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
modules/stock_secondary_unit/CHANGELOG:1: * Show secondary_quantity in stock lot
trace
Better: Add secondary unit on stock lot trace

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
File modules/stock_secondary_unit/setup.py (right):

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
modules/stock_secondary_unit/setup.py:69: ]
wrong indentation

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
File modules/stock_secondary_unit/stock.py (right):

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
modules/stock_secondary_unit/stock.py:171: def
on_change_with_secondary_quantity(self, name=None):
Why not return self.move.secondary_quantity ?

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
File modules/stock_secondary_unit/view/lot_trace_tree.xml (right):

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
modules/stock_secondary_unit/view/lot_trace_tree.xml:1: <?xml version="1.0"?>
missing copyright header

https://codereview.tryton.org/443501003/diff/439431003/modules/stock_secondar...
modules/stock_secondary_unit/view/lot_trace_tree.xml:4: <field
name="secondary_quantity" symbol="secondary_unit" optional="1" />
no space before '/>'