Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 445171003: tryton-env: Support border type on tree affixes.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 3 weeks ago by hodeinavarro
Modified:
5 months, 3 weeks ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use strict equal to check affix border kind #

Total comments: 11

Patch Set 3 : Apply remarks regarding affixes border feature. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M modules/party_avatar/view/company_list.xml View 1 chunk +1 line, -1 line 0 comments Download
M modules/party_avatar/view/employee_list.xml View 1 chunk +1 line, -1 line 0 comments Download
M modules/party_avatar/view/party_list.xml View 1 chunk +1 line, -1 line 0 comments Download
M modules/product_image/view/template_list.xml View 1 chunk +1 line, -1 line 0 comments Download
M sao/src/view/tree.js View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M trytond/doc/topics/views/index.rst View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M trytond/trytond/ir/ui/tree.rnc View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/trytond/ir/ui/tree.rng View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10
hodeinavarro
5 months, 3 weeks ago (2022-08-12 20:44:01 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/445171003
5 months, 3 weeks ago (2022-08-12 20:50:04 UTC) #2
hodeinavarro
I've based the rounded and circle css values from TailwindCSS which is a popular CSS ...
5 months, 3 weeks ago (2022-08-12 20:53:38 UTC) #3
hodeinavarro
Use strict equal to check affix border kind
5 months, 3 weeks ago (2022-08-12 21:05:28 UTC) #4
reviewbot
checks OK URL: https://codereview.tryton.org/445171003
5 months, 3 weeks ago (2022-08-12 21:17:27 UTC) #5
ced
Missing the image widget. https://codereview.tryton.org/445171003/diff/435641004/sao/src/sao.less File sao/src/sao.less (right): https://codereview.tryton.org/445171003/diff/435641004/sao/src/sao.less#newcode505 sao/src/sao.less:505: } Why not use bootstrap ...
5 months, 3 weeks ago (2022-08-13 06:23:14 UTC) #6
hodeinavarro
Apply remarks regarding affixes border feature.
5 months, 3 weeks ago (2022-08-13 12:15:31 UTC) #7
hodeinavarro
https://codereview.tryton.org/445171003/diff/435641004/sao/src/sao.less File sao/src/sao.less (right): https://codereview.tryton.org/445171003/diff/435641004/sao/src/sao.less#newcode505 sao/src/sao.less:505: } On 2022/08/13 06:23:14, ced wrote: > Why not ...
5 months, 3 weeks ago (2022-08-13 12:15:50 UTC) #8
ced
https://codereview.tryton.org/445171003/diff/435641004/sao/src/sao.less File sao/src/sao.less (right): https://codereview.tryton.org/445171003/diff/435641004/sao/src/sao.less#newcode505 sao/src/sao.less:505: } On 2022/08/13 12:15:50, hodeinavarro wrote: > On 2022/08/13 ...
5 months, 3 weeks ago (2022-08-13 12:19:00 UTC) #9
reviewbot
5 months, 3 weeks ago (2022-08-13 12:41:08 UTC) #10
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted