tryton-env: Support border type on tree affixes.

issue11458

[reviewbot, 2022-08-12 20:50:04]

checks OK
URL: https://codereview.tryton.org/445171003

[hodeinavarro, 2022-08-12 20:53:38]

I've based the rounded and circle css values from TailwindCSS which is a popular
CSS framework and is widely used nowadays.
https://tailwindcss.com/docs/border-radius

I'm not very experienced with *.rnc and *.rng files, so I just followed the
patterns.

The "squircle" class cedrik mentions on the issue needs to add an svg to
clip-path the image and I found it annoying so I ended up using the rounded
instead.

[hodeinavarro, 2022-08-12 21:05:28]

Use strict equal to check affix border kind

[reviewbot, 2022-08-12 21:17:27]

checks OK
URL: https://codereview.tryton.org/445171003

[ced, 2022-08-13 06:23:14]

Missing the image widget.

https://codereview.tryton.org/445171003/diff/435641004/sao/src/sao.less
File sao/src/sao.less (right):

https://codereview.tryton.org/445171003/diff/435641004/sao/src/sao.less#newco...
sao/src/sao.less:505: }
Why not use bootstrap tools:
https://getbootstrap.com/docs/3.4/css/#images-shapes

https://codereview.tryton.org/445171003/diff/435641004/sao/src/view/tree.js
File sao/src/view/tree.js (right):

https://codereview.tryton.org/445171003/diff/435641004/sao/src/view/tree.js#n...
sao/src/view/tree.js:2271: if (this.attributes.border === 'rounded') {
could be a switch case.

https://codereview.tryton.org/445171003/diff/435641004/trytond/doc/topics/vie...
File trytond/doc/topics/views/index.rst (right):

https://codereview.tryton.org/445171003/diff/435641004/trytond/doc/topics/vie...
trytond/doc/topics/views/index.rst:739: The border kind to apply. Available
values are ``square``, ``rounded`` or
This sounds odd.
I would say: The type of border for the icon.

https://codereview.tryton.org/445171003/diff/435641004/trytond/doc/topics/vie...
trytond/doc/topics/views/index.rst:741: The default value is ``square``.
The default value is empty, there is no square value.

https://codereview.tryton.org/445171003/diff/435641004/trytond/doc/topics/vie...
trytond/doc/topics/views/index.rst:743: .. note:: The border attribute is
currently only supported on the web client.
I do not think we should document client behavior in trytond doc.

[hodeinavarro, 2022-08-13 12:15:31]

Apply remarks regarding affixes border feature.

[hodeinavarro, 2022-08-13 12:15:50]

https://codereview.tryton.org/445171003/diff/435641004/sao/src/sao.less
File sao/src/sao.less (right):

https://codereview.tryton.org/445171003/diff/435641004/sao/src/sao.less#newco...
sao/src/sao.less:505: }
On 2022/08/13 06:23:14, ced wrote:
> Why not use bootstrap tools:
> https://getbootstrap.com/docs/3.4/css/#images-shapes

Done.

Should I had the thumbnail class?

https://codereview.tryton.org/445171003/diff/435641004/sao/src/view/tree.js
File sao/src/view/tree.js (right):

https://codereview.tryton.org/445171003/diff/435641004/sao/src/view/tree.js#n...
sao/src/view/tree.js:2271: if (this.attributes.border === 'rounded') {
On 2022/08/13 06:23:14, ced wrote:
> could be a switch case.

Done.

https://codereview.tryton.org/445171003/diff/435641004/trytond/doc/topics/vie...
File trytond/doc/topics/views/index.rst (right):

https://codereview.tryton.org/445171003/diff/435641004/trytond/doc/topics/vie...
trytond/doc/topics/views/index.rst:739: The border kind to apply. Available
values are ``square``, ``rounded`` or
On 2022/08/13 06:23:14, ced wrote:
> This sounds odd.
> I would say: The type of border for the icon.

Done.

https://codereview.tryton.org/445171003/diff/435641004/trytond/doc/topics/vie...
trytond/doc/topics/views/index.rst:741: The default value is ``square``.
On 2022/08/13 06:23:14, ced wrote:
> The default value is empty, there is no square value.

Done.

https://codereview.tryton.org/445171003/diff/435641004/trytond/doc/topics/vie...
trytond/doc/topics/views/index.rst:743: .. note:: The border attribute is
currently only supported on the web client.
On 2022/08/13 06:23:14, ced wrote:
> I do not think we should document client behavior in trytond doc.

Done.

[ced, 2022-08-13 12:19:00]

https://codereview.tryton.org/445171003/diff/435641004/sao/src/sao.less
File sao/src/sao.less (right):

https://codereview.tryton.org/445171003/diff/435641004/sao/src/sao.less#newco...
sao/src/sao.less:505: }
On 2022/08/13 12:15:50, hodeinavarro wrote:
> On 2022/08/13 06:23:14, ced wrote:
> > Why not use bootstrap tools:
> > https://getbootstrap.com/docs/3.4/css/#images-shapes
> 
> Done.
> 
> Should I had the thumbnail class?

I do not think it is useful for an application.

[reviewbot, 2022-08-13 12:41:08]

checks OK
URL: https://codereview.tryton.org/445171003