Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(135)

Issue 44551003: trytond: Add help texts.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by udono
Modified:
2 months, 1 week ago
Reviewers:
dave, reviewbot, ced, pokoli
Visibility:
Public.

Description

COLLABORATOR=dave@liberteq.org issue7034

Patch Set 1 #

Total comments: 57

Patch Set 2 : Fix Pokolis comments and general re-work. #

Patch Set 3 : Fix Pokolis comments 2 #

Patch Set 4 : Update tip #

Patch Set 5 : Fix typos #

Patch Set 6 : Update tip #

Patch Set 7 : Update tip #

Total comments: 108

Patch Set 8 : update tip #

Patch Set 9 : ceds comments #

Patch Set 10 : Update tip #

Patch Set 11 : Split review #

Patch Set 12 : Add help to ir.model.button instead of view. #

Patch Set 13 : Remove unrelated file. #

Total comments: 41

Patch Set 14 : Update to tip rev6571df5d8026 #

Patch Set 15 : Improve help text #

Total comments: 12

Patch Set 16 : Apply changes from comments. #

Total comments: 144

Patch Set 17 : Improve text based on comments #

Patch Set 18 : Improve sequence timestamp help text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -239 lines) Patch
M trytond/ir/action.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 12 chunks +98 lines, -56 lines 0 comments Download
M trytond/ir/attachment.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +14 lines, -6 lines 0 comments Download
M trytond/ir/cron.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +19 lines, -13 lines 0 comments Download
M trytond/ir/cron.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M trytond/ir/export.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +6 lines, -3 lines 0 comments Download
M trytond/ir/lang.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +59 lines, -19 lines 0 comments Download
M trytond/ir/model.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 11 chunks +100 lines, -59 lines 0 comments Download
M trytond/ir/model.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M trytond/ir/module.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 7 chunks +24 lines, -13 lines 0 comments Download
M trytond/ir/note.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +8 lines, -5 lines 0 comments Download
M trytond/ir/resource.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +6 lines, -3 lines 0 comments Download
M trytond/ir/rule.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +25 lines, -14 lines 0 comments Download
M trytond/ir/sequence.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +24 lines, -11 lines 0 comments Download
M trytond/ir/translation.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 7 chunks +34 lines, -21 lines 0 comments Download
M trytond/ir/trigger.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +22 lines, -14 lines 0 comments Download
M trytond/ir/view/translation_clean_succeed_form.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M trytond/ir/view/translation_set_succeed_form.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 57
udono
1 year, 2 months ago (2017-12-26 11:04:29 UTC) #1
reviewbot
https://codereview.tryton.org/44551003/diff/1/trytond/res/ir.py#newcode125 trytond/res/ir.py:125: F841 local variable 'database' is assigned to but never used https://codereview.tryton.org/44551003/diff/1/trytond/res/user.py#newcode548 trytond/res/user.py:548: E712 ...
1 year, 2 months ago (2017-12-26 11:33:42 UTC) #2
pokoli
Thanks for your work. I haven't review all the code but there are some guideliness ...
1 year, 2 months ago (2018-01-11 09:43:24 UTC) #3
ced
1 year ago (2018-03-04 13:26:46 UTC) #4
udono
Fix Pokolis comments and general re-work.
12 months ago (2018-03-20 20:24:50 UTC) #5
udono
https://tryton-rietveld.appspot.com/44551003/diff/1/trytond/ir/action.py File trytond/ir/action.py (right): https://tryton-rietveld.appspot.com/44551003/diff/1/trytond/ir/action.py#newcode36 trytond/ir/action.py:36: help="The model which specifies the result of the action ...
12 months ago (2018-03-20 20:25:23 UTC) #6
reviewbot
https://codereview.tryton.org/44551003/diff/20001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/20001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
12 months ago (2018-03-20 20:53:27 UTC) #7
pokoli
https://codereview.tryton.org/44551003/diff/1/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/1/trytond/ir/action.py#newcode36 trytond/ir/action.py:36: help="The model which specifies the result of the action ...
12 months ago (2018-03-21 10:13:27 UTC) #8
udono
Fix Pokolis comments 2
12 months ago (2018-03-21 11:18:42 UTC) #9
udono
https://codereview.tryton.org/44551003/diff/1/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/1/trytond/ir/action.py#newcode36 trytond/ir/action.py:36: help="The model which specifies the result of the action ...
12 months ago (2018-03-21 11:19:50 UTC) #10
reviewbot
https://codereview.tryton.org/44551003/diff/40001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/40001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
12 months ago (2018-03-21 11:22:48 UTC) #11
udono
Update tip
11 months, 2 weeks ago (2018-04-04 08:14:18 UTC) #12
reviewbot
https://codereview.tryton.org/44551003/diff/60001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/60001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
11 months, 2 weeks ago (2018-04-04 08:27:53 UTC) #13
udono
Fix typos
11 months, 2 weeks ago (2018-04-04 12:32:20 UTC) #14
reviewbot
https://codereview.tryton.org/44551003/diff/80001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/80001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
11 months, 2 weeks ago (2018-04-04 12:58:30 UTC) #15
udono
Update tip
11 months, 2 weeks ago (2018-04-05 17:25:10 UTC) #16
reviewbot
https://codereview.tryton.org/44551003/diff/100001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/100001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
11 months, 2 weeks ago (2018-04-05 17:34:04 UTC) #17
udono
Update tip
10 months, 4 weeks ago (2018-04-25 06:48:48 UTC) #18
reviewbot
https://codereview.tryton.org/44551003/diff/120001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/120001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
10 months, 4 weeks ago (2018-04-25 07:03:31 UTC) #19
ced
I reviewed only the first file. I'm wondering if it will not be better to ...
10 months, 1 week ago (2018-05-15 10:51:13 UTC) #20
udono
update tip
9 months ago (2018-06-20 15:59:28 UTC) #21
reviewbot
https://codereview.tryton.org/44551003/diff/140001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/140001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
9 months ago (2018-06-20 16:02:33 UTC) #22
udono
ceds comments
9 months ago (2018-06-20 16:51:40 UTC) #23
udono
https://tryton-rietveld.appspot.com/44551003/diff/120001/trytond/ir/action.py File trytond/ir/action.py (right): https://tryton-rietveld.appspot.com/44551003/diff/120001/trytond/ir/action.py#newcode36 trytond/ir/action.py:36: usage = fields.Char('Usage', help="Add the use of the action.") ...
9 months ago (2018-06-20 16:52:06 UTC) #24
reviewbot
https://codereview.tryton.org/44551003/diff/160001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/160001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
9 months ago (2018-06-20 16:56:37 UTC) #25
ced
On 2018/06/20 16:51:40, udono wrote: > ceds comments I really encourage to split this review ...
9 months ago (2018-06-21 07:12:00 UTC) #26
udono
Update tip
8 months, 1 week ago (2018-07-16 06:34:42 UTC) #27
udono
Split review
8 months, 1 week ago (2018-07-16 06:36:47 UTC) #28
reviewbot
https://codereview.tryton.org/44551003/diff/200001/trytond/ir/action.py#newcode273 trytond/ir/action.py:273: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/44551003/diff/200001/trytond/ir/action.py#newcode282 trytond/ir/action.py:282: E731 ...
8 months, 1 week ago (2018-07-16 06:41:57 UTC) #29
udono
On 2018/06/21 07:12:00, ced wrote: > On 2018/06/20 16:51:40, udono wrote: > > ceds comments ...
8 months, 1 week ago (2018-07-16 06:49:14 UTC) #30
udono
Add help to ir.model.button instead of view.
7 months, 2 weeks ago (2018-08-06 13:08:05 UTC) #31
reviewbot
https://codereview.tryton.org/44551003/diff/220001/trytond/ir/action.py#newcode272 trytond/ir/action.py:272: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/44551003/diff/220001/trytond/ir/action.py#newcode281 trytond/ir/action.py:281: E731 ...
7 months, 2 weeks ago (2018-08-06 13:11:24 UTC) #32
udono
Remove unrelated file.
7 months, 2 weeks ago (2018-08-06 13:14:32 UTC) #33
reviewbot
https://codereview.tryton.org/44551003/diff/240001/trytond/ir/action.py#newcode272 trytond/ir/action.py:272: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/44551003/diff/240001/trytond/ir/action.py#newcode281 trytond/ir/action.py:281: E731 ...
7 months, 2 weeks ago (2018-08-06 13:41:35 UTC) #34
pokoli
https://codereview.tryton.org/44551003/diff/240001/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/240001/trytond/ir/action.py#newcode40 trytond/ir/action.py:40: 'Groups', help="If set, it limits the access rights to ...
3 months, 3 weeks ago (2018-11-26 12:37:06 UTC) #35
ced
https://codereview.tryton.org/44551003/diff/240001/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/240001/trytond/ir/action.py#newcode40 trytond/ir/action.py:40: 'Groups', help="If set, it limits the access rights to ...
3 months, 3 weeks ago (2018-11-26 13:34:32 UTC) #36
dave
I've reviewed the first file: action.py, and I'm thinking it might be easier if you ...
3 months, 3 weeks ago (2018-11-26 14:51:49 UTC) #37
udono
Hi Dave, thanks a lot for helping on the tool tips! > I've reviewed the ...
3 months, 3 weeks ago (2018-11-26 17:58:00 UTC) #38
ced
https://codereview.tryton.org/44551003/diff/240001/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/240001/trytond/ir/action.py#newcode496 trytond/ir/action.py:496: "See also the LibreOffice documentation for a list of ...
3 months, 3 weeks ago (2018-11-26 18:03:48 UTC) #39
udono
the patch applies on rev42cd96d58788
3 months, 3 weeks ago (2018-11-28 16:23:23 UTC) #40
dave
Update to tip rev6571df5d8026
3 months, 2 weeks ago (2018-12-06 12:17:47 UTC) #41
reviewbot
https://codereview.tryton.org/44551003/diff/260001/trytond/ir/action.py#newcode271 trytond/ir/action.py:271: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/44551003/diff/260001/trytond/ir/action.py#newcode280 trytond/ir/action.py:280: E731 ...
3 months, 2 weeks ago (2018-12-06 12:41:24 UTC) #42
dave
Improve help text
3 months ago (2018-12-14 15:58:26 UTC) #43
reviewbot
https://codereview.tryton.org/44551003/diff/280001/trytond/ir/action.py#newcode274 trytond/ir/action.py:274: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/44551003/diff/280001/trytond/ir/action.py#newcode283 trytond/ir/action.py:283: E731 ...
3 months ago (2018-12-14 16:17:59 UTC) #44
udono
https://codereview.tryton.org/44551003/diff/280001/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/280001/trytond/ir/action.py#newcode38 trytond/ir/action.py:38: help="The events that can trigger the action.") not sure ...
3 months ago (2018-12-15 06:58:42 UTC) #45
dave
Apply changes from comments.
3 months ago (2018-12-17 12:37:23 UTC) #46
dave
https://codereview.tryton.org/44551003/diff/280001/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/280001/trytond/ir/action.py#newcode38 trytond/ir/action.py:38: help="The events that can trigger the action.") On 2018/12/15 ...
3 months ago (2018-12-17 12:37:57 UTC) #47
reviewbot
https://codereview.tryton.org/44551003/diff/300001/trytond/ir/action.py#newcode274 trytond/ir/action.py:274: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/44551003/diff/300001/trytond/ir/action.py#newcode283 trytond/ir/action.py:283: E731 ...
3 months ago (2018-12-17 12:43:13 UTC) #48
ced
https://codereview.tryton.org/44551003/diff/300001/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/300001/trytond/ir/action.py#newcode99 trytond/ir/action.py:99: "Keyword" I think it is better to keep "Action ...
2 months, 3 weeks ago (2018-12-23 16:23:34 UTC) #49
udono
https://codereview.tryton.org/44551003/diff/300001/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/300001/trytond/ir/action.py#newcode391 trytond/ir/action.py:391: "Report" On 2018/12/23 16:23:29, ced wrote: > Idem Why ...
2 months, 2 weeks ago (2019-01-02 11:36:45 UTC) #50
ced
https://codereview.tryton.org/44551003/diff/300001/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/300001/trytond/ir/action.py#newcode395 trytond/ir/action.py:395: help="The name of the model that renders the report.") ...
2 months, 2 weeks ago (2019-01-02 11:57:03 UTC) #51
dave
Improve text based on comments
2 months, 1 week ago (2019-01-08 16:14:38 UTC) #52
dave
https://codereview.tryton.org/44551003/diff/300001/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/300001/trytond/ir/action.py#newcode99 trytond/ir/action.py:99: "Keyword" On 2018/12/23 16:23:30, ced wrote: > I think ...
2 months, 1 week ago (2019-01-08 16:15:26 UTC) #53
ced
https://codereview.tryton.org/44551003/diff/300001/trytond/ir/sequence.py File trytond/ir/sequence.py (right): https://codereview.tryton.org/44551003/diff/300001/trytond/ir/sequence.py#newcode77 trytond/ir/sequence.py:77: help="The number of seconds that the Unix timestamp is ...
2 months, 1 week ago (2019-01-08 16:34:31 UTC) #54
reviewbot
patch is not applicable URL: https://codereview.tryton.org/44551003
2 months, 1 week ago (2019-01-08 16:35:19 UTC) #55
dave
Improve sequence timestamp help text
2 months, 1 week ago (2019-01-08 16:58:59 UTC) #56
reviewbot
2 months, 1 week ago (2019-01-08 17:07:18 UTC) #57
patch is not applicable
URL: https://codereview.tryton.org/44551003
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766