Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 44551003: trytond: Add help texts.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 3 weeks ago by udono
Modified:
2 weeks ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 57

Patch Set 2 : Fix Pokolis comments and general re-work. #

Patch Set 3 : Fix Pokolis comments 2 #

Patch Set 4 : Update tip #

Patch Set 5 : Fix typos #

Patch Set 6 : Update tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+675 lines, -379 lines) Patch
M trytond/commandline.py View 1 2 chunks +6 lines, -6 lines 0 comments Download
M trytond/ir/action.py View 1 2 3 11 chunks +103 lines, -58 lines 0 comments Download
M trytond/ir/attachment.py View 1 1 chunk +13 lines, -6 lines 0 comments Download
M trytond/ir/cron.py View 1 2 3 1 chunk +21 lines, -14 lines 0 comments Download
M trytond/ir/cron.xml View 1 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/export.py View 1 1 chunk +7 lines, -4 lines 0 comments Download
M trytond/ir/lang.py View 1 2 3 1 chunk +64 lines, -23 lines 0 comments Download
M trytond/ir/model.py View 1 2 3 10 chunks +90 lines, -53 lines 0 comments Download
M trytond/ir/model.xml View 1 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/module.py View 1 6 chunks +33 lines, -18 lines 0 comments Download
M trytond/ir/note.py View 1 2 chunks +7 lines, -5 lines 0 comments Download
M trytond/ir/resource.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M trytond/ir/rule.py View 1 2 chunks +26 lines, -15 lines 0 comments Download
M trytond/ir/sequence.py View 1 2 3 2 chunks +28 lines, -14 lines 0 comments Download
M trytond/ir/translation.py View 1 8 chunks +41 lines, -24 lines 0 comments Download
M trytond/ir/trigger.py View 1 2 3 1 chunk +25 lines, -15 lines 0 comments Download
M trytond/ir/ui/icon.py View 1 1 chunk +10 lines, -5 lines 0 comments Download
M trytond/ir/ui/menu.py View 1 2 3 4 3 chunks +20 lines, -13 lines 0 comments Download
M trytond/ir/ui/view.py View 1 6 chunks +47 lines, -25 lines 0 comments Download
M trytond/ir/ui/view.xml View 1 2 chunks +2 lines, -2 lines 0 comments Download
M trytond/ir/view/cron_form.xml View 1 1 chunk +2 lines, -1 line 0 comments Download
M trytond/ir/view/cron_list.xml View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M trytond/ir/view/model_data_form.xml View 1 1 chunk +2 lines, -1 line 0 comments Download
M trytond/ir/view/model_data_list.xml View 1 1 chunk +2 lines, -1 line 0 comments Download
M trytond/ir/view/module_form.xml View 1 1 chunk +12 lines, -6 lines 0 comments Download
M trytond/ir/view/ui_view_form.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M trytond/model/dictschema.py View 1 2 chunks +13 lines, -7 lines 0 comments Download
M trytond/model/model.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M trytond/model/modelstorage.py View 1 1 chunk +10 lines, -5 lines 0 comments Download
M trytond/model/order.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M trytond/res/group.py View 1 1 chunk +12 lines, -7 lines 0 comments Download
M trytond/res/ir.py View 1 2 3 5 chunks +9 lines, -7 lines 0 comments Download
M trytond/res/user.py View 1 2 3 4 chunks +50 lines, -27 lines 0 comments Download
M trytond/res/view/user_application_form.xml View 1 1 chunk +4 lines, -2 lines 0 comments Download
M trytond/res/view/user_application_list.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/tests/run-tests.py View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17
udono
3 months, 3 weeks ago (2017-12-26 11:04:29 UTC) #1
reviewbot
https://codereview.tryton.org/44551003/diff/1/trytond/res/ir.py#newcode125 trytond/res/ir.py:125: F841 local variable 'database' is assigned to but never used https://codereview.tryton.org/44551003/diff/1/trytond/res/user.py#newcode548 trytond/res/user.py:548: E712 ...
3 months, 3 weeks ago (2017-12-26 11:33:42 UTC) #2
pokoli
Thanks for your work. I haven't review all the code but there are some guideliness ...
3 months, 1 week ago (2018-01-11 09:43:24 UTC) #3
ced
1 month, 2 weeks ago (2018-03-04 13:26:46 UTC) #4
udono
Fix Pokolis comments and general re-work.
1 month ago (2018-03-20 20:24:50 UTC) #5
udono
https://tryton-rietveld.appspot.com/44551003/diff/1/trytond/ir/action.py File trytond/ir/action.py (right): https://tryton-rietveld.appspot.com/44551003/diff/1/trytond/ir/action.py#newcode36 trytond/ir/action.py:36: help="The model which specifies the result of the action ...
1 month ago (2018-03-20 20:25:23 UTC) #6
reviewbot
https://codereview.tryton.org/44551003/diff/20001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/20001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
1 month ago (2018-03-20 20:53:27 UTC) #7
pokoli
https://codereview.tryton.org/44551003/diff/1/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/1/trytond/ir/action.py#newcode36 trytond/ir/action.py:36: help="The model which specifies the result of the action ...
4 weeks, 1 day ago (2018-03-21 10:13:27 UTC) #8
udono
Fix Pokolis comments 2
4 weeks, 1 day ago (2018-03-21 11:18:42 UTC) #9
udono
https://codereview.tryton.org/44551003/diff/1/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/1/trytond/ir/action.py#newcode36 trytond/ir/action.py:36: help="The model which specifies the result of the action ...
4 weeks, 1 day ago (2018-03-21 11:19:50 UTC) #10
reviewbot
https://codereview.tryton.org/44551003/diff/40001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/40001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
4 weeks, 1 day ago (2018-03-21 11:22:48 UTC) #11
udono
Update tip
2 weeks, 1 day ago (2018-04-04 08:14:18 UTC) #12
reviewbot
https://codereview.tryton.org/44551003/diff/60001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/60001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
2 weeks, 1 day ago (2018-04-04 08:27:53 UTC) #13
udono
Fix typos
2 weeks, 1 day ago (2018-04-04 12:32:20 UTC) #14
reviewbot
https://codereview.tryton.org/44551003/diff/80001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/80001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
2 weeks, 1 day ago (2018-04-04 12:58:30 UTC) #15
udono
Update tip
2 weeks ago (2018-04-05 17:25:10 UTC) #16
reviewbot
2 weeks ago (2018-04-05 17:34:04 UTC) #17
https://codereview.tryton.org/44551003/diff/100001/trytond/tests/run-tests.py...
trytond/tests/run-tests.py:44:
E402 module level import not at top of file

https://codereview.tryton.org/44551003/diff/100001/trytond/model/model.py#new...
trytond/model/model.py:181:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/44551003/diff/100001/trytond/model/model.py#new...
trytond/model/model.py:244:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/44551003/diff/100001/trytond/model/model.py#new...
trytond/model/model.py:270:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/44551003/diff/100001/trytond/res/ir.py#newcode125
trytond/res/ir.py:125:
F841 local variable 'database' is assigned to but never used

https://codereview.tryton.org/44551003/diff/100001/trytond/res/user.py#newcod...
trytond/res/user.py:634:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/action.py#newco...
trytond/ir/action.py:274:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/action.py#newco...
trytond/ir/action.py:283:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/attachment.py#n...
trytond/ir/attachment.py:62:
E303 too many blank lines (2)

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/lang.py#newcode9
trytond/ir/lang.py:9:
E402 module level import not at top of file

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/lang.py#newcode11
trytond/ir/lang.py:11:
E402 module level import not at top of file

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/lang.py#newcode13
trytond/ir/lang.py:13:
E402 module level import not at top of file

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/lang.py#newcode15
trytond/ir/lang.py:15:
E402 module level import not at top of file

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/lang.py#newcode16
trytond/ir/lang.py:16:
E402 module level import not at top of file

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/lang.py#newcode17
trytond/ir/lang.py:17:
E402 module level import not at top of file

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/lang.py#newcode18
trytond/ir/lang.py:18:
E402 module level import not at top of file

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/lang.py#newcode19
trytond/ir/lang.py:19:
E402 module level import not at top of file

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/lang.py#newcode20
trytond/ir/lang.py:20:
E402 module level import not at top of file

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/lang.py#newcode51
trytond/ir/lang.py:51:
E302 expected 2 blank lines, found 1

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/model.py#newcode99
trytond/ir/model.py:99:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/model.py#newcod...
trytond/ir/model.py:258:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/model.py#newcod...
trytond/ir/model.py:484:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/model.py#newcod...
trytond/ir/model.py:679:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/model.py#newcod...
trytond/ir/model.py:679:
E203 whitespace before ','

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/model.py#newcod...
trytond/ir/model.py:1094:
E202 whitespace before ')'

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/model.py#newcod...
trytond/ir/model.py:1134:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/rule.py#newcode53
trytond/ir/rule.py:53:
E712 comparison to False should be 'if cond is False:' or 'if not cond:'

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/rule.py#newcode204
trytond/ir/rule.py:204:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/translation.py#...
trytond/ir/translation.py:236:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/translation.py#...
trytond/ir/translation.py:255:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/translation.py#...
trytond/ir/translation.py:275:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/translation.py#...
trytond/ir/translation.py:309:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/translation.py#...
trytond/ir/translation.py:336:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/translation.py#...
trytond/ir/translation.py:382:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/translation.py#...
trytond/ir/translation.py:469:
E712 comparison to False should be 'if cond is False:' or 'if not cond:'

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/translation.py#...
trytond/ir/translation.py:670:
E712 comparison to False should be 'if cond is False:' or 'if not cond:'

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/translation.py#...
trytond/ir/translation.py:1122:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/translation.py#...
trytond/ir/translation.py:1220:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/trigger.py#newc...
trytond/ir/trigger.py:72:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/44551003/diff/100001/trytond/ir/ui/menu.py#newc...
trytond/ir/ui/menu.py:205:
E731 do not assign a lambda expression, use a def

URL: https://codereview.tryton.org/44551003
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922