Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 44551003: trytond: Add help texts.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 4 weeks ago by udono
Modified:
1 week ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 57

Patch Set 2 : Fix Pokolis comments and general re-work. #

Patch Set 3 : Fix Pokolis comments 2 #

Patch Set 4 : Update tip #

Patch Set 5 : Fix typos #

Patch Set 6 : Update tip #

Patch Set 7 : Update tip #

Total comments: 108

Patch Set 8 : update tip #

Patch Set 9 : ceds comments #

Patch Set 10 : Update tip #

Patch Set 11 : Split review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -263 lines) Patch
M trytond/ir/action.py View 1 2 3 4 5 6 7 8 11 chunks +91 lines, -56 lines 0 comments Download
M trytond/ir/attachment.py View 1 1 chunk +13 lines, -6 lines 0 comments Download
M trytond/ir/cron.py View 1 2 3 1 chunk +21 lines, -14 lines 0 comments Download
M trytond/ir/cron.xml View 1 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/export.py View 1 1 chunk +7 lines, -4 lines 0 comments Download
M trytond/ir/lang.py View 1 2 3 4 5 6 7 8 9 1 chunk +64 lines, -23 lines 0 comments Download
M trytond/ir/model.py View 1 2 3 4 5 6 7 10 chunks +90 lines, -53 lines 0 comments Download
M trytond/ir/model.xml View 1 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/module.py View 1 2 3 4 5 6 7 8 9 6 chunks +33 lines, -18 lines 0 comments Download
M trytond/ir/note.py View 1 2 chunks +7 lines, -5 lines 0 comments Download
M trytond/ir/resource.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M trytond/ir/rule.py View 1 2 3 4 5 6 7 8 9 2 chunks +26 lines, -15 lines 0 comments Download
M trytond/ir/sequence.py View 1 2 3 2 chunks +28 lines, -14 lines 0 comments Download
M trytond/ir/translation.py View 1 2 3 4 5 6 7 8 9 8 chunks +41 lines, -24 lines 0 comments Download
M trytond/ir/trigger.py View 1 2 3 1 chunk +25 lines, -15 lines 0 comments Download
M trytond/ir/view/cron_form.xml View 1 1 chunk +2 lines, -1 line 0 comments Download
M trytond/ir/view/cron_list.xml View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M trytond/ir/view/model_data_form.xml View 1 1 chunk +2 lines, -1 line 0 comments Download
M trytond/ir/view/model_data_list.xml View 1 1 chunk +2 lines, -1 line 0 comments Download
M trytond/ir/view/module_form.xml View 1 1 chunk +12 lines, -6 lines 0 comments Download
M trytond/ir/view/ui_view_form.xml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30
udono
6 months, 4 weeks ago (2017-12-26 11:04:29 UTC) #1
reviewbot
https://codereview.tryton.org/44551003/diff/1/trytond/res/ir.py#newcode125 trytond/res/ir.py:125: F841 local variable 'database' is assigned to but never used https://codereview.tryton.org/44551003/diff/1/trytond/res/user.py#newcode548 trytond/res/user.py:548: E712 ...
6 months, 4 weeks ago (2017-12-26 11:33:42 UTC) #2
pokoli
Thanks for your work. I haven't review all the code but there are some guideliness ...
6 months, 1 week ago (2018-01-11 09:43:24 UTC) #3
ced
4 months, 3 weeks ago (2018-03-04 13:26:46 UTC) #4
udono
Fix Pokolis comments and general re-work.
4 months ago (2018-03-20 20:24:50 UTC) #5
udono
https://tryton-rietveld.appspot.com/44551003/diff/1/trytond/ir/action.py File trytond/ir/action.py (right): https://tryton-rietveld.appspot.com/44551003/diff/1/trytond/ir/action.py#newcode36 trytond/ir/action.py:36: help="The model which specifies the result of the action ...
4 months ago (2018-03-20 20:25:23 UTC) #6
reviewbot
https://codereview.tryton.org/44551003/diff/20001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/20001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
4 months ago (2018-03-20 20:53:27 UTC) #7
pokoli
https://codereview.tryton.org/44551003/diff/1/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/1/trytond/ir/action.py#newcode36 trytond/ir/action.py:36: help="The model which specifies the result of the action ...
4 months ago (2018-03-21 10:13:27 UTC) #8
udono
Fix Pokolis comments 2
4 months ago (2018-03-21 11:18:42 UTC) #9
udono
https://codereview.tryton.org/44551003/diff/1/trytond/ir/action.py File trytond/ir/action.py (right): https://codereview.tryton.org/44551003/diff/1/trytond/ir/action.py#newcode36 trytond/ir/action.py:36: help="The model which specifies the result of the action ...
4 months ago (2018-03-21 11:19:50 UTC) #10
reviewbot
https://codereview.tryton.org/44551003/diff/40001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/40001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
4 months ago (2018-03-21 11:22:48 UTC) #11
udono
Update tip
3 months, 2 weeks ago (2018-04-04 08:14:18 UTC) #12
reviewbot
https://codereview.tryton.org/44551003/diff/60001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/60001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
3 months, 2 weeks ago (2018-04-04 08:27:53 UTC) #13
udono
Fix typos
3 months, 2 weeks ago (2018-04-04 12:32:20 UTC) #14
reviewbot
https://codereview.tryton.org/44551003/diff/80001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/80001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
3 months, 2 weeks ago (2018-04-04 12:58:30 UTC) #15
udono
Update tip
3 months, 2 weeks ago (2018-04-05 17:25:10 UTC) #16
reviewbot
https://codereview.tryton.org/44551003/diff/100001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/100001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
3 months, 2 weeks ago (2018-04-05 17:34:04 UTC) #17
udono
Update tip
2 months, 4 weeks ago (2018-04-25 06:48:48 UTC) #18
reviewbot
https://codereview.tryton.org/44551003/diff/120001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/120001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
2 months, 4 weeks ago (2018-04-25 07:03:31 UTC) #19
ced
I reviewed only the first file. I'm wondering if it will not be better to ...
2 months, 1 week ago (2018-05-15 10:51:13 UTC) #20
udono
update tip
1 month ago (2018-06-20 15:59:28 UTC) #21
reviewbot
https://codereview.tryton.org/44551003/diff/140001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/140001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
1 month ago (2018-06-20 16:02:33 UTC) #22
udono
ceds comments
1 month ago (2018-06-20 16:51:40 UTC) #23
udono
https://tryton-rietveld.appspot.com/44551003/diff/120001/trytond/ir/action.py File trytond/ir/action.py (right): https://tryton-rietveld.appspot.com/44551003/diff/120001/trytond/ir/action.py#newcode36 trytond/ir/action.py:36: usage = fields.Char('Usage', help="Add the use of the action.") ...
1 month ago (2018-06-20 16:52:06 UTC) #24
reviewbot
https://codereview.tryton.org/44551003/diff/160001/trytond/tests/run-tests.py#newcode44 trytond/tests/run-tests.py:44: E402 module level import not at top of file https://codereview.tryton.org/44551003/diff/160001/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation ...
1 month ago (2018-06-20 16:56:37 UTC) #25
ced
On 2018/06/20 16:51:40, udono wrote: > ceds comments I really encourage to split this review ...
1 month ago (2018-06-21 07:12:00 UTC) #26
udono
Update tip
1 week ago (2018-07-16 06:34:42 UTC) #27
udono
Split review
1 week ago (2018-07-16 06:36:47 UTC) #28
reviewbot
https://codereview.tryton.org/44551003/diff/200001/trytond/ir/action.py#newcode273 trytond/ir/action.py:273: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/44551003/diff/200001/trytond/ir/action.py#newcode282 trytond/ir/action.py:282: E731 ...
1 week ago (2018-07-16 06:41:57 UTC) #29
udono
1 week ago (2018-07-16 06:49:14 UTC) #30
On 2018/06/21 07:12:00, ced wrote:
> On 2018/06/20 16:51:40, udono wrote:
> > ceds comments
> I really encourage to split this review into multiple small patches. Otherwise
I
> will probably not make a second review of first files before months because it
> is too much painful to re-review and spotting the differences and knowing that
> it will change again in few months (such big patch will take months to be
> included).

done:

review44551003 trytond/ir
review47601002 trytond/ir/ui
review58351002 trytond/res
review58351003 trytond/model
review58341002 trytond
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69