Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1661)

Issue 44571002: stock: Do not fill inventory quantity automatically (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months ago by pokoli
Modified:
7 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Raise user warning if empty quantity #

Patch Set 3 : Test warning on scenario #

Patch Set 4 : Allow to define how inventory empty lines are managed #

Total comments: 10

Patch Set 5 : Remove configuration, compute on get_move and show field after button #

Patch Set 6 : update to tip #

Total comments: 4

Patch Set 7 : Fix ced comments and add separate scenario #

Total comments: 5

Patch Set 8 : Fix comments #

Patch Set 9 : Update to tip #

Total comments: 3

Patch Set 10 : Fix ced's comments #

Total comments: 1

Patch Set 11 : Use ced's suggestion for error message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -11 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M inventory.py View 1 2 3 4 5 6 7 8 9 10 7 chunks +26 lines, -7 lines 0 comments Download
M setup.py View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M tests/scenario_stock_inventory.rst View 1 2 3 4 5 6 7 8 9 5 chunks +15 lines, -4 lines 0 comments Download
A tests/scenario_stock_inventory_empty_quantity.rst View 1 2 3 4 5 6 7 8 9 1 chunk +87 lines, -0 lines 0 comments Download
M tests/test_stock.py View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
M view/inventory_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 36
pokoli
9 months ago (2018-01-12 12:20:54 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/44571002
9 months ago (2018-01-12 12:41:17 UTC) #2
ced
9 months ago (2018-01-12 12:57:29 UTC) #3
pokoli
Raise user warning if empty quantity
9 months ago (2018-01-12 13:22:16 UTC) #4
pokoli
Test warning on scenario
9 months ago (2018-01-12 13:25:39 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/44571002
9 months ago (2018-01-12 13:34:11 UTC) #6
ced
See https://bugs.tryton.org/msg37596
9 months ago (2018-01-17 20:32:50 UTC) #7
pokoli
On 2018/01/17 20:32:50, ced wrote: > See https://bugs.tryton.org/msg37596 That's managed by the warning
9 months ago (2018-01-18 08:44:52 UTC) #8
ced
On 2018/01/18 08:44:52, pokoli wrote: > On 2018/01/17 20:32:50, ced wrote: > > See https://bugs.tryton.org/msg37596 ...
9 months ago (2018-01-18 09:22:20 UTC) #9
pokoli
On 2018/01/18 09:22:20, ced wrote: > On 2018/01/18 08:44:52, pokoli wrote: > > On 2018/01/17 ...
8 months, 3 weeks ago (2018-01-22 11:44:13 UTC) #10
ced
On 2018/01/22 11:44:13, pokoli wrote: > On 2018/01/18 09:22:20, ced wrote: > > On 2018/01/18 ...
8 months, 3 weeks ago (2018-01-22 11:52:25 UTC) #11
ced
8 months, 3 weeks ago (2018-01-22 11:52:30 UTC) #12
pokoli
Allow to define how inventory empty lines are managed
8 months, 3 weeks ago (2018-01-23 09:17:49 UTC) #13
reviewbot
https://codereview.tryton.org/44571002/diff/50001/__init__.py#newcode5 __init__.py:5: F403 'from location import *' used; unable to detect undefined names https://codereview.tryton.org/44571002/diff/50001/__init__.py#newcode6 __init__.py:6: ...
8 months, 3 weeks ago (2018-01-23 09:35:14 UTC) #14
ced
https://codereview.tryton.org/44571002/diff/50001/inventory.py File inventory.py (right): https://codereview.tryton.org/44571002/diff/50001/inventory.py#newcode51 inventory.py:51: ('empty', "Empty"), I think it should be empty by ...
8 months, 3 weeks ago (2018-01-23 17:55:13 UTC) #15
pokoli
Remove configuration, compute on get_move and show field after button
8 months, 2 weeks ago (2018-01-29 15:33:33 UTC) #16
pokoli
https://codereview.tryton.org/44571002/diff/50001/inventory.py File inventory.py (right): https://codereview.tryton.org/44571002/diff/50001/inventory.py#newcode51 inventory.py:51: ('empty', "Empty"), On 2018/01/23 17:55:12, ced wrote: > I ...
8 months, 2 weeks ago (2018-01-29 15:34:05 UTC) #17
reviewbot
flake8 OK URL: https://codereview.tryton.org/44571002
8 months, 2 weeks ago (2018-01-29 15:46:12 UTC) #18
pokoli
update to tip
8 months ago (2018-02-12 11:33:03 UTC) #19
reviewbot
flake8 OK URL: https://codereview.tryton.org/44571002
8 months ago (2018-02-12 11:53:30 UTC) #20
ced
https://codereview.tryton.org/44571002/diff/90001/inventory.py File inventory.py (right): https://codereview.tryton.org/44571002/diff/90001/inventory.py#newcode51 inventory.py:51: ('empty', "Empty"), I said previously that it should be ...
8 months ago (2018-02-12 22:37:02 UTC) #21
pokoli
Fix ced comments and add separate scenario
7 months, 4 weeks ago (2018-02-19 10:03:57 UTC) #22
reviewbot
https://codereview.tryton.org/44571002/diff/110001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/44571002
7 months, 4 weeks ago (2018-02-19 10:21:12 UTC) #23
ced
https://codereview.tryton.org/44571002/diff/110001/inventory.py File inventory.py (right): https://codereview.tryton.org/44571002/diff/110001/inventory.py#newcode51 inventory.py:51: ('not_changed', "Not Changed"), What about "Keep"? https://codereview.tryton.org/44571002/diff/110001/inventory.py#newcode54 inventory.py:54: help="How ...
7 months, 3 weeks ago (2018-02-25 22:11:24 UTC) #24
pokoli
Fix comments
7 months, 2 weeks ago (2018-02-27 16:39:44 UTC) #25
reviewbot
https://codereview.tryton.org/44571002/diff/130001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/44571002
7 months, 2 weeks ago (2018-02-27 16:45:24 UTC) #26
pokoli
Update to tip
7 months, 2 weeks ago (2018-03-01 12:05:11 UTC) #27
reviewbot
https://codereview.tryton.org/44571002/diff/150001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/44571002
7 months, 2 weeks ago (2018-03-01 12:19:07 UTC) #28
ced
https://codereview.tryton.org/44571002/diff/150001/inventory.py File inventory.py (right): https://codereview.tryton.org/44571002/diff/150001/inventory.py#newcode49 inventory.py:49: empty_line = fields.Selection([ Is it not better named: empty_quantity ...
7 months, 2 weeks ago (2018-03-01 20:56:43 UTC) #29
pokoli
Fix ced's comments
7 months, 1 week ago (2018-03-09 16:34:28 UTC) #30
reviewbot
https://codereview.tryton.org/44571002/diff/170001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/44571002
7 months, 1 week ago (2018-03-09 16:49:06 UTC) #31
ced
https://codereview.tryton.org/44571002/diff/170001/inventory.py File inventory.py (right): https://codereview.tryton.org/44571002/diff/170001/inventory.py#newcode325 inventory.py:325: 'missing_empty_quantity': ('Empty quantity is missing on ' Is it ...
7 months, 1 week ago (2018-03-10 18:17:24 UTC) #32
pokoli
Use ced's suggestion for error message
7 months ago (2018-03-14 16:55:09 UTC) #33
reviewbot
https://codereview.tryton.org/44571002/diff/190001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/44571002
7 months ago (2018-03-14 17:13:58 UTC) #34
ced
LGTM
7 months ago (2018-03-15 09:57:37 UTC) #35
rietveld-bot_tryton.org
7 months ago (2018-03-19 08:57:12 UTC) #36
New changeset 7166c43434f7 by Sergi Almacellas Abellana in branch 'default':
Do not fill inventory quantity automatically
http://hg.tryton.org/modules/stock/rev/7166c43434f7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766