Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(150)

Issue 44571002: stock: Do not fill inventory quantity automatically

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 4 days ago by pokoli
Modified:
17 hours, 17 minutes ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Raise user warning if empty quantity #

Patch Set 3 : Test warning on scenario #

Patch Set 4 : Allow to define how inventory empty lines are managed #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -19 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M __init__.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M configuration.py View 1 2 3 6 chunks +30 lines, -1 line 0 comments Download
M inventory.py View 1 2 3 8 chunks +25 lines, -7 lines 4 comments Download
M tests/scenario_stock_inventory.rst View 1 2 3 3 chunks +2 lines, -10 lines 0 comments Download
M view/configuration_form.xml View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M view/inventory_form.xml View 1 2 3 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 15
pokoli
1 week, 4 days ago (2018-01-12 12:20:54 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/44571002
1 week, 4 days ago (2018-01-12 12:41:17 UTC) #2
ced
1 week, 4 days ago (2018-01-12 12:57:29 UTC) #3
pokoli
Raise user warning if empty quantity
1 week, 4 days ago (2018-01-12 13:22:16 UTC) #4
pokoli
Test warning on scenario
1 week, 4 days ago (2018-01-12 13:25:39 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/44571002
1 week, 4 days ago (2018-01-12 13:34:11 UTC) #6
ced
See https://bugs.tryton.org/msg37596
6 days, 14 hours ago (2018-01-17 20:32:50 UTC) #7
pokoli
On 2018/01/17 20:32:50, ced wrote: > See https://bugs.tryton.org/msg37596 That's managed by the warning
6 days, 2 hours ago (2018-01-18 08:44:52 UTC) #8
ced
On 2018/01/18 08:44:52, pokoli wrote: > On 2018/01/17 20:32:50, ced wrote: > > See https://bugs.tryton.org/msg37596 ...
6 days, 1 hour ago (2018-01-18 09:22:20 UTC) #9
pokoli
On 2018/01/18 09:22:20, ced wrote: > On 2018/01/18 08:44:52, pokoli wrote: > > On 2018/01/17 ...
1 day, 23 hours ago (2018-01-22 11:44:13 UTC) #10
ced
On 2018/01/22 11:44:13, pokoli wrote: > On 2018/01/18 09:22:20, ced wrote: > > On 2018/01/18 ...
1 day, 23 hours ago (2018-01-22 11:52:25 UTC) #11
ced
1 day, 23 hours ago (2018-01-22 11:52:30 UTC) #12
pokoli
Allow to define how inventory empty lines are managed
1 day, 1 hour ago (2018-01-23 09:17:49 UTC) #13
reviewbot
https://codereview.tryton.org/44571002/diff/50001/__init__.py#newcode5 __init__.py:5: F403 'from location import *' used; unable to detect undefined names https://codereview.tryton.org/44571002/diff/50001/__init__.py#newcode6 __init__.py:6: ...
1 day, 1 hour ago (2018-01-23 09:35:14 UTC) #14
ced
17 hours, 17 minutes ago (2018-01-23 17:55:13 UTC) #15
https://codereview.tryton.org/44571002/diff/50001/inventory.py
File inventory.py (right):

https://codereview.tryton.org/44571002/diff/50001/inventory.py#newcode51
inventory.py:51: ('empty', "Empty"),
I think it should be empty by default.

https://codereview.tryton.org/44571002/diff/50001/inventory.py#newcode121
inventory.py:121: return config.inventory_empty_line
Finally, I do not think we should have a default value. It all depends on the
user.

https://codereview.tryton.org/44571002/diff/50001/inventory.py#newcode142
inventory.py:142: if inventory.empty_line == 'empty':
I think it should check if the value is None, it must raise an error.

https://codereview.tryton.org/44571002/diff/50001/inventory.py#newcode143
inventory.py:143: line.quantity = 0
I do not like to change the value temporary like that.
I think the test should be in the get_move call but the exception here.

https://codereview.tryton.org/44571002/diff/50001/view/inventory_form.xml
File view/inventory_form.xml (right):

https://codereview.tryton.org/44571002/diff/50001/view/inventory_form.xml#new...
view/inventory_form.xml:16: <field name="empty_line"/>
I think it makes more sense to have it after the button.

Or maybe adding a notebook with extra information.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922