Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 447091003: trytond: Document priority of attributes over states

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by acaubet
Modified:
3 days, 3 hours ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Do not encourage to overwrite #

Patch Set 3 : Remove trailing spaces #

Total comments: 1

Patch Set 4 : Use reference for attributes #

Total comments: 2

Patch Set 5 : Use attr instead of reference #

Total comments: 1

Patch Set 6 : Use ~ to not render de context #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M doc/ref/fields.rst View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17
acaubet
3 months ago (2022-05-16 11:26:16 UTC) #1
pokoli
https://codereview.tryton.org/447091003/diff/423231004/doc/ref/fields.rst File doc/ref/fields.rst (right): https://codereview.tryton.org/447091003/diff/423231004/doc/ref/fields.rst#newcode72 doc/ref/fields.rst:72: trailing spaces should be removed https://codereview.tryton.org/447091003/diff/423231004/doc/ref/fields.rst#newcode74 doc/ref/fields.rst:74: idem https://codereview.tryton.org/447091003/diff/423231004/doc/ref/fields.rst#newcode75 ...
3 months ago (2022-05-16 11:34:12 UTC) #2
reviewbot
checks OK URL: https://codereview.tryton.org/447091003
3 months ago (2022-05-16 11:53:48 UTC) #3
ced
The improvement should be only on explaining the precedence. https://codereview.tryton.org/447091003/diff/423231004/doc/ref/fields.rst File doc/ref/fields.rst (right): https://codereview.tryton.org/447091003/diff/423231004/doc/ref/fields.rst#newcode69 doc/ref/fields.rst:69: ...
3 months ago (2022-05-16 13:40:06 UTC) #4
acaubet
Do not encourage to overwrite
1 month, 3 weeks ago (2022-06-20 09:04:35 UTC) #5
acaubet
Remove trailing spaces
1 month, 3 weeks ago (2022-06-20 09:05:11 UTC) #6
reviewbot
checks OK URL: https://codereview.tryton.org/447091003
1 month, 3 weeks ago (2022-06-20 09:36:24 UTC) #7
ced
https://codereview.tryton.org/447091003/diff/421371003/doc/ref/fields.rst File doc/ref/fields.rst (right): https://codereview.tryton.org/447091003/diff/421371003/doc/ref/fields.rst#newcode68 doc/ref/fields.rst:68: The ``required`` or ``readonly`` attributes have precedence over Better ...
1 month, 3 weeks ago (2022-06-20 21:29:17 UTC) #8
acaubet
Use reference for attributes
1 month, 3 weeks ago (2022-06-21 09:08:00 UTC) #9
reviewbot
checks OK URL: https://codereview.tryton.org/447091003
1 month, 3 weeks ago (2022-06-21 09:37:06 UTC) #10
ced
https://codereview.tryton.org/447091003/diff/421401003/doc/ref/fields.rst File doc/ref/fields.rst (right): https://codereview.tryton.org/447091003/diff/421401003/doc/ref/fields.rst#newcode72 doc/ref/fields.rst:72: The `required <_field_readonly>` or `readonly <_field_readonly>` Why not use ...
1 month, 3 weeks ago (2022-06-21 21:38:00 UTC) #11
acaubet
Use attr instead of reference
1 month, 3 weeks ago (2022-06-22 08:30:26 UTC) #12
acaubet
https://codereview.tryton.org/447091003/diff/421401003/doc/ref/fields.rst File doc/ref/fields.rst (right): https://codereview.tryton.org/447091003/diff/421401003/doc/ref/fields.rst#newcode72 doc/ref/fields.rst:72: The `required <_field_readonly>` or `readonly <_field_readonly>` On 2022/06/21 21:38:00, ...
1 month, 3 weeks ago (2022-06-22 08:33:11 UTC) #13
reviewbot
checks OK URL: https://codereview.tryton.org/447091003
1 month, 3 weeks ago (2022-06-22 08:38:02 UTC) #14
ced
https://codereview.tryton.org/447091003/diff/421411003/doc/ref/fields.rst File doc/ref/fields.rst (right): https://codereview.tryton.org/447091003/diff/421411003/doc/ref/fields.rst#newcode68 doc/ref/fields.rst:68: The :attr:`Field.required` or :attr:`Field.readonly` attributes have You can use ...
1 month, 3 weeks ago (2022-06-23 08:47:45 UTC) #15
acaubet
Use ~ to not render de context
3 days, 3 hours ago (2022-08-11 11:39:04 UTC) #16
reviewbot
3 days, 3 hours ago (2022-08-11 11:46:32 UTC) #17
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted