trytond: Document priority of attributes over states

issue11488

[pokoli, 2022-05-16 11:34:12]

https://codereview.tryton.org/447091003/diff/423231004/doc/ref/fields.rst
File doc/ref/fields.rst (right):

https://codereview.tryton.org/447091003/diff/423231004/doc/ref/fields.rst#new...
doc/ref/fields.rst:72: 
trailing spaces should be removed

https://codereview.tryton.org/447091003/diff/423231004/doc/ref/fields.rst#new...
doc/ref/fields.rst:74: 
idem

https://codereview.tryton.org/447091003/diff/423231004/doc/ref/fields.rst#new...
doc/ref/fields.rst:75: ``cls.<field name>.readonly = <PYSON expresion>``
It is not possible to use PYSON into readonly attributes. It should be true or
false.

So you should set it into false first and then sett the states with the pyson
expression.

[reviewbot, 2022-05-16 11:53:48]

checks OK
URL: https://codereview.tryton.org/447091003

[ced, 2022-05-16 13:40:06]

The improvement should be only on explaining the precedence.

https://codereview.tryton.org/447091003/diff/423231004/doc/ref/fields.rst
File doc/ref/fields.rst (right):

https://codereview.tryton.org/447091003/diff/423231004/doc/ref/fields.rst#new...
doc/ref/fields.rst:69: have precedence over states. So instead of doing:
I do not want to encourage people to do that. It is a bad practice.

[acaubet, 2022-06-20 09:04:35]

Do not encourage to overwrite

[acaubet, 2022-06-20 09:05:11]

Remove trailing spaces

[reviewbot, 2022-06-20 09:36:24]

checks OK
URL: https://codereview.tryton.org/447091003

[ced, 2022-06-20 21:29:17]

https://codereview.tryton.org/447091003/diff/421371003/doc/ref/fields.rst
File doc/ref/fields.rst (right):

https://codereview.tryton.org/447091003/diff/421371003/doc/ref/fields.rst#new...
doc/ref/fields.rst:68: The ``required`` or ``readonly`` attributes have
precedence over
Better to use reference to required and readonly attributes.

[acaubet, 2022-06-21 09:08:00]

Use reference for attributes

[reviewbot, 2022-06-21 09:37:06]

checks OK
URL: https://codereview.tryton.org/447091003

[ced, 2022-06-21 21:38:00]

https://codereview.tryton.org/447091003/diff/421401003/doc/ref/fields.rst
File doc/ref/fields.rst (right):

https://codereview.tryton.org/447091003/diff/421401003/doc/ref/fields.rst#new...
doc/ref/fields.rst:72: The `required <_field_readonly>` or `readonly
<_field_readonly>`
Why not use attr?

[acaubet, 2022-06-22 08:30:26]

Use attr instead of reference

[acaubet, 2022-06-22 08:33:11]

https://codereview.tryton.org/447091003/diff/421401003/doc/ref/fields.rst
File doc/ref/fields.rst (right):

https://codereview.tryton.org/447091003/diff/421401003/doc/ref/fields.rst#new...
doc/ref/fields.rst:72: The `required <_field_readonly>` or `readonly
<_field_readonly>`
On 2022/06/21 21:38:00, ced wrote:
> Why not use attr?

Because I'm not familiar with sphinx or how it's build the Tryton docs, on
previous comment you mention the reference and that's what I look for.
Now I undestand the attr, still not fully as I don't see the diference between
:attr:`Field.required` and :attr:`~Field.required`.

[reviewbot, 2022-06-22 08:38:02]

checks OK
URL: https://codereview.tryton.org/447091003

[ced, 2022-06-23 08:47:45]

https://codereview.tryton.org/447091003/diff/421411003/doc/ref/fields.rst
File doc/ref/fields.rst (right):

https://codereview.tryton.org/447091003/diff/421411003/doc/ref/fields.rst#new...
doc/ref/fields.rst:68: The :attr:`Field.required` or :attr:`Field.readonly`
attributes have
You can use ~ so only the last part is rendered as we do not need the context as
we are in the same one.

[acaubet, 2022-08-11 11:39:04]

Use ~ to not render de context

[reviewbot, 2022-08-11 11:46:32]

checks OK
URL: https://codereview.tryton.org/447091003

[ced, 2022-08-19 21:05:49]

https://codereview.tryton.org/447091003/diff/425531005/doc/ref/fields.rst
File doc/ref/fields.rst (right):

https://codereview.tryton.org/447091003/diff/425531005/doc/ref/fields.rst#new...
doc/ref/fields.rst:68: The :attr:`~Field.required` or :attr:`~Field.readonly`
attributes have
I would say 'and' instead of 'or'.

https://codereview.tryton.org/447091003/diff/425531005/doc/ref/fields.rst#new...
doc/ref/fields.rst:68: The :attr:`~Field.required` or :attr:`~Field.readonly`
attributes have
I would also say that it is only if they are `True`.