Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)

Issue 44841002: account_es: Simplify account and tax definition (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 2 weeks ago by pokoli
Modified:
5 months, 1 week ago
Reviewers:
reviewbot, rietveld-bot, ced, albert
Visibility:
Public.

Description

- Remove unneeded account and account types - Follow aeat reports for tax code definitions - Include only most common taxes used issue7150

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix typos, improve names, add missing fixes and include intra/extracomunitary tax rule #

Patch Set 3 : Fix albert's comments #

Patch Set 4 : Fix duplicated tax codes #

Patch Set 5 : Use one account for each tax type #

Patch Set 6 : Remove view accounts with only one children and check all chart of accounts #

Total comments: 11

Patch Set 7 : Remove duplicated codes, tax sequence and start date and improve doc #

Patch Set 8 : Remove not needed account type and fix some names #

Patch Set 9 : Use same code for account's id #

Patch Set 10 : Fix wrong id and set proper kind for 130 account #

Patch Set 11 : Improve account type id and sequences and update changelog #

Total comments: 1

Patch Set 12 : Fix changelog and pyg display balance sign #

Total comments: 2

Patch Set 13 : Use correct publish date #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4534 lines, -14056 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -1 line 0 comments Download
M doc/index.rst View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -2 lines 0 comments Download
M tax.xml View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +1509 lines, -4703 lines 0 comments Download
M tax_normal.xml View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +1508 lines, -4675 lines 0 comments Download
M tax_pyme.xml View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +1508 lines, -4675 lines 0 comments Download

Messages

Total messages: 38
pokoli
6 months, 2 weeks ago (2018-03-29 15:48:49 UTC) #1
reviewbot
patch is not applicable URL: https://codereview.tryton.org/44841002
6 months, 2 weeks ago (2018-03-29 15:49:05 UTC) #2
albert
https://codereview.tryton.org/44841002/diff/1/account.xml File account.xml (right): https://codereview.tryton.org/44841002/diff/1/account.xml#newcode16158 account.xml:16158: <field name="code">4751015</field> Do you keep this and other 4571.x ...
6 months, 2 weeks ago (2018-03-31 22:53:31 UTC) #3
pokoli
https://codereview.tryton.org/44841002/diff/1/account.xml File account.xml (right): https://codereview.tryton.org/44841002/diff/1/account.xml#newcode16158 account.xml:16158: <field name="code">4751015</field> On 2018/03/31 22:53:31, albert wrote: > Do ...
6 months, 2 weeks ago (2018-04-02 09:51:49 UTC) #4
pokoli
Fix typos, improve names, add missing fixes and include intra/extracomunitary tax rule
6 months, 2 weeks ago (2018-04-03 12:32:30 UTC) #5
pokoli
Fix albert's comments
6 months, 2 weeks ago (2018-04-03 12:35:04 UTC) #6
reviewbot
patch is not applicable URL: https://codereview.tryton.org/44841002
6 months, 2 weeks ago (2018-04-03 12:59:24 UTC) #7
pokoli
Fix duplicated tax codes
6 months, 1 week ago (2018-04-06 10:17:36 UTC) #8
reviewbot
patch is not applicable URL: https://codereview.tryton.org/44841002
6 months, 1 week ago (2018-04-06 10:24:19 UTC) #9
pokoli
Use one account for each tax type
6 months, 1 week ago (2018-04-09 08:45:49 UTC) #10
reviewbot
patch is not applicable URL: https://codereview.tryton.org/44841002
6 months, 1 week ago (2018-04-09 08:56:19 UTC) #11
pokoli
Remove view accounts with only one children and check all chart of accounts
6 months ago (2018-04-13 10:15:38 UTC) #12
reviewbot
patch is not applicable URL: https://codereview.tryton.org/44841002
6 months ago (2018-04-13 10:29:09 UTC) #13
ced
https://codereview.tryton.org/44841002/diff/50001/account.xml File account.xml (right): https://codereview.tryton.org/44841002/diff/50001/account.xml#newcode3052 account.xml:3052: <record model="account.account.template" id="pgc_1000"> The id should match the code? ...
6 months ago (2018-04-17 10:12:12 UTC) #14
pokoli
Remove duplicated codes, tax sequence and start date and improve doc
6 months ago (2018-04-17 13:59:13 UTC) #15
pokoli
https://codereview.tryton.org/44841002/diff/50001/account.xml File account.xml (right): https://codereview.tryton.org/44841002/diff/50001/account.xml#newcode3052 account.xml:3052: <record model="account.account.template" id="pgc_1000"> On 2018/04/17 10:12:11, ced wrote: > ...
6 months ago (2018-04-17 14:01:24 UTC) #16
ced
https://codereview.tryton.org/44841002/diff/50001/account.xml File account.xml (right): https://codereview.tryton.org/44841002/diff/50001/account.xml#newcode3052 account.xml:3052: <record model="account.account.template" id="pgc_1000"> On 2018/04/17 14:01:24, pokoli wrote: > ...
6 months ago (2018-04-17 14:27:09 UTC) #17
reviewbot
patch is not applicable URL: https://codereview.tryton.org/44841002
6 months ago (2018-04-17 14:36:20 UTC) #18
pokoli
Remove not needed account type and fix some names
6 months ago (2018-04-17 15:01:26 UTC) #19
reviewbot
patch is not applicable URL: https://codereview.tryton.org/44841002
6 months ago (2018-04-17 15:31:31 UTC) #20
ced
Missing account.xml
6 months ago (2018-04-17 15:32:53 UTC) #21
pokoli
Use same code for account's id
6 months ago (2018-04-17 15:56:39 UTC) #22
pokoli
https://codereview.tryton.org/44841002/diff/50001/account.xml File account.xml (right): https://codereview.tryton.org/44841002/diff/50001/account.xml#newcode3052 account.xml:3052: <record model="account.account.template" id="pgc_1000"> On 2018/04/17 14:27:08, ced wrote: > ...
6 months ago (2018-04-17 15:57:04 UTC) #23
pokoli
On 2018/04/17 15:32:53, ced wrote: > Missing account.xml When updating latest patchset I get the ...
6 months ago (2018-04-17 15:58:07 UTC) #24
reviewbot
patch is not applicable URL: https://codereview.tryton.org/44841002
6 months ago (2018-04-17 16:32:25 UTC) #25
pokoli
Fix wrong id and set proper kind for 130 account
6 months ago (2018-04-18 14:42:17 UTC) #26
reviewbot
patch is not applicable URL: https://codereview.tryton.org/44841002
6 months ago (2018-04-18 14:53:25 UTC) #27
ced
I find the id and sequence of account.account.type.template very strange. The sequence seem to be ...
5 months, 2 weeks ago (2018-04-28 09:50:27 UTC) #28
pokoli
Improve account type id and sequences and update changelog
5 months, 2 weeks ago (2018-04-30 14:16:13 UTC) #29
reviewbot
patch is not applicable URL: https://codereview.tryton.org/44841002
5 months, 2 weeks ago (2018-04-30 14:26:13 UTC) #30
ced
https://codereview.tryton.org/44841002/diff/100001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/44841002/diff/100001/CHANGELOG#newcode1 CHANGELOG:1: * Remove not necesary account and account types not ...
5 months, 1 week ago (2018-05-07 13:43:36 UTC) #31
pokoli
Fix changelog and pyg display balance sign
5 months, 1 week ago (2018-05-07 15:42:59 UTC) #32
ced
https://codereview.tryton.org/44841002/diff/110001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/44841002/diff/110001/doc/index.rst#newcode10 doc/index.rst:10: https://www.boe.es/boe/dias/2007/11/20/pdfs/C00001-00152.pdf`_ on 16th November Are you sure about the ...
5 months, 1 week ago (2018-05-07 15:52:18 UTC) #33
pokoli
Use correct publish date
5 months, 1 week ago (2018-05-07 15:59:30 UTC) #34
pokoli
https://codereview.tryton.org/44841002/diff/110001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/44841002/diff/110001/doc/index.rst#newcode10 doc/index.rst:10: https://www.boe.es/boe/dias/2007/11/20/pdfs/C00001-00152.pdf`_ on 16th November On 2018/05/07 15:52:17, ced wrote: ...
5 months, 1 week ago (2018-05-07 16:00:05 UTC) #35
ced
LGTM
5 months, 1 week ago (2018-05-07 16:03:47 UTC) #36
reviewbot
patch is not applicable URL: https://codereview.tryton.org/44841002
5 months, 1 week ago (2018-05-07 16:09:12 UTC) #37
rietveld-bot_tryton.org
5 months, 1 week ago (2018-05-08 15:30:53 UTC) #38
New changeset 96b64381fedf by Sergi Almacellas Abellana in branch 'default':
Simplify account and tax definition
http://hg.tryton.org/modules/account_es/rev/96b64381fedf
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766