Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(426)

Issue 44921002: sao: Increase the space available on main navbar for tablist (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 2 weeks ago by ced
Modified:
4 days, 9 hours ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

- use icon instead of text for logout - move favorites in the global search - merge brand and toggle menu - allow to toggle menu on lg - reduce expander size issue7325 issue5554

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make offcanvas works on lg #

Patch Set 3 : Simplify offcanvas, add lg for menu and reduce expander size #

Patch Set 4 : Update to tip and add CHANGELOG #

Patch Set 5 : Pull user preferences on the right #

Patch Set 6 : Fix horizontal scrolling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -104 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M index.html View 1 2 3 4 5 4 chunks +16 lines, -20 lines 0 comments Download
R offcanvas.css View 1 1 chunk +0 lines, -68 lines 0 comments Download
M package.json View 1 1 chunk +0 lines, -1 line 0 comments Download
A src/offcanvas.less View 1 2 3 4 5 1 chunk +76 lines, -0 lines 0 comments Download
M src/sao.js View 1 2 3 4 3 chunks +37 lines, -12 lines 0 comments Download
M src/sao.less View 1 2 3 4 3 chunks +13 lines, -1 line 0 comments Download
M src/session.js View 1 chunk +4 lines, -1 line 0 comments Download
M src/view/tree.js View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15
ced
1 month, 2 weeks ago (2018-04-06 13:36:04 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/44921002
1 month, 2 weeks ago (2018-04-06 14:03:30 UTC) #2
pokoli
https://codereview.tryton.org/44921002/diff/1/index.html File index.html (right): https://codereview.tryton.org/44921002/diff/1/index.html#newcode51 index.html:51: <a class="navbar-brand" href="#" data-toggle="offcanvas"> is the href really required? ...
3 weeks, 4 days ago (2018-04-25 09:23:16 UTC) #3
ced
https://codereview.tryton.org/44921002/diff/1/index.html File index.html (right): https://codereview.tryton.org/44921002/diff/1/index.html#newcode51 index.html:51: <a class="navbar-brand" href="#" data-toggle="offcanvas"> On 2018/04/25 09:23:16, pokoli wrote: ...
3 weeks, 4 days ago (2018-04-25 09:40:37 UTC) #4
ced
Make offcanvas works on lg
3 weeks, 4 days ago (2018-04-25 11:06:56 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/44921002
3 weeks, 4 days ago (2018-04-25 11:26:22 UTC) #6
ced
Simplify offcanvas, add lg for menu and reduce expander size
3 weeks, 4 days ago (2018-04-25 11:59:02 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/44921002
3 weeks, 4 days ago (2018-04-25 12:03:05 UTC) #8
ced
Update to tip and add CHANGELOG
2 weeks, 6 days ago (2018-04-30 14:06:45 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/44921002
2 weeks, 6 days ago (2018-04-30 14:25:52 UTC) #10
ced
Pull user preferences on the right
1 week, 5 days ago (2018-05-08 12:00:05 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/44921002
1 week, 5 days ago (2018-05-08 12:13:37 UTC) #12
ced
Fix horizontal scrolling
1 week, 5 days ago (2018-05-08 14:50:49 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/44921002
1 week, 5 days ago (2018-05-08 15:15:23 UTC) #14
rietveld-bot_tryton.org
1 week, 2 days ago (2018-05-11 23:04:54 UTC) #15
New changeset 1ebb23690892 by Cédric Krier in branch 'default':
Increase the space available on main navbar for tablist
https://hg.tryton.org/sao/rev/1ebb23690892
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922