Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(413)

Issue 44991002: trytond: Add hostname configuration to list database

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by ced
Modified:
3 days, 15 hours ago
Reviewers:
pokoli, jeremy, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update to tip #

Patch Set 3 : Remove unused import #

Patch Set 4 : Update to tip #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -42 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M trytond/admin.py View 2 chunks +5 lines, -0 lines 3 comments Download
M trytond/backend/database.py View 2 chunks +2 lines, -2 lines 0 comments Download
M trytond/backend/postgresql/database.py View 5 chunks +33 lines, -21 lines 0 comments Download
M trytond/backend/postgresql/init.sql View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/backend/sqlite/database.py View 1 2 3 chunks +20 lines, -16 lines 0 comments Download
M trytond/backend/sqlite/init.sql View 1 chunk +2 lines, -1 line 0 comments Download
M trytond/commandline.py View 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/ir/configuration.py View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/protocols/dispatcher.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13
ced
1 month ago (2018-04-19 10:37:02 UTC) #1
reviewbot
https://codereview.tryton.org/44991002/diff/1/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
1 month ago (2018-04-19 10:56:55 UTC) #2
ced
Update to tip
2 weeks, 6 days ago (2018-04-30 13:58:13 UTC) #3
reviewbot
https://codereview.tryton.org/44991002/diff/20001/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
2 weeks, 6 days ago (2018-04-30 13:59:06 UTC) #4
ced
Remove unused import
2 weeks, 6 days ago (2018-04-30 14:11:54 UTC) #5
reviewbot
https://codereview.tryton.org/44991002/diff/40001/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
2 weeks, 6 days ago (2018-04-30 14:26:10 UTC) #6
ced
Update to tip
1 week, 5 days ago (2018-05-08 12:01:24 UTC) #7
reviewbot
https://codereview.tryton.org/44991002/diff/60001/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
1 week, 5 days ago (2018-05-08 12:13:56 UTC) #8
pokoli
https://codereview.tryton.org/44991002/diff/60001/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/44991002/diff/60001/trytond/admin.py#newcode117 trytond/admin.py:117: configuration.hostname = options.hostname or None why is or None ...
1 week, 3 days ago (2018-05-10 15:05:45 UTC) #9
ced
https://codereview.tryton.org/44991002/diff/60001/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/44991002/diff/60001/trytond/admin.py#newcode117 trytond/admin.py:117: configuration.hostname = options.hostname or None On 2018/05/10 15:05:45, pokoli ...
1 week, 3 days ago (2018-05-10 15:39:23 UTC) #10
jeremy
lgtm
1 week, 2 days ago (2018-05-11 13:40:25 UTC) #11
pokoli
https://codereview.tryton.org/44991002/diff/60001/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/44991002/diff/60001/trytond/admin.py#newcode117 trytond/admin.py:117: configuration.hostname = options.hostname or None On 2018/05/10 15:39:22, ced ...
3 days, 15 hours ago (2018-05-17 15:03:21 UTC) #12
pokoli
3 days, 15 hours ago (2018-05-17 15:06:55 UTC) #13
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922