Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(421)

Issue 45001002: trytond: Use grouped_slice on load_module_graph

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by xcodinas
Modified:
1 week, 4 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Do not convert to dict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M trytond/modules/__init__.py View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7
xcodinas
1 month ago (2018-04-20 10:41:57 UTC) #1
reviewbot
https://codereview.tryton.org/45001002/diff/1/trytond/modules/__init__.py#newcode297 trytond/modules/__init__.py:297: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/45001002
1 month ago (2018-04-20 11:00:07 UTC) #2
ced
https://codereview.tryton.org/45001002/diff/1/trytond/modules/__init__.py File trytond/modules/__init__.py (right): https://codereview.tryton.org/45001002/diff/1/trytond/modules/__init__.py#newcode224 trytond/modules/__init__.py:224: module2state.update(dict(cursor.fetchall())) You do not need to convert to dict ...
1 week, 4 days ago (2018-05-09 07:39:39 UTC) #3
xcodinas
Do not convert to dict
1 week, 4 days ago (2018-05-09 07:53:10 UTC) #4
reviewbot
https://codereview.tryton.org/45001002/diff/20001/trytond/modules/__init__.py#newcode297 trytond/modules/__init__.py:297: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/45001002
1 week, 4 days ago (2018-05-09 08:13:28 UTC) #5
ced
LGTM
1 week, 4 days ago (2018-05-09 09:13:42 UTC) #6
ced
1 week, 4 days ago (2018-05-09 13:32:19 UTC) #7
On 2018/05/09 09:13:42, ced wrote:
> LGTM

It does not work.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922