Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(230)

Issue 45001002: trytond: Use grouped_slice on load_module_graph

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by xcodinas
Modified:
4 months ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Do not convert to dict #

Patch Set 3 : Make sub_modules a list as islice is not accepted by sql api #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M trytond/modules/__init__.py View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9
xcodinas
5 months ago (2018-04-20 10:41:57 UTC) #1
reviewbot
https://codereview.tryton.org/45001002/diff/1/trytond/modules/__init__.py#newcode297 trytond/modules/__init__.py:297: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/45001002
5 months ago (2018-04-20 11:00:07 UTC) #2
ced
https://codereview.tryton.org/45001002/diff/1/trytond/modules/__init__.py File trytond/modules/__init__.py (right): https://codereview.tryton.org/45001002/diff/1/trytond/modules/__init__.py#newcode224 trytond/modules/__init__.py:224: module2state.update(dict(cursor.fetchall())) You do not need to convert to dict ...
4 months, 1 week ago (2018-05-09 07:39:39 UTC) #3
xcodinas
Do not convert to dict
4 months, 1 week ago (2018-05-09 07:53:10 UTC) #4
reviewbot
https://codereview.tryton.org/45001002/diff/20001/trytond/modules/__init__.py#newcode297 trytond/modules/__init__.py:297: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/45001002
4 months, 1 week ago (2018-05-09 08:13:28 UTC) #5
ced
LGTM
4 months, 1 week ago (2018-05-09 09:13:42 UTC) #6
ced
On 2018/05/09 09:13:42, ced wrote: > LGTM It does not work.
4 months, 1 week ago (2018-05-09 13:32:19 UTC) #7
xcodinas
Make sub_modules a list as islice is not accepted by sql api
4 months ago (2018-05-21 09:14:35 UTC) #8
reviewbot
4 months ago (2018-05-21 09:22:08 UTC) #9
https://codereview.tryton.org/45001002/diff/40001/trytond/modules/__init__.py...
trytond/modules/__init__.py:297:
E127 continuation line over-indented for visual indent

URL: https://codereview.tryton.org/45001002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766