trytond: Remove CompanyReport

issue6760

[reviewbot, 2018-05-18 12:47:48]

patch is not applicable
URL: https://codereview.tryton.org/45141002

[ced, 2018-05-23 09:05:17]

I'm not sure it makes sense to rename all records by custom name.

[ced, 2018-05-23 09:08:16]

I think it will be better to break it into multiple patches instead of one
nested. So we will have linter and proper commit message.

https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_stateme...
File trytond/modules/account_statement/statement.xml (right):

https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_stateme...
trytond/modules/account_statement/statement.xml:96: <field name="single"
eval="True"/>
Is it really needed? It is an internal document.

https://codereview.tryton.org/45141002/diff/1/trytond/modules/stock/shipment.xml
File trytond/modules/stock/shipment.xml (right):

https://codereview.tryton.org/45141002/diff/1/trytond/modules/stock/shipment....
trytond/modules/stock/shipment.xml:371: <field name="single" eval="True"/>
Is it really needed? It is an internal document.

https://codereview.tryton.org/45141002/diff/1/trytond/modules/stock/shipment....
trytond/modules/stock/shipment.xml:385: <field name="single" eval="True"/>
idem

https://codereview.tryton.org/45141002/diff/1/trytond/modules/stock/shipment....
trytond/modules/stock/shipment.xml:399: <field name="single" eval="True"/>
Is it really needed?

https://codereview.tryton.org/45141002/diff/1/trytond/modules/stock/shipment....
trytond/modules/stock/shipment.xml:413: <field name="single" eval="True"/>
Is it really needed?

[pokoli, 2018-05-23 14:35:53]

https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_stateme...
File trytond/modules/account_statement/statement.xml (right):

https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_stateme...
trytond/modules/account_statement/statement.xml:96: <field name="single"
eval="True"/>
On 2018/05/23 09:08:16, ced wrote:
> Is it really needed? It is an internal document.

What do you mean? That is better to only remove the company fields from report
and then show the same information but without company related data?

What if it is a multicompany database? It may not be possible to distinguish
from which company is each printed report, as the number may be exactly the
same.

[ced, 2018-05-23 14:55:53]

https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_stateme...
File trytond/modules/account_statement/statement.xml (right):

https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_stateme...
trytond/modules/account_statement/statement.xml:96: <field name="single"
eval="True"/>
On 2018/05/23 14:35:52, pokoli wrote:
> On 2018/05/23 09:08:16, ced wrote:
> > Is it really needed? It is an internal document.
> 
> What do you mean? That is better to only remove the company fields from report
> and then show the same information but without company related data?

No, I mean that the company header could be replaced by just putting company
information in the content. So this will prevent to use the single report which
prevent to work on a lot of records.

[pokoli, 2018-05-24 10:59:09]

https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_stateme...
File trytond/modules/account_statement/statement.xml (right):

https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_stateme...
trytond/modules/account_statement/statement.xml:96: <field name="single"
eval="True"/>
On 2018/05/23 14:55:53, ced wrote:
> On 2018/05/23 14:35:52, pokoli wrote:
> > On 2018/05/23 09:08:16, ced wrote:
> > > Is it really needed? It is an internal document.
> > 
> > What do you mean? That is better to only remove the company fields from
report
> > and then show the same information but without company related data?
> 
> No, I mean that the company header could be replaced by just putting company
> information in the content. So this will prevent to use the single report
which
> prevent to work on a lot of records.

Ok, that makes sense. I've fixed it but I created a review for each module as
suggested.