Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Issue 45141002: trytond: Remove CompanyReport (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by pokoli
Modified:
4 years, 8 months ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+983 lines, -839 lines) Patch
M trytond/modules/account_payment_sepa/mandate.fodt View 28 chunks +149 lines, -145 lines 0 comments Download
M trytond/modules/account_payment_sepa/payment.py View 2 chunks +8 lines, -2 lines 0 comments Download
M trytond/modules/account_payment_sepa/payment.xml View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/modules/account_payment_sepa/setup.py View 1 chunk +3 lines, -0 lines 0 comments Download
A trytond/modules/account_payment_sepa/tests/scenario_sepa_mandate.rst View 1 chunk +74 lines, -0 lines 0 comments Download
M trytond/modules/account_payment_sepa/tests/test_account_payment_sepa.py View 3 chunks +7 lines, -0 lines 0 comments Download
M trytond/modules/account_statement/statement.fodt View 13 chunks +63 lines, -62 lines 0 comments Download
M trytond/modules/account_statement/statement.py View 2 chunks +8 lines, -2 lines 0 comments Download
M trytond/modules/account_statement/statement.xml View 1 chunk +1 line, -0 lines 4 comments Download
M trytond/modules/purchase/purchase.fodt View 16 chunks +113 lines, -118 lines 0 comments Download
M trytond/modules/purchase/purchase.py View 2 chunks +8 lines, -2 lines 0 comments Download
M trytond/modules/purchase/purchase.xml View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/modules/purchase_request_quotation/purchase.py View 2 chunks +9 lines, -2 lines 0 comments Download
M trytond/modules/purchase_request_quotation/purchase.xml View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/modules/purchase_request_quotation/quotation.fodt View 16 chunks +73 lines, -73 lines 0 comments Download
M trytond/modules/sale/sale.fodt View 14 chunks +93 lines, -99 lines 0 comments Download
M trytond/modules/sale/sale.py View 2 chunks +8 lines, -2 lines 0 comments Download
M trytond/modules/sale/sale.xml View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/modules/stock/customer_return_restocking_list.fodt View 13 chunks +68 lines, -64 lines 0 comments Download
M trytond/modules/stock/delivery_note.fodt View 12 chunks +78 lines, -73 lines 0 comments Download
M trytond/modules/stock/internal_shipment.fodt View 13 chunks +67 lines, -66 lines 0 comments Download
M trytond/modules/stock/picking_list.fodt View 13 chunks +66 lines, -62 lines 0 comments Download
M trytond/modules/stock/shipment.py View 3 chunks +10 lines, -3 lines 0 comments Download
M trytond/modules/stock/shipment.xml View 5 chunks +5 lines, -0 lines 4 comments Download
M trytond/modules/stock/supplier_restocking_list.fodt View 13 chunks +68 lines, -64 lines 0 comments Download

Messages

Total messages: 7
pokoli
4 years, 8 months ago (2018-05-18 12:45:31 UTC) #1
reviewbot
patch is not applicable URL: https://codereview.tryton.org/45141002
4 years, 8 months ago (2018-05-18 12:47:48 UTC) #2
ced
I'm not sure it makes sense to rename all records by custom name.
4 years, 8 months ago (2018-05-23 09:05:17 UTC) #3
ced
I think it will be better to break it into multiple patches instead of one ...
4 years, 8 months ago (2018-05-23 09:08:16 UTC) #4
pokoli
https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_statement/statement.xml File trytond/modules/account_statement/statement.xml (right): https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_statement/statement.xml#newcode96 trytond/modules/account_statement/statement.xml:96: <field name="single" eval="True"/> On 2018/05/23 09:08:16, ced wrote: > ...
4 years, 8 months ago (2018-05-23 14:35:53 UTC) #5
ced
https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_statement/statement.xml File trytond/modules/account_statement/statement.xml (right): https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_statement/statement.xml#newcode96 trytond/modules/account_statement/statement.xml:96: <field name="single" eval="True"/> On 2018/05/23 14:35:52, pokoli wrote: > ...
4 years, 8 months ago (2018-05-23 14:55:53 UTC) #6
pokoli
4 years, 8 months ago (2018-05-24 10:59:09 UTC) #7
https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_stateme...
File trytond/modules/account_statement/statement.xml (right):

https://codereview.tryton.org/45141002/diff/1/trytond/modules/account_stateme...
trytond/modules/account_statement/statement.xml:96: <field name="single"
eval="True"/>
On 2018/05/23 14:55:53, ced wrote:
> On 2018/05/23 14:35:52, pokoli wrote:
> > On 2018/05/23 09:08:16, ced wrote:
> > > Is it really needed? It is an internal document.
> > 
> > What do you mean? That is better to only remove the company fields from
report
> > and then show the same information but without company related data?
> 
> No, I mean that the company header could be replaced by just putting company
> information in the content. So this will prevent to use the single report
which
> prevent to work on a lot of records.

Ok, that makes sense. I've fixed it but I created a review for each module as
suggested.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted