Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 45241002: account_es: Allow to export tax reports as file (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 3 weeks ago by pokoli
Modified:
2 weeks, 6 days ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Include all keys in reports and add computations on report #

Patch Set 3 : Include more keys on aditional record #

Patch Set 4 : Complete aeat 303 file #

Total comments: 27

Patch Set 5 : Fix comments and do not use sum_keys on reports #

Total comments: 7

Patch Set 6 : Add menu entry, scenario and fix comments #

Patch Set 7 : Validate data on wizard #

Total comments: 28

Patch Set 8 : Fix comments and use a generated file to test in scenario #

Patch Set 9 : Rename file, compute tax percentage and use company cif #

Total comments: 2

Patch Set 10 : Use where operator, define aeat model on tax code and only pick aeat party from invoices #

Patch Set 11 : Remove TaxLine search and update docs #

Patch Set 12 : Apply nested where clause #

Total comments: 7

Patch Set 13 : Include files on setup, improve docs, use super(), improve performance and add acces rights #

Total comments: 8

Patch Set 14 : Move aeat_party_expression to wizard and use join for computing parties #

Patch Set 15 : Fix reviewbot comments #

Total comments: 6

Patch Set 16 : Add account group access, use tables for expression and use group by instead of count distinct #

Total comments: 1

Patch Set 17 : Use count(*) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+847 lines, -1 line) Patch
M CHANGELOG View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M __init__.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +19 lines, -0 lines 0 comments Download
A account.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +39 lines, -0 lines 0 comments Download
A aeat111.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
A aeat115.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
A aeat303.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M doc/index.rst View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +6 lines, -0 lines 0 comments Download
A reporting_tax.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +317 lines, -0 lines 0 comments Download
A reporting_tax.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +84 lines, -0 lines 0 comments Download
M setup.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M tax.xml View 1 2 3 4 5 6 7 8 9 37 chunks +46 lines, -0 lines 0 comments Download
M tax_normal.xml View 1 2 3 4 5 6 7 8 9 37 chunks +46 lines, -0 lines 0 comments Download
M tax_pyme.xml View 1 2 3 4 5 6 7 8 9 37 chunks +46 lines, -0 lines 0 comments Download
A tests/111.txt View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A tests/115.txt View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A tests/303.txt View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A tests/scenario_reporting.rst View 1 2 3 4 5 6 7 8 1 chunk +181 lines, -0 lines 0 comments Download
M tests/test_account_es.py View 1 2 3 4 5 6 7 2 chunks +8 lines, -0 lines 0 comments Download
M tryton.cfg View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
A view.xml View 1 2 3 4 5 6 7 8 9 1 chunk +18 lines, -0 lines 0 comments Download
A view/print_aeat_start_form.xml View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
A view/tax_code_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download
A view/tax_code_template_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 62
pokoli
3 months, 3 weeks ago (2018-05-31 15:55:02 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/45241002
3 months, 3 weeks ago (2018-05-31 16:24:44 UTC) #2
pokoli
Include all keys in reports and add computations on report
3 months, 3 weeks ago (2018-06-01 13:09:42 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/45241002
3 months, 3 weeks ago (2018-06-01 13:28:45 UTC) #4
pokoli
Include more keys on aditional record
3 months, 1 week ago (2018-06-15 12:13:36 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/45241002
3 months, 1 week ago (2018-06-15 12:30:36 UTC) #6
pokoli
Complete aeat 303 file
3 months ago (2018-06-19 11:22:36 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/45241002
3 months ago (2018-06-19 11:28:13 UTC) #8
ced
It will be good to have tests. https://codereview.tryton.org/45241002/diff/60001/reporting.py File reporting.py (right): https://codereview.tryton.org/45241002/diff/60001/reporting.py#newcode43 reporting.py:43: periods = ...
3 months ago (2018-06-19 13:05:16 UTC) #9
pokoli
https://codereview.tryton.org/45241002/diff/60001/tax.xml File tax.xml (right): https://codereview.tryton.org/45241002/diff/60001/tax.xml#newcode855 tax.xml:855: <field name="code">32</field> On 2018/06/19 13:05:16, ced wrote: > Why ...
3 months ago (2018-06-21 16:04:29 UTC) #10
ced
https://codereview.tryton.org/45241002/diff/60001/tax.xml File tax.xml (right): https://codereview.tryton.org/45241002/diff/60001/tax.xml#newcode855 tax.xml:855: <field name="code">32</field> On 2018/06/21 16:04:29, pokoli wrote: > On ...
3 months ago (2018-06-21 16:31:08 UTC) #11
ced
https://codereview.tryton.org/45241002/diff/60001/tax.xml File tax.xml (right): https://codereview.tryton.org/45241002/diff/60001/tax.xml#newcode855 tax.xml:855: <field name="code">32</field> On 2018/06/21 16:31:08, ced wrote: > On ...
3 months ago (2018-06-21 20:37:38 UTC) #12
pokoli
About adding test I understand that you are asking for a test scenario that executes ...
3 months ago (2018-06-22 09:21:02 UTC) #13
pokoli
Fix comments and do not use sum_keys on reports
3 months ago (2018-06-22 09:21:23 UTC) #14
reviewbot
flake8 OK URL: https://codereview.tryton.org/45241002
3 months ago (2018-06-22 09:34:40 UTC) #15
ced
On 2018/06/22 09:21:02, pokoli wrote: > About adding test I understand that you are asking ...
3 months ago (2018-06-22 10:16:41 UTC) #16
ced
https://codereview.tryton.org/45241002/diff/60001/reporting.py File reporting.py (right): https://codereview.tryton.org/45241002/diff/60001/reporting.py#newcode43 reporting.py:43: periods = Period.browse(Transaction().context['periods']) On 2018/06/22 09:21:01, pokoli wrote: > ...
3 months ago (2018-06-22 10:26:03 UTC) #17
pokoli
Add menu entry, scenario and fix comments
2 months, 3 weeks ago (2018-07-02 15:57:37 UTC) #18
pokoli
https://codereview.tryton.org/45241002/diff/80001/reporting.py File reporting.py (right): https://codereview.tryton.org/45241002/diff/80001/reporting.py#newcode53 reporting.py:53: if end_month - start_month > 0: On 2018/06/22 10:26:03, ...
2 months, 3 weeks ago (2018-07-02 15:57:40 UTC) #19
ced
https://codereview.tryton.org/45241002/diff/80001/reporting.py File reporting.py (right): https://codereview.tryton.org/45241002/diff/80001/reporting.py#newcode198 reporting.py:198: assert len(set(p.fiscalyear for p in periods)) == 1, ( ...
2 months, 3 weeks ago (2018-07-02 16:19:24 UTC) #20
reviewbot
flake8 OK URL: https://codereview.tryton.org/45241002
2 months, 3 weeks ago (2018-07-02 16:29:02 UTC) #21
pokoli
Validate data on wizard
2 months, 2 weeks ago (2018-07-03 09:07:01 UTC) #22
reviewbot
flake8 OK URL: https://codereview.tryton.org/45241002
2 months, 2 weeks ago (2018-07-03 09:13:09 UTC) #23
ced
https://codereview.tryton.org/45241002/diff/120001/__init__.py File __init__.py (right): https://codereview.tryton.org/45241002/diff/120001/__init__.py#newcode4 __init__.py:4: from . import reporting For consistency, it should be ...
2 months, 1 week ago (2018-07-11 13:13:19 UTC) #24
pokoli
Fix comments and use a generated file to test in scenario
1 month, 3 weeks ago (2018-08-01 10:33:44 UTC) #25
pokoli
https://codereview.tryton.org/45241002/diff/120001/__init__.py File __init__.py (right): https://codereview.tryton.org/45241002/diff/120001/__init__.py#newcode4 __init__.py:4: from . import reporting On 2018/07/11 13:13:19, ced wrote: ...
1 month, 3 weeks ago (2018-08-01 10:34:19 UTC) #26
reviewbot
flake8 OK URL: https://codereview.tryton.org/45241002
1 month, 3 weeks ago (2018-08-01 10:37:00 UTC) #27
ced
https://codereview.tryton.org/45241002/diff/120001/__init__.py File __init__.py (right): https://codereview.tryton.org/45241002/diff/120001/__init__.py#newcode4 __init__.py:4: from . import reporting On 2018/08/01 10:34:19, pokoli wrote: ...
1 month, 3 weeks ago (2018-08-01 10:54:54 UTC) #28
pokoli
Rename file, compute tax percentage and use company cif
1 month, 2 weeks ago (2018-08-08 11:46:31 UTC) #29
pokoli
https://codereview.tryton.org/45241002/diff/120001/reporting.py File reporting.py (right): https://codereview.tryton.org/45241002/diff/120001/reporting.py#newcode181 reporting.py:181: amounts['65'] = 100.0 On 2018/08/01 10:54:54, ced wrote: > ...
1 month, 2 weeks ago (2018-08-08 11:47:38 UTC) #30
reviewbot
flake8 OK URL: https://codereview.tryton.org/45241002
1 month, 2 weeks ago (2018-08-08 12:10:40 UTC) #31
ced
https://codereview.tryton.org/45241002/diff/120001/reporting.py File reporting.py (right): https://codereview.tryton.org/45241002/diff/120001/reporting.py#newcode181 reporting.py:181: amounts['65'] = 100.0 On 2018/08/08 11:47:38, pokoli wrote: > ...
1 month, 2 weeks ago (2018-08-08 12:39:47 UTC) #32
pokoli
https://codereview.tryton.org/45241002/diff/120001/reporting.py File reporting.py (right): https://codereview.tryton.org/45241002/diff/120001/reporting.py#newcode181 reporting.py:181: amounts['65'] = 100.0 On 2018/08/08 12:39:47, ced wrote: > ...
1 month, 2 weeks ago (2018-08-08 15:52:19 UTC) #33
ced
https://codereview.tryton.org/45241002/diff/120001/reporting.py File reporting.py (right): https://codereview.tryton.org/45241002/diff/120001/reporting.py#newcode181 reporting.py:181: amounts['65'] = 100.0 On 2018/08/08 15:52:18, pokoli wrote: > ...
1 month, 2 weeks ago (2018-08-08 16:56:11 UTC) #34
pokoli
Use where operator, define aeat model on tax code and only pick aeat party from ...
1 month, 1 week ago (2018-08-10 10:10:00 UTC) #35
pokoli
Remove TaxLine search and update docs
1 month, 1 week ago (2018-08-10 10:12:14 UTC) #36
pokoli
https://codereview.tryton.org/45241002/diff/120001/reporting.py File reporting.py (right): https://codereview.tryton.org/45241002/diff/120001/reporting.py#newcode181 reporting.py:181: amounts['65'] = 100.0 On 2018/08/08 16:56:10, ced wrote: > ...
1 month, 1 week ago (2018-08-10 10:12:53 UTC) #37
reviewbot
https://codereview.tryton.org/45241002/diff/200001/account.py#newcode16 account.py:16: F841 local variable 'Move' is assigned to but never used https://codereview.tryton.org/45241002/diff/200001/account.py#newcode7 account.py:7: F822 ...
1 month, 1 week ago (2018-08-10 10:33:22 UTC) #38
ced
https://codereview.tryton.org/45241002/diff/120001/reporting.py File reporting.py (right): https://codereview.tryton.org/45241002/diff/120001/reporting.py#newcode181 reporting.py:181: amounts['65'] = 100.0 On 2018/08/10 10:12:53, pokoli wrote: > ...
1 month, 1 week ago (2018-08-10 11:32:51 UTC) #39
pokoli
https://codereview.tryton.org/45241002/diff/120001/reporting.py File reporting.py (right): https://codereview.tryton.org/45241002/diff/120001/reporting.py#newcode324 reporting.py:324: if isinstance(self.origin, Move): On 2018/08/10 11:32:51, ced wrote: > ...
1 month, 1 week ago (2018-08-14 11:55:03 UTC) #40
pokoli
Apply nested where clause
1 month, 1 week ago (2018-08-14 12:30:28 UTC) #41
reviewbot
https://codereview.tryton.org/45241002/diff/220001/account.py#newcode16 account.py:16: F841 local variable 'Move' is assigned to but never used https://codereview.tryton.org/45241002/diff/220001/account.py#newcode7 account.py:7: F822 ...
1 month, 1 week ago (2018-08-14 12:43:33 UTC) #42
ced
The txt file must be added in setup.py https://codereview.tryton.org/45241002/diff/220001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/45241002/diff/220001/doc/index.rst#newcode13 doc/index.rst:13: The ...
3 weeks, 3 days ago (2018-08-28 07:33:08 UTC) #43
pokoli
Include files on setup, improve docs, use super(), improve performance and add acces rights
3 weeks, 3 days ago (2018-08-28 12:04:59 UTC) #44
reviewbot
https://codereview.tryton.org/45241002/diff/240001/account.py#newcode11 account.py:11: F822 undefined name 'TaxTemplate' in __all__ https://codereview.tryton.org/45241002/diff/240001/account.py#newcode11 account.py:11: F822 undefined name 'Tax' in ...
3 weeks, 3 days ago (2018-08-28 12:32:45 UTC) #45
ced
https://codereview.tryton.org/45241002/diff/240001/account.py File account.py (right): https://codereview.tryton.org/45241002/diff/240001/account.py#newcode18 account.py:18: def aeat_party_expression(cls): I do not see the point to ...
3 weeks, 3 days ago (2018-08-28 14:32:03 UTC) #46
pokoli
Move aeat_party_expression to wizard and use join for computing parties
3 weeks, 3 days ago (2018-08-28 17:11:51 UTC) #47
pokoli
https://codereview.tryton.org/45241002/diff/240001/account.py File account.py (right): https://codereview.tryton.org/45241002/diff/240001/account.py#newcode18 account.py:18: def aeat_party_expression(cls): On 2018/08/28 14:32:02, ced wrote: > I ...
3 weeks, 3 days ago (2018-08-28 17:12:23 UTC) #48
reviewbot
https://codereview.tryton.org/45241002/diff/260001/account.py#newcode7 account.py:7: F822 undefined name 'Tax' in __all__ https://codereview.tryton.org/45241002/diff/260001/account.py#newcode7 account.py:7: F822 undefined name 'TaxTemplate' in ...
3 weeks, 3 days ago (2018-08-28 17:32:11 UTC) #49
pokoli
Fix reviewbot comments
3 weeks, 3 days ago (2018-08-28 17:52:31 UTC) #50
reviewbot
https://codereview.tryton.org/45241002/diff/280001/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/45241002
3 weeks, 3 days ago (2018-08-28 18:27:23 UTC) #51
ced
https://codereview.tryton.org/45241002/diff/240001/reporting_tax.xml File reporting_tax.xml (right): https://codereview.tryton.org/45241002/diff/240001/reporting_tax.xml#newcode15 reporting_tax.xml:15: <field name="group" ref="account.group_account_admin"/> On 2018/08/28 17:12:22, pokoli wrote: > ...
3 weeks, 3 days ago (2018-08-28 20:32:58 UTC) #52
ced
https://codereview.tryton.org/45241002/diff/280001/reporting_tax.py File reporting_tax.py (right): https://codereview.tryton.org/45241002/diff/280001/reporting_tax.py#newcode130 reporting_tax.py:130: move, _ = tables[None] I think it will make ...
3 weeks, 3 days ago (2018-08-29 06:51:22 UTC) #53
pokoli
Add account group access, use tables for expression and use group by instead of count ...
3 weeks, 2 days ago (2018-08-29 11:35:12 UTC) #54
pokoli
https://codereview.tryton.org/45241002/diff/240001/reporting_tax.xml File reporting_tax.xml (right): https://codereview.tryton.org/45241002/diff/240001/reporting_tax.xml#newcode15 reporting_tax.xml:15: <field name="group" ref="account.group_account_admin"/> On 2018/08/28 20:32:58, ced wrote: > ...
3 weeks, 2 days ago (2018-08-29 11:35:31 UTC) #55
reviewbot
https://codereview.tryton.org/45241002/diff/300001/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/45241002
3 weeks, 2 days ago (2018-08-29 11:58:53 UTC) #56
ced
https://codereview.tryton.org/45241002/diff/300001/reporting_tax.py File reporting_tax.py (right): https://codereview.tryton.org/45241002/diff/300001/reporting_tax.py#newcode162 reporting_tax.py:162: Count(Literal(1)))) Indeed now, it is faster to count(*) because ...
3 weeks, 1 day ago (2018-08-30 13:49:20 UTC) #57
pokoli
Use count(*)
2 weeks, 6 days ago (2018-09-01 09:08:31 UTC) #58
reviewbot
https://codereview.tryton.org/45241002/diff/320001/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/45241002
2 weeks, 6 days ago (2018-09-01 09:20:51 UTC) #59
ced
LGTM
2 weeks, 6 days ago (2018-09-01 10:23:55 UTC) #60
rietveld-bot_tryton.org
New changeset 3b0191acc179 by Sergi Almacellas Abellana in branch 'default': Allow to export tax reports ...
2 weeks, 6 days ago (2018-09-01 13:01:18 UTC) #61
rietveld-bot_tryton.org
2 weeks, 6 days ago (2018-09-01 13:01:23 UTC) #62
New changeset 2bce4e6e4ef2 by Sergi Almacellas Abellana in branch 'default':
Allow to export tax reports as file
https://hg.tryton.org/tryton-env/rev/2bce4e6e4ef2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766