Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 45461002: trytond: Add transactional queue and workers

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by ced
Modified:
2 days, 6 hours ago
Reviewers:
pokoli, reviewbot, nicoe, albert
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 21

Patch Set 2 : Reset all timestamp when copying task #

Patch Set 3 : Add help #

Patch Set 4 : Add doc and some bugfixes #

Total comments: 2

Patch Set 5 : Improve doc #

Patch Set 6 : Store tasks in Transaction class and filter deleted records #

Patch Set 7 : Update to tip #

Patch Set 8 : Update to tip #

Total comments: 1

Patch Set 9 : doc typo and spacing #

Patch Set 10 : Update to tip #

Total comments: 12

Patch Set 11 : Fix doc typo and simplify tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+514 lines, -3 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
A bin/trytond-worker View 1 2 3 4 5 6 7 1 chunk +24 lines, -0 lines 0 comments Download
M doc/ref/models/models.rst View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download
M doc/topics/configuration.rst View 1 2 3 4 5 6 7 8 9 1 chunk +11 lines, -0 lines 0 comments Download
M doc/topics/index.rst View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M doc/topics/start_server.rst View 1 2 3 4 5 6 7 8 1 chunk +12 lines, -0 lines 0 comments Download
A doc/topics/task_queue.rst View 1 2 3 4 5 6 7 8 9 10 1 chunk +55 lines, -0 lines 0 comments Download
M trytond/backend/database.py View 2 chunks +8 lines, -0 lines 0 comments Download
M trytond/backend/postgresql/database.py View 1 2 3 4 5 6 7 8 3 chunks +18 lines, -0 lines 0 comments Download
M trytond/backend/sqlite/database.py View 1 2 3 4 5 6 7 2 chunks +4 lines, -1 line 0 comments Download
M trytond/commandline.py View 1 chunk +13 lines, -0 lines 0 comments Download
M trytond/config.py View 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/ir/__init__.py View 2 chunks +2 lines, -0 lines 0 comments Download
A trytond/ir/queue.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +209 lines, -0 lines 0 comments Download
M trytond/model/model.py View 1 2 3 4 5 6 7 8 9 2 chunks +10 lines, -2 lines 0 comments Download
M trytond/protocols/dispatcher.py View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M trytond/res/ir.xml View 1 chunk +15 lines, -0 lines 0 comments Download
M trytond/transaction.py View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
A trytond/worker.py View 1 chunk +115 lines, -0 lines 0 comments Download

Messages

Total messages: 35
ced
2 months, 2 weeks ago (2018-04-30 16:47:59 UTC) #1
reviewbot
https://codereview.tryton.org/45461002/diff/1/trytond/backend/postgresql/database.py#newcode253 trytond/backend/postgresql/database.py:253: E127 continuation line over-indented for visual indent https://codereview.tryton.org/45461002/diff/1/trytond/backend/postgresql/database.py#newcode441 trytond/backend/postgresql/database.py:441: E131 continuation line unaligned ...
2 months, 2 weeks ago (2018-04-30 16:59:48 UTC) #2
albert
https://codereview.tryton.org/45461002/diff/1/trytond/ir/queue.py File trytond/ir/queue.py (right): https://codereview.tryton.org/45461002/diff/1/trytond/ir/queue.py#newcode86 trytond/ir/queue.py:86: limit=1)) According to PostgreSQL documentation [1] combining advisory locks ...
2 months, 1 week ago (2018-05-07 22:25:55 UTC) #3
ced
https://codereview.tryton.org/45461002/diff/1/trytond/ir/queue.py File trytond/ir/queue.py (right): https://codereview.tryton.org/45461002/diff/1/trytond/ir/queue.py#newcode86 trytond/ir/queue.py:86: limit=1)) On 2018/05/07 22:25:55, albert wrote: > According to ...
2 months, 1 week ago (2018-05-08 00:18:55 UTC) #4
pokoli
https://codereview.tryton.org/45461002/diff/1/trytond/ir/queue.py File trytond/ir/queue.py (right): https://codereview.tryton.org/45461002/diff/1/trytond/ir/queue.py#newcode24 trytond/ir/queue.py:24: enqueued_at = fields.Timestamp("Enqueued at", required=True) enqueed at is not ...
1 month, 3 weeks ago (2018-05-22 12:14:49 UTC) #5
ced
https://codereview.tryton.org/45461002/diff/1/trytond/ir/queue.py File trytond/ir/queue.py (right): https://codereview.tryton.org/45461002/diff/1/trytond/ir/queue.py#newcode24 trytond/ir/queue.py:24: enqueued_at = fields.Timestamp("Enqueued at", required=True) On 2018/05/22 12:14:49, pokoli ...
1 month, 3 weeks ago (2018-05-22 13:09:52 UTC) #6
ced
Reset all timestamp when copying task
1 month, 3 weeks ago (2018-05-22 13:10:26 UTC) #7
reviewbot
https://codereview.tryton.org/45461002/diff/20001/trytond/backend/postgresql/database.py#newcode253 trytond/backend/postgresql/database.py:253: E127 continuation line over-indented for visual indent https://codereview.tryton.org/45461002/diff/20001/trytond/backend/postgresql/database.py#newcode441 trytond/backend/postgresql/database.py:441: E131 continuation line unaligned ...
1 month, 3 weeks ago (2018-05-22 13:20:45 UTC) #8
pokoli
https://codereview.tryton.org/45461002/diff/1/trytond/ir/queue.py File trytond/ir/queue.py (right): https://codereview.tryton.org/45461002/diff/1/trytond/ir/queue.py#newcode24 trytond/ir/queue.py:24: enqueued_at = fields.Timestamp("Enqueued at", required=True) On 2018/05/22 13:09:52, ced ...
1 month, 3 weeks ago (2018-05-22 14:04:30 UTC) #9
ced
https://codereview.tryton.org/45461002/diff/1/trytond/worker.py File trytond/worker.py (right): https://codereview.tryton.org/45461002/diff/1/trytond/worker.py#newcode54 trytond/worker.py:54: logger.info("start %d workers", processes) On 2018/05/22 14:04:30, pokoli wrote: ...
1 month, 3 weeks ago (2018-05-22 16:19:40 UTC) #10
ced
Add help
1 month, 3 weeks ago (2018-05-23 16:43:04 UTC) #11
reviewbot
https://codereview.tryton.org/45461002/diff/40001/trytond/backend/postgresql/database.py#newcode453 trytond/backend/postgresql/database.py:453: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/45461002/diff/40001/trytond/backend/postgresql/database.py#newcode454 trytond/backend/postgresql/database.py:454: E131 continuation line unaligned ...
1 month, 3 weeks ago (2018-05-23 16:49:49 UTC) #12
ced
Add doc and some bugfixes
1 month, 3 weeks ago (2018-05-23 17:55:53 UTC) #13
reviewbot
https://codereview.tryton.org/45461002/diff/60001/trytond/backend/postgresql/database.py#newcode453 trytond/backend/postgresql/database.py:453: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/45461002/diff/60001/trytond/backend/postgresql/database.py#newcode454 trytond/backend/postgresql/database.py:454: E131 continuation line unaligned ...
1 month, 3 weeks ago (2018-05-23 18:29:36 UTC) #14
pokoli
https://codereview.tryton.org/45461002/diff/60001/doc/topics/task_queue.rst File doc/topics/task_queue.rst (right): https://codereview.tryton.org/45461002/diff/60001/doc/topics/task_queue.rst#newcode10 doc/topics/task_queue.rst:10: <topics-start-server>`. Should we note that if the worker is ...
1 month, 3 weeks ago (2018-05-24 08:32:18 UTC) #15
ced
Improve doc
1 month, 3 weeks ago (2018-05-24 09:05:56 UTC) #16
reviewbot
https://codereview.tryton.org/45461002/diff/80001/trytond/backend/postgresql/database.py#newcode453 trytond/backend/postgresql/database.py:453: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/45461002/diff/80001/trytond/backend/postgresql/database.py#newcode454 trytond/backend/postgresql/database.py:454: E131 continuation line unaligned ...
1 month, 3 weeks ago (2018-05-24 09:21:40 UTC) #17
ced
Store tasks in Transaction class and filter deleted records
1 month, 3 weeks ago (2018-05-24 11:06:51 UTC) #18
reviewbot
https://codereview.tryton.org/45461002/diff/100001/trytond/backend/postgresql/database.py#newcode453 trytond/backend/postgresql/database.py:453: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/45461002/diff/100001/trytond/backend/postgresql/database.py#newcode454 trytond/backend/postgresql/database.py:454: E131 continuation line unaligned ...
1 month, 3 weeks ago (2018-05-24 11:26:12 UTC) #19
ced
Update to tip
2 weeks, 5 days ago (2018-06-26 10:55:03 UTC) #20
reviewbot
https://codereview.tryton.org/45461002/diff/120001/trytond/backend/postgresql/database.py#newcode448 trytond/backend/postgresql/database.py:448: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/45461002/diff/120001/trytond/backend/postgresql/database.py#newcode449 trytond/backend/postgresql/database.py:449: E131 continuation line unaligned ...
2 weeks, 5 days ago (2018-06-26 11:05:48 UTC) #21
reviewbot
https://codereview.tryton.org/45461002/diff/120001/trytond/backend/postgresql/database.py#newcode6 trytond/backend/postgresql/database.py:6: E401 multiple imports on one line https://codereview.tryton.org/45461002/diff/120001/trytond/backend/postgresql/database.py#newcode448 trytond/backend/postgresql/database.py:448: E131 continuation line unaligned for ...
2 weeks, 5 days ago (2018-06-26 20:55:54 UTC) #22
reviewbot
https://codereview.tryton.org/45461002/diff/120001/trytond/backend/postgresql/database.py#newcode6 trytond/backend/postgresql/database.py:6: E401 multiple imports on one line https://codereview.tryton.org/45461002/diff/120001/trytond/backend/postgresql/database.py#newcode448 trytond/backend/postgresql/database.py:448: E131 continuation line unaligned for ...
2 weeks, 5 days ago (2018-06-26 20:58:07 UTC) #23
reviewbot
https://codereview.tryton.org/45461002/diff/120001/trytond/backend/postgresql/database.py#newcode6 trytond/backend/postgresql/database.py:6: E401 multiple imports on one line https://codereview.tryton.org/45461002/diff/120001/trytond/backend/postgresql/database.py#newcode448 trytond/backend/postgresql/database.py:448: E131 continuation line unaligned for ...
2 weeks, 4 days ago (2018-06-26 21:05:56 UTC) #24
ced
Update to tip
2 weeks, 4 days ago (2018-06-26 21:12:45 UTC) #25
reviewbot
https://codereview.tryton.org/45461002/diff/140001/trytond/backend/postgresql/database.py#newcode6 trytond/backend/postgresql/database.py:6: E401 multiple imports on one line https://codereview.tryton.org/45461002/diff/140001/trytond/backend/postgresql/database.py#newcode448 trytond/backend/postgresql/database.py:448: E131 continuation line unaligned for ...
2 weeks, 4 days ago (2018-06-26 21:28:02 UTC) #26
nicoe
https://codereview.tryton.org/45461002/diff/1/doc/topics/start_server.rst File doc/topics/start_server.rst (right): https://codereview.tryton.org/45461002/diff/1/doc/topics/start_server.rst#newcode48 doc/topics/start_server.rst:48: If you want to use a pool of workers ...
2 weeks, 3 days ago (2018-06-28 10:26:06 UTC) #27
ced
doc typo and spacing
2 weeks, 3 days ago (2018-06-28 11:30:03 UTC) #28
reviewbot
https://codereview.tryton.org/45461002/diff/160001/trytond/backend/postgresql/database.py#newcode6 trytond/backend/postgresql/database.py:6: E401 multiple imports on one line https://codereview.tryton.org/45461002/diff/160001/trytond/backend/postgresql/database.py#newcode448 trytond/backend/postgresql/database.py:448: E131 continuation line unaligned for ...
2 weeks, 3 days ago (2018-06-28 11:34:39 UTC) #29
ced
Update to tip
5 days, 5 hours ago (2018-07-10 15:25:17 UTC) #30
reviewbot
https://codereview.tryton.org/45461002/diff/180001/trytond/backend/postgresql/database.py#newcode6 trytond/backend/postgresql/database.py:6: E401 multiple imports on one line https://codereview.tryton.org/45461002/diff/180001/trytond/backend/postgresql/database.py#newcode448 trytond/backend/postgresql/database.py:448: E131 continuation line unaligned for ...
5 days, 5 hours ago (2018-07-10 15:41:40 UTC) #31
pokoli
https://codereview.tryton.org/45461002/diff/180001/doc/ref/models/models.rst File doc/ref/models/models.rst (right): https://codereview.tryton.org/45461002/diff/180001/doc/ref/models/models.rst#newcode46 doc/ref/models/models.rst:46: It returns a queue caller for the model. The ...
2 days, 10 hours ago (2018-07-13 10:42:10 UTC) #32
ced
https://codereview.tryton.org/45461002/diff/180001/doc/ref/models/models.rst File doc/ref/models/models.rst (right): https://codereview.tryton.org/45461002/diff/180001/doc/ref/models/models.rst#newcode46 doc/ref/models/models.rst:46: It returns a queue caller for the model. The ...
2 days, 6 hours ago (2018-07-13 14:28:53 UTC) #33
ced
Fix doc typo and simplify tests
2 days, 6 hours ago (2018-07-13 14:29:00 UTC) #34
reviewbot
2 days, 6 hours ago (2018-07-13 14:46:30 UTC) #35
https://codereview.tryton.org/45461002/diff/200001/trytond/backend/postgresql...
trytond/backend/postgresql/database.py:6:
E401 multiple imports on one line

https://codereview.tryton.org/45461002/diff/200001/trytond/backend/postgresql...
trytond/backend/postgresql/database.py:464:
E131 continuation line unaligned for hanging indent

https://codereview.tryton.org/45461002/diff/200001/trytond/backend/postgresql...
trytond/backend/postgresql/database.py:465:
E131 continuation line unaligned for hanging indent

https://codereview.tryton.org/45461002/diff/200001/trytond/backend/postgresql...
trytond/backend/postgresql/database.py:471:
E131 continuation line unaligned for hanging indent

https://codereview.tryton.org/45461002/diff/200001/trytond/backend/postgresql...
trytond/backend/postgresql/database.py:472:
E131 continuation line unaligned for hanging indent

https://codereview.tryton.org/45461002/diff/200001/trytond/backend/sqlite/dat...
trytond/backend/sqlite/database.py:21:
E402 module level import not at top of file

https://codereview.tryton.org/45461002/diff/200001/trytond/backend/sqlite/dat...
trytond/backend/sqlite/database.py:22:
E402 module level import not at top of file

https://codereview.tryton.org/45461002/diff/200001/trytond/backend/sqlite/dat...
trytond/backend/sqlite/database.py:25:
E402 module level import not at top of file

https://codereview.tryton.org/45461002/diff/200001/trytond/backend/sqlite/dat...
trytond/backend/sqlite/database.py:26:
E402 module level import not at top of file

https://codereview.tryton.org/45461002/diff/200001/trytond/model/model.py#new...
trytond/model/model.py:188:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/45461002/diff/200001/trytond/model/model.py#new...
trytond/model/model.py:251:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/45461002/diff/200001/trytond/model/model.py#new...
trytond/model/model.py:277:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:4:
F403 'from configuration import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:5:
F403 'from translation import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:6:
F403 'from sequence import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:7:
F403 'from ui.menu import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:8:
F403 'from ui.view import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:9:
F403 'from ui.icon import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:10:
F403 'from action import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:11:
F403 'from model import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:12:
F403 'from attachment import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:13:
F403 'from note import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:14:
F403 'from cron import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:15:
F403 'from lang import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:16:
F403 'from export import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:17:
F403 'from rule import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:18:
F403 'from module import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:19:
F403 'from cache import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:20:
F403 'from date import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:21:
F403 'from trigger import *' used; unable to detect undefined names

https://codereview.tryton.org/45461002/diff/200001/trytond/ir/__init__.py#new...
trytond/ir/__init__.py:22:
F403 'from session import *' used; unable to detect undefined names

URL: https://codereview.tryton.org/45461002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69