Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Issue 45551002: account: Remove default account from journal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 3 weeks ago by pokoli
Modified:
3 months, 2 weeks ago
Reviewers:
timitos3000, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Also add write off method issue7450

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add writeoff method model #

Total comments: 1

Patch Set 3 : Merge writeoff method and payment method in a single model #

Patch Set 4 : Add payment method type default value #

Patch Set 5 : Add changelog and to payment method merge #

Total comments: 1

Patch Set 6 : Define only writeoff method #

Total comments: 1

Patch Set 7 : Fix typo in CHANGELOG #

Total comments: 3

Patch Set 8 : Fix comments #

Total comments: 6

Patch Set 9 : Fix comments #

Total comments: 7

Patch Set 10 : Fix comments and update docs #

Patch Set 11 : typo #

Total comments: 2

Patch Set 12 : Improve readability and declare access rights following view #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -56 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M __init__.py View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M doc/index.rst View 1 2 3 4 5 6 7 8 9 10 1 chunk +14 lines, -2 lines 0 comments Download
M journal.py View 1 2 3 4 5 6 7 8 9 2 chunks +1 line, -27 lines 0 comments Download
M move.py View 1 2 3 4 5 6 7 8 9 10 11 10 chunks +56 lines, -16 lines 0 comments Download
M move.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +44 lines, -0 lines 0 comments Download
M tests/scenario_account_reconciliation.rst View 1 2 3 4 5 6 7 8 9 1 chunk +13 lines, -4 lines 0 comments Download
M view/journal_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -4 lines 0 comments Download
M view/reconcile_lines_writeoff_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
A view/writeoff_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +17 lines, -0 lines 0 comments Download
A view/writeoff_tree.xml View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 35
pokoli
6 months, 3 weeks ago (2018-05-23 10:00:36 UTC) #1
reviewbot
https://codereview.tryton.org/45551002/diff/1/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/45551002/diff/1/__init__.py#newcode6 __init__.py:6: ...
6 months, 3 weeks ago (2018-05-23 10:28:48 UTC) #2
ced
https://codereview.tryton.org/45551002/diff/1/move.py File move.py (right): https://codereview.tryton.org/45551002/diff/1/move.py#newcode1389 move.py:1389: account = fields.Many2One('account.account', "Account", required=True, I think it needed ...
6 months, 2 weeks ago (2018-05-31 08:30:19 UTC) #3
pokoli
Add writeoff method model
6 months, 1 week ago (2018-06-06 14:53:30 UTC) #4
reviewbot
https://codereview.tryton.org/45551002/diff/20001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/45551002/diff/20001/__init__.py#newcode6 __init__.py:6: ...
6 months, 1 week ago (2018-06-06 15:00:28 UTC) #5
ced
https://codereview.tryton.org/45551002/diff/20001/journal.py File journal.py (right): https://codereview.tryton.org/45551002/diff/20001/journal.py#newcode238 journal.py:238: They are strictly identical. Will it not be better ...
6 months, 1 week ago (2018-06-06 15:27:39 UTC) #6
pokoli
Merge writeoff method and payment method in a single model
6 months, 1 week ago (2018-06-07 12:20:15 UTC) #7
reviewbot
https://codereview.tryton.org/45551002/diff/40001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/45551002/diff/40001/__init__.py#newcode6 __init__.py:6: ...
6 months, 1 week ago (2018-06-07 12:25:45 UTC) #8
pokoli
Add payment method type default value
6 months, 1 week ago (2018-06-07 12:31:39 UTC) #9
pokoli
Add changelog and to payment method merge
6 months, 1 week ago (2018-06-07 12:32:25 UTC) #10
reviewbot
https://codereview.tryton.org/45551002/diff/80001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/45551002/diff/80001/__init__.py#newcode6 __init__.py:6: ...
6 months, 1 week ago (2018-06-07 12:57:10 UTC) #11
ced
https://codereview.tryton.org/45551002/diff/80001/journal.py File journal.py (right): https://codereview.tryton.org/45551002/diff/80001/journal.py#newcode188 journal.py:188: __name__ = 'account.payment.method' I'm not sure about the name ...
6 months, 1 week ago (2018-06-08 07:08:17 UTC) #12
pokoli
Define only writeoff method
6 months ago (2018-06-14 09:56:56 UTC) #13
reviewbot
https://codereview.tryton.org/45551002/diff/100001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/45551002/diff/100001/__init__.py#newcode6 __init__.py:6: ...
6 months ago (2018-06-14 10:04:21 UTC) #14
timitos3000
https://codereview.tryton.org/45551002/diff/100001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/45551002/diff/100001/CHANGELOG#newcode1 CHANGELOG:1: * Add wirteoff method writeoff
6 months ago (2018-06-14 10:08:15 UTC) #15
pokoli
Fix typo in CHANGELOG
6 months ago (2018-06-14 10:14:15 UTC) #16
reviewbot
https://codereview.tryton.org/45551002/diff/120001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/45551002/diff/120001/__init__.py#newcode6 __init__.py:6: ...
6 months ago (2018-06-14 10:27:00 UTC) #17
ced
https://codereview.tryton.org/45551002/diff/120001/move.py File move.py (right): https://codereview.tryton.org/45551002/diff/120001/move.py#newcode1185 move.py:1185: The writeoff keys are: journal, date, account, method and ...
5 months, 3 weeks ago (2018-06-22 10:05:37 UTC) #18
ced
https://codereview.tryton.org/45551002/diff/120001/journal.py File journal.py (right): https://codereview.tryton.org/45551002/diff/120001/journal.py#newcode188 journal.py:188: __name__ = 'account.reconcile.write_off' Should it not be define in ...
5 months, 3 weeks ago (2018-06-22 10:08:59 UTC) #19
pokoli
Fix comments
5 months, 3 weeks ago (2018-06-22 12:34:39 UTC) #20
reviewbot
https://codereview.tryton.org/45551002/diff/140001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/45551002/diff/140001/__init__.py#newcode6 __init__.py:6: ...
5 months, 3 weeks ago (2018-06-22 13:05:51 UTC) #21
ced
https://codereview.tryton.org/45551002/diff/140001/move.py File move.py (right): https://codereview.tryton.org/45551002/diff/140001/move.py#newcode1432 move.py:1432: 'on_change_with_currency_digits') Did you test that on_change's are called on ...
5 months, 1 week ago (2018-07-05 22:49:29 UTC) #22
pokoli
Fix comments
5 months, 1 week ago (2018-07-06 15:23:50 UTC) #23
pokoli
https://codereview.tryton.org/45551002/diff/140001/move.py File move.py (right): https://codereview.tryton.org/45551002/diff/140001/move.py#newcode1432 move.py:1432: 'on_change_with_currency_digits') On 2018/07/05 22:49:28, ced wrote: > Did you ...
5 months, 1 week ago (2018-07-06 15:23:56 UTC) #24
reviewbot
https://codereview.tryton.org/45551002/diff/160001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/45551002/diff/160001/__init__.py#newcode6 __init__.py:6: ...
5 months, 1 week ago (2018-07-06 15:50:53 UTC) #25
ced
https://codereview.tryton.org/45551002/diff/160001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/45551002/diff/160001/CHANGELOG#newcode3 CHANGELOG:3: * Remove default account from journal Wrong order https://codereview.tryton.org/45551002/diff/160001/move.py ...
5 months, 1 week ago (2018-07-12 09:48:43 UTC) #26
ced
doc should be updated
5 months, 1 week ago (2018-07-12 09:56:01 UTC) #27
pokoli
Fix comments and update docs
4 months, 2 weeks ago (2018-08-02 12:28:31 UTC) #28
pokoli
typo
4 months, 2 weeks ago (2018-08-02 12:32:02 UTC) #29
reviewbot
https://codereview.tryton.org/45551002/diff/200001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/45551002/diff/200001/__init__.py#newcode6 __init__.py:6: ...
4 months, 2 weeks ago (2018-08-02 12:33:30 UTC) #30
ced
https://codereview.tryton.org/45551002/diff/200001/move.py File move.py (right): https://codereview.tryton.org/45551002/diff/200001/move.py#newcode1209 move.py:1209: description) Will it not be more readable like this: ...
4 months, 2 weeks ago (2018-08-02 23:21:17 UTC) #31
pokoli
Improve readability and declare access rights following view
4 months, 1 week ago (2018-08-08 10:21:19 UTC) #32
reviewbot
https://codereview.tryton.org/45551002/diff/220001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/45551002/diff/220001/__init__.py#newcode6 __init__.py:6: ...
4 months, 1 week ago (2018-08-08 10:36:22 UTC) #33
ced
LGTM
3 months, 3 weeks ago (2018-08-21 20:58:07 UTC) #34
rietveld-bot_tryton.org
3 months, 2 weeks ago (2018-09-01 09:28:10 UTC) #35
New changeset d1d3a1c12158 by Sergi Almacellas Abellana in branch 'default':
Remove default account from journal
https://hg.tryton.org/modules/account/rev/d1d3a1c12158
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766