Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(329)

Issue 45561002: account_invoice: Add invoice payment method (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 3 weeks ago by pokoli
Modified:
3 months, 2 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rename counterpart, add company domain and use writeoff method model #

Patch Set 3 : Add changelog and to payment method merge #

Patch Set 4 : Add invoice payment method #

Total comments: 8

Patch Set 5 : Fix comments #

Patch Set 6 : Apply same remarks as account review #

Total comments: 4

Patch Set 7 : Fix comments and update docs #

Total comments: 3

Patch Set 8 : Fix comments #

Total comments: 1

Patch Set 9 : Use domain for payment accounts and remove error messages #

Patch Set 10 : Add missing depends #

Total comments: 3

Patch Set 11 : Do not test amount and type on account domain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -59 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M __init__.py View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M doc/index.rst View 1 2 3 4 5 6 7 1 chunk +14 lines, -0 lines 0 comments Download
M invoice.py View 1 2 3 4 5 6 7 8 9 10 12 chunks +55 lines, -32 lines 0 comments Download
M invoice.xml View 1 2 3 4 5 6 1 chunk +44 lines, -0 lines 0 comments Download
M tests/scenario_invoice.rst View 1 2 3 4 5 6 7 5 chunks +23 lines, -13 lines 0 comments Download
M tests/scenario_invoice_alternate_currency.rst View 1 2 3 4 5 6 7 2 chunks +20 lines, -10 lines 0 comments Download
M view/pay_ask_form.xml View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M view/pay_start_form.xml View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
A view/payment_method_form.xml View 1 2 3 4 5 6 1 chunk +17 lines, -0 lines 0 comments Download
A view/payment_method_tree.xml View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 34
pokoli
6 months, 3 weeks ago (2018-05-23 10:03:00 UTC) #1
reviewbot
https://codereview.tryton.org/45561002/diff/1/invoice.py#newcode645 invoice.py:645: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/45561002
6 months, 3 weeks ago (2018-05-23 10:28:52 UTC) #2
ced
Missing changelog https://codereview.tryton.org/45561002/diff/1/invoice.py File invoice.py (right): https://codereview.tryton.org/45561002/diff/1/invoice.py#newcode1248 invoice.py:1248: counterpart_acccount = 'debit_account' Why not payment_account ? ...
6 months, 2 weeks ago (2018-05-31 08:41:26 UTC) #3
pokoli
Rename counterpart, add company domain and use writeoff method model
6 months, 1 week ago (2018-06-06 15:15:58 UTC) #4
reviewbot
https://codereview.tryton.org/45561002/diff/20001/invoice.py#newcode645 invoice.py:645: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/45561002
6 months, 1 week ago (2018-06-06 15:29:46 UTC) #5
ced
Still missing changelog
6 months, 1 week ago (2018-06-06 15:33:07 UTC) #6
pokoli
Add changelog and to payment method merge
6 months, 1 week ago (2018-06-07 12:33:37 UTC) #7
reviewbot
https://codereview.tryton.org/45561002/diff/40001/invoice.py#newcode645 invoice.py:645: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/45561002
6 months, 1 week ago (2018-06-07 12:57:15 UTC) #8
pokoli
Add invoice payment method
6 months ago (2018-06-14 10:13:50 UTC) #9
reviewbot
https://codereview.tryton.org/45561002/diff/60001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/45561002/diff/60001/__init__.py#newcode6 __init__.py:6: ...
6 months ago (2018-06-14 10:27:05 UTC) #10
ced
https://codereview.tryton.org/45561002/diff/60001/account.py File account.py (right): https://codereview.tryton.org/45561002/diff/60001/account.py#newcode332 account.py:332: __name__ = 'account.invoice.payment.method' Should not it be in invoice.py ...
5 months, 3 weeks ago (2018-06-22 10:13:56 UTC) #11
pokoli
Fix comments
5 months, 3 weeks ago (2018-06-22 12:52:23 UTC) #12
pokoli
https://codereview.tryton.org/45561002/diff/60001/account.py File account.py (right): https://codereview.tryton.org/45561002/diff/60001/account.py#newcode340 account.py:340: ('kind', '!=', 'view'), On 2018/06/22 10:13:55, ced wrote: > ...
5 months, 3 weeks ago (2018-06-22 12:52:41 UTC) #13
reviewbot
https://codereview.tryton.org/45561002/diff/80001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/45561002/diff/80001/__init__.py#newcode6 __init__.py:6: ...
5 months, 3 weeks ago (2018-06-22 13:05:55 UTC) #14
ced
https://codereview.tryton.org/45561002/diff/60001/account.py File account.py (right): https://codereview.tryton.org/45561002/diff/60001/account.py#newcode340 account.py:340: ('kind', '!=', 'view'), On 2018/06/22 12:52:41, pokoli wrote: > ...
5 months, 3 weeks ago (2018-06-22 14:08:03 UTC) #15
pokoli
Apply same remarks as account review
5 months, 1 week ago (2018-07-06 15:24:45 UTC) #16
reviewbot
https://codereview.tryton.org/45561002/diff/100001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/45561002/diff/100001/__init__.py#newcode6 __init__.py:6: ...
5 months, 1 week ago (2018-07-06 15:50:58 UTC) #17
ced
I think doc should be updated. https://codereview.tryton.org/45561002/diff/100001/account.xml File account.xml (left): https://codereview.tryton.org/45561002/diff/100001/account.xml#oldcode97 account.xml:97: Not for this ...
5 months, 1 week ago (2018-07-12 09:55:23 UTC) #18
pokoli
Fix comments and update docs
4 months, 2 weeks ago (2018-08-02 13:34:46 UTC) #19
reviewbot
https://codereview.tryton.org/45561002/diff/120001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/45561002/diff/120001/__init__.py#newcode6 __init__.py:6: ...
4 months, 2 weeks ago (2018-08-02 13:41:29 UTC) #20
ced
https://codereview.tryton.org/45561002/diff/120001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/45561002/diff/120001/doc/index.rst#newcode133 doc/index.rst:133: The payment options available when using the *Pay Invoice* ...
4 months, 2 weeks ago (2018-08-02 23:22:40 UTC) #21
pokoli
Fix comments
4 months, 1 week ago (2018-08-08 10:26:32 UTC) #22
reviewbot
https://codereview.tryton.org/45561002/diff/140001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/45561002/diff/140001/__init__.py#newcode6 __init__.py:6: ...
4 months, 1 week ago (2018-08-08 10:39:04 UTC) #23
ced
https://codereview.tryton.org/45561002/diff/140001/invoice.py File invoice.py (right): https://codereview.tryton.org/45561002/diff/140001/invoice.py#newcode1254 invoice.py:1254: if self.account == line2.account: I think we could remove ...
3 months, 3 weeks ago (2018-08-21 21:03:41 UTC) #24
pokoli
Use domain for payment accounts and remove error messages
3 months, 3 weeks ago (2018-08-22 08:47:09 UTC) #25
pokoli
Add missing depends
3 months, 3 weeks ago (2018-08-22 08:51:09 UTC) #26
reviewbot
https://codereview.tryton.org/45561002/diff/180001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/45561002/diff/180001/__init__.py#newcode6 __init__.py:6: ...
3 months, 3 weeks ago (2018-08-22 09:06:21 UTC) #27
ced
https://codereview.tryton.org/45561002/diff/180001/invoice.py File invoice.py (right): https://codereview.tryton.org/45561002/diff/180001/invoice.py#newcode2450 invoice.py:2450: ), '!=', Eval('invoice_account')), I was thinking that we could ...
3 months, 3 weeks ago (2018-08-23 07:16:27 UTC) #28
pokoli
Do not test amount and type on account domain
3 months, 3 weeks ago (2018-08-23 08:11:30 UTC) #29
pokoli
https://codereview.tryton.org/45561002/diff/180001/invoice.py File invoice.py (right): https://codereview.tryton.org/45561002/diff/180001/invoice.py#newcode2450 invoice.py:2450: ), '!=', Eval('invoice_account')), On 2018/08/23 07:16:27, ced wrote: > ...
3 months, 3 weeks ago (2018-08-23 08:12:45 UTC) #30
ced
https://codereview.tryton.org/45561002/diff/180001/invoice.py File invoice.py (right): https://codereview.tryton.org/45561002/diff/180001/invoice.py#newcode2450 invoice.py:2450: ), '!=', Eval('invoice_account')), On 2018/08/23 08:12:45, pokoli wrote: > ...
3 months, 3 weeks ago (2018-08-23 08:24:06 UTC) #31
reviewbot
https://codereview.tryton.org/45561002/diff/200001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/45561002/diff/200001/__init__.py#newcode6 __init__.py:6: ...
3 months, 3 weeks ago (2018-08-23 08:25:57 UTC) #32
ced
LGTM
3 months, 3 weeks ago (2018-08-27 08:13:33 UTC) #33
rietveld-bot_tryton.org
3 months, 2 weeks ago (2018-09-01 09:28:16 UTC) #34
New changeset 9e3ebaae6bb7 by Sergi Almacellas Abellana in branch 'default':
Add invoice payment method
https://hg.tryton.org/modules/account_invoice/rev/9e3ebaae6bb7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766