Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(69)

Issue 45681002: account: Group by account and party when reconciling cancel moves

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by pokoli
Modified:
1 week, 2 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update existing move instead of creating a new one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M move.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/scenario_move_cancel.rst View 1 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6
pokoli
1 week, 3 days ago (2018-08-08 13:50:35 UTC) #1
reviewbot
https://codereview.tryton.org/45681002/diff/1/move.py#newcode75 move.py:75: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/45681002/diff/1/move.py#newcode421 move.py:421: E731 do not assign ...
1 week, 3 days ago (2018-08-08 14:00:27 UTC) #2
ced
https://codereview.tryton.org/45681002/diff/1/tests/scenario_move_cancel.rst File tests/scenario_move_cancel.rst (right): https://codereview.tryton.org/45681002/diff/1/tests/scenario_move_cancel.rst#newcode104 tests/scenario_move_cancel.rst:104: Create Move with two parties:: I would prefer to ...
1 week, 3 days ago (2018-08-08 14:18:41 UTC) #3
pokoli
Update existing move instead of creating a new one
1 week, 3 days ago (2018-08-08 15:59:14 UTC) #4
reviewbot
https://codereview.tryton.org/45681002/diff/20001/move.py#newcode75 move.py:75: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/45681002/diff/20001/move.py#newcode421 move.py:421: E731 do not assign ...
1 week, 3 days ago (2018-08-08 16:10:02 UTC) #5
ced
1 week, 2 days ago (2018-08-08 19:46:03 UTC) #6
LGTM, please commit the test separately for back-port.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69