Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(41)

Issue 45701002: account_tax_cash: Replace sum_domain by amount_domain on super method call (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by pokoli
Modified:
2 months, 1 week ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M account.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
pokoli
2 months, 3 weeks ago (2018-08-23 15:57:53 UTC) #1
reviewbot
https://codereview.tryton.org/45701002/diff/1/account.py#newcode104 account.py:104: E712 comparison to False should be 'if cond is False:' or 'if not ...
2 months, 3 weeks ago (2018-08-23 16:05:45 UTC) #2
ced
LGTM
2 months, 3 weeks ago (2018-08-24 07:43:54 UTC) #3
rietveld-bot_tryton.org
New changeset cd8113caa846 by Sergi Almacellas Abellana in branch 'default': Replace sum_domain by amount_domain on ...
2 months, 3 weeks ago (2018-08-27 08:25:22 UTC) #4
rietveld-bot_tryton.org
New changeset 09b97ea630f8 by Sergi Almacellas Abellana in branch 'default': Replace sum_domain by amount_domain on ...
2 months, 3 weeks ago (2018-08-27 08:25:27 UTC) #5
rietveld-bot_tryton.org
2 months, 1 week ago (2018-09-05 20:08:03 UTC) #6
New changeset 020daed773f6 by Sergi Almacellas Abellana in branch '4.8':
Replace sum_domain by amount_domain on super method call
https://hg.tryton.org/modules/account_tax_cash/rev/020daed773f6
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766