Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(367)

Issue 45731002: party: Show contact mechanism url only when it's defined (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by pokoli
Modified:
2 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Make url getter an on_change function #

Patch Set 3 : Use custom value on _changed_values anddo not remove on_change_value function #

Total comments: 2

Patch Set 4 : Add missing method depends #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M contact_mechanism.py View 1 2 3 4 chunks +13 lines, -17 lines 0 comments Download

Messages

Total messages: 12
pokoli
2 months, 3 weeks ago (2018-09-24 11:37:56 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/45731002
2 months, 3 weeks ago (2018-09-24 11:55:02 UTC) #2
pokoli
Make url getter an on_change function
2 months, 3 weeks ago (2018-09-25 11:53:21 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/45731002
2 months, 3 weeks ago (2018-09-25 11:57:35 UTC) #4
pokoli
Use custom value on _changed_values anddo not remove on_change_value function
2 months, 3 weeks ago (2018-09-25 11:58:31 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/45731002
2 months, 3 weeks ago (2018-09-25 12:33:05 UTC) #6
ced
https://codereview.tryton.org/45731002/diff/40001/contact_mechanism.py File contact_mechanism.py (right): https://codereview.tryton.org/45731002/diff/40001/contact_mechanism.py#newcode158 contact_mechanism.py:158: def _change_value(self, value, type_): Should depend on on_change_with_url. https://codereview.tryton.org/45731002/diff/40001/contact_mechanism.py#newcode169 ...
2 months, 2 weeks ago (2018-09-30 21:58:54 UTC) #7
pokoli
Add missing method depends
2 months, 2 weeks ago (2018-10-03 13:17:20 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/45731002
2 months, 1 week ago (2018-10-03 13:26:50 UTC) #9
ced
LGTM
2 months, 1 week ago (2018-10-09 08:59:29 UTC) #10
rietveld-bot_tryton.org
New changeset 77dc19b2db36 by Sergi Almacellas Abellana in branch 'default': Show contact mechanism url only ...
2 months ago (2018-10-15 13:54:41 UTC) #11
rietveld-bot_tryton.org
2 months ago (2018-10-15 13:55:36 UTC) #12
New changeset 397dc9b2d378 by Sergi Almacellas Abellana in branch 'default':
Show contact mechanism url only when it's defined
https://hg.tryton.org/tryton-env/rev/397dc9b2d378
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766