Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(344)

Issue 45751002: tryton-env: Initial commit web_shortner & marketing_automation

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by nicoe
Modified:
2 weeks, 4 days ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Patch Set 1 #

Total comments: 45

Patch Set 2 : Fix remarks && Add converter to trytond #

Total comments: 36

Patch Set 3 : Fix remarks & Add marketing_automation module first draft #

Total comments: 41

Patch Set 4 : Fix remarks & add trigger function on marketing scenarios #

Patch Set 5 : Reverted index.rst change #

Total comments: 22

Patch Set 6 : More fixes on URLShortener #

Total comments: 26

Patch Set 7 : Fixe remarks & generate record activities / activities #

Total comments: 26

Patch Set 8 : Fixe remarks #

Patch Set 9 : Fix view & urlunsplit call #

Patch Set 10 : Add views & fix remarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2923 lines, -2 lines) Patch
M .hgsub View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A modules/marketing_automation/.drone.yml View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
A modules/marketing_automation/COPYRIGHT View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A modules/marketing_automation/INSTALL View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A modules/marketing_automation/LICENSE View 1 2 1 chunk +674 lines, -0 lines 0 comments Download
A modules/marketing_automation/MANIFEST.in View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A modules/marketing_automation/README View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A modules/marketing_automation/__init__.py View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A modules/marketing_automation/doc/index.rst View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A modules/marketing_automation/icons/robot.svg View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
A modules/marketing_automation/marketing.py View 1 2 3 4 5 6 7 8 9 1 chunk +402 lines, -0 lines 0 comments Download
A modules/marketing_automation/marketing.xml View 1 2 3 4 5 6 7 8 9 1 chunk +98 lines, -0 lines 0 comments Download
A modules/marketing_automation/setup.py View 1 2 3 1 chunk +123 lines, -0 lines 0 comments Download
A modules/marketing_automation/tests/__init__.py View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A modules/marketing_automation/tests/test_marketing_automation.py View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A modules/marketing_automation/tox.ini View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A modules/marketing_automation/tryton.cfg View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -0 lines 0 comments Download
A modules/marketing_automation/view/activity_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +29 lines, -0 lines 0 comments Download
A modules/marketing_automation/view/activity_timedelta_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +21 lines, -0 lines 0 comments Download
A modules/marketing_automation/view/activity_timedelta_list.xml View 1 2 3 4 5 6 7 8 9 1 chunk +12 lines, -0 lines 0 comments Download
A modules/marketing_automation/view/activity_tree.xml View 1 2 3 4 5 6 7 8 9 1 chunk +11 lines, -0 lines 0 comments Download
A modules/marketing_automation/view/record_list.xml View 1 2 3 4 5 6 7 8 9 1 chunk +8 lines, -0 lines 0 comments Download
A modules/marketing_automation/view/scenario_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +21 lines, -0 lines 0 comments Download
A modules/marketing_automation/view/scenario_list.xml View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download
A modules/web_shortener/.drone.yml View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
A modules/web_shortener/COPYRIGHT View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A modules/web_shortener/INSTALL View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A modules/web_shortener/LICENSE View 1 2 1 chunk +674 lines, -0 lines 0 comments Download
A modules/web_shortener/MANIFEST.in View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A modules/web_shortener/README View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A modules/web_shortener/__init__.py View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A modules/web_shortener/doc/index.rst View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
A modules/web_shortener/routes.py View 1 2 3 4 5 6 1 chunk +24 lines, -0 lines 0 comments Download
A modules/web_shortener/setup.py View 1 2 1 chunk +120 lines, -0 lines 0 comments Download
A modules/web_shortener/tests/__init__.py View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A modules/web_shortener/tests/test_web_shortener.py View 1 2 3 4 5 1 chunk +37 lines, -0 lines 0 comments Download
A modules/web_shortener/tox.ini View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A modules/web_shortener/tryton.cfg View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A modules/web_shortener/view/shortened_url_list.xml View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -0 lines 0 comments Download
A modules/web_shortener/web.py View 1 2 3 4 5 6 7 8 1 chunk +172 lines, -0 lines 0 comments Download
A modules/web_shortener/web.xml View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
M trytond/doc/topics/user_application.rst View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M trytond/trytond/wsgi.py View 1 2 3 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 42
nicoe
1 month ago (2018-10-15 16:39:40 UTC) #1
ced
https://codereview.tryton.org/45751002/diff/1/COPYRIGHT File COPYRIGHT (right): https://codereview.tryton.org/45751002/diff/1/COPYRIGHT#newcode1 COPYRIGHT:1: Copyright (C) 2018 Nicolas Êvrard B2CK https://codereview.tryton.org/45751002/diff/1/INSTALL File INSTALL ...
1 month ago (2018-10-15 23:18:21 UTC) #2
reviewbot
https://codereview.tryton.org/45751002/diff/1/__init__.py#newcode7 __init__.py:7: F401 'routes' imported but unused https://codereview.tryton.org/45751002/diff/1/setup.py#newcode87 setup.py:87: E501 line too long (85 > ...
1 month ago (2018-10-16 13:33:50 UTC) #3
nicoe
https://codereview.tryton.org/45751002/diff/1/COPYRIGHT File COPYRIGHT (right): https://codereview.tryton.org/45751002/diff/1/COPYRIGHT#newcode1 COPYRIGHT:1: Copyright (C) 2018 Nicolas Êvrard On 2018/10/15 23:18:20, ced ...
1 month ago (2018-10-16 16:27:14 UTC) #4
nicoe
Fix remarks
1 month ago (2018-10-16 16:27:41 UTC) #5
nicoe
Fix remarks && Add converter to trytond
1 month ago (2018-10-16 16:30:12 UTC) #6
reviewbot
patch is not applicable URL: https://codereview.tryton.org/45751002
1 month ago (2018-10-16 17:02:49 UTC) #7
ced
https://codereview.tryton.org/45751002/diff/1/INSTALL File INSTALL (right): https://codereview.tryton.org/45751002/diff/1/INSTALL#newcode1 INSTALL:1: Installing trytond_url_shortener On 2018/10/16 16:27:13, nicoe wrote: > On ...
1 month ago (2018-10-16 17:23:19 UTC) #8
nicoe
https://codereview.tryton.org/45751002/diff/1/routes.py File routes.py (right): https://codereview.tryton.org/45751002/diff/1/routes.py#newcode18 routes.py:18: ALPHABET = string.digits + string.ascii_uppercase On 2018/10/16 17:23:18, ced ...
1 month ago (2018-10-17 16:34:45 UTC) #9
nicoe
Fix remarks & Add marketing_automation module first draft
1 month ago (2018-10-17 16:35:03 UTC) #10
reviewbot
patch is not applicable URL: https://codereview.tryton.org/45751002
1 month ago (2018-10-17 16:35:33 UTC) #11
ced
https://codereview.tryton.org/45751002/diff/1/url.py File url.py (right): https://codereview.tryton.org/45751002/diff/1/url.py#newcode66 url.py:66: method = getattr(Model.__queue__, self.action) On 2018/10/17 16:34:44, nicoe wrote: ...
1 month ago (2018-10-17 17:44:25 UTC) #12
ced
New modules must be added to readthedocs https://codereview.tryton.org/45751002/diff/60001/modules/web_shortener/web.py File modules/web_shortener/web.py (right): https://codereview.tryton.org/45751002/diff/60001/modules/web_shortener/web.py#newcode82 modules/web_shortener/web.py:82: def execute(self): ...
1 month ago (2018-10-18 08:24:35 UTC) #13
pokoli
1 month ago (2018-10-18 15:59:31 UTC) #14
nicoe
https://codereview.tryton.org/45751002/diff/40001/modules/url_shortener/routes.py File modules/url_shortener/routes.py (right): https://codereview.tryton.org/45751002/diff/40001/modules/url_shortener/routes.py#newcode22 modules/url_shortener/routes.py:22: shortened_url = URLRepository(url._expand(shortened)) On 2018/10/17 17:44:24, ced wrote: > ...
1 month ago (2018-10-18 16:28:17 UTC) #15
ced
https://codereview.tryton.org/45751002/diff/40001/modules/url_shortener/routes.py File modules/url_shortener/routes.py (right): https://codereview.tryton.org/45751002/diff/40001/modules/url_shortener/routes.py#newcode22 modules/url_shortener/routes.py:22: shortened_url = URLRepository(url._expand(shortened)) On 2018/10/18 16:28:16, nicoe wrote: > ...
1 month ago (2018-10-18 17:18:49 UTC) #16
ced
Missing an issue reference.
1 month ago (2018-10-18 17:19:14 UTC) #17
nicoe
Fix remarks & add trigger function on marketing scenarios
1 month ago (2018-10-18 17:24:10 UTC) #18
nicoe
Reverted index.rst change
1 month ago (2018-10-18 17:25:25 UTC) #19
reviewbot
https://codereview.tryton.org/45751002/diff/100001/modules/marketing_automation/setup.py#newcode61 modules/marketing_automation/setup.py:61: E501 line too long (83 > 79 characters) https://codereview.tryton.org/45751002/diff/100001/modules/marketing_automation/setup.py#newcode71 modules/marketing_automation/setup.py:71: E501 line too ...
1 month ago (2018-10-18 18:03:33 UTC) #20
ced
Missing readthedocs https://codereview.tryton.org/45751002/diff/100001/modules/web_shortener/routes.py File modules/web_shortener/routes.py (right): https://codereview.tryton.org/45751002/diff/100001/modules/web_shortener/routes.py#newcode15 modules/web_shortener/routes.py:15: logger = logging.getLogger(__name__) not used https://codereview.tryton.org/45751002/diff/100001/modules/web_shortener/routes.py#newcode25 modules/web_shortener/routes.py:25: ...
4 weeks, 1 day ago (2018-10-19 09:59:08 UTC) #21
nicoe
https://codereview.tryton.org/45751002/diff/100001/modules/web_shortener/routes.py File modules/web_shortener/routes.py (right): https://codereview.tryton.org/45751002/diff/100001/modules/web_shortener/routes.py#newcode15 modules/web_shortener/routes.py:15: logger = logging.getLogger(__name__) On 2018/10/19 09:59:08, ced wrote: > ...
4 weeks, 1 day ago (2018-10-19 12:04:07 UTC) #22
ced
https://codereview.tryton.org/45751002/diff/100001/modules/web_shortener/routes.py File modules/web_shortener/routes.py (right): https://codereview.tryton.org/45751002/diff/100001/modules/web_shortener/routes.py#newcode25 modules/web_shortener/routes.py:25: shortened_url = ShortenedURL(web._expand(shortened)) On 2018/10/19 12:04:06, nicoe wrote: > ...
4 weeks, 1 day ago (2018-10-19 13:08:07 UTC) #23
nicoe
More fixes on URLShortener
4 weeks, 1 day ago (2018-10-19 17:01:32 UTC) #24
nicoe
https://codereview.tryton.org/45751002/diff/100001/modules/web_shortener/web.py File modules/web_shortener/web.py (right): https://codereview.tryton.org/45751002/diff/100001/modules/web_shortener/web.py#newcode102 modules/web_shortener/web.py:102: self.record, self.parameter) On 2018/10/19 13:08:06, ced wrote: > On ...
4 weeks, 1 day ago (2018-10-19 17:01:59 UTC) #25
reviewbot
https://codereview.tryton.org/45751002/diff/120001/modules/marketing_automation/setup.py#newcode61 modules/marketing_automation/setup.py:61: E501 line too long (83 > 79 characters) https://codereview.tryton.org/45751002/diff/120001/modules/marketing_automation/setup.py#newcode71 modules/marketing_automation/setup.py:71: E501 line too ...
4 weeks, 1 day ago (2018-10-19 17:33:44 UTC) #26
ced
https://codereview.tryton.org/45751002/diff/120001/modules/marketing_automation/marketing.py File modules/marketing_automation/marketing.py (right): https://codereview.tryton.org/45751002/diff/120001/modules/marketing_automation/marketing.py#newcode24 modules/marketing_automation/marketing.py:24: model = fields.Many2One('ir.model', "Model", required=True) I think it is ...
3 weeks, 1 day ago (2018-10-26 08:07:23 UTC) #27
nicoe
https://codereview.tryton.org/45751002/diff/120001/modules/marketing_automation/marketing.py File modules/marketing_automation/marketing.py (right): https://codereview.tryton.org/45751002/diff/120001/modules/marketing_automation/marketing.py#newcode24 modules/marketing_automation/marketing.py:24: model = fields.Many2One('ir.model', "Model", required=True) On 2018/10/26 08:07:22, ced ...
3 weeks, 1 day ago (2018-10-26 12:57:16 UTC) #28
nicoe
https://codereview.tryton.org/45751002/diff/120001/modules/web_shortener/web.py File modules/web_shortener/web.py (right): https://codereview.tryton.org/45751002/diff/120001/modules/web_shortener/web.py#newcode32 modules/web_shortener/web.py:32: method = fields.Selection([], "Method", readonly=True) On 2018/10/26 08:07:22, ced ...
3 weeks, 1 day ago (2018-10-26 16:49:40 UTC) #29
nicoe
Fixe remarks & generate record activities / activities
3 weeks, 1 day ago (2018-10-26 16:49:50 UTC) #30
reviewbot
https://codereview.tryton.org/45751002/diff/140001/modules/marketing_automation/setup.py#newcode61 modules/marketing_automation/setup.py:61: E501 line too long (83 > 79 characters) https://codereview.tryton.org/45751002/diff/140001/modules/marketing_automation/setup.py#newcode71 modules/marketing_automation/setup.py:71: E501 line too ...
3 weeks, 1 day ago (2018-10-26 16:58:41 UTC) #31
ced
https://codereview.tryton.org/45751002/diff/120001/modules/marketing_automation/marketing.py File modules/marketing_automation/marketing.py (right): https://codereview.tryton.org/45751002/diff/120001/modules/marketing_automation/marketing.py#newcode24 modules/marketing_automation/marketing.py:24: model = fields.Many2One('ir.model', "Model", required=True) On 2018/10/26 12:57:16, nicoe ...
3 weeks ago (2018-10-27 11:52:15 UTC) #32
nicoe
Fixe remarks
2 weeks, 5 days ago (2018-10-29 16:24:46 UTC) #33
reviewbot
https://codereview.tryton.org/45751002/diff/160001/modules/marketing_automation/setup.py#newcode61 modules/marketing_automation/setup.py:61: E501 line too long (83 > 79 characters) https://codereview.tryton.org/45751002/diff/160001/modules/marketing_automation/setup.py#newcode71 modules/marketing_automation/setup.py:71: E501 line too ...
2 weeks, 5 days ago (2018-10-29 16:48:10 UTC) #34
nicoe
Fix view & urlunsplit call
2 weeks, 5 days ago (2018-10-29 16:58:06 UTC) #35
nicoe
https://codereview.tryton.org/45751002/diff/140001/modules/marketing_automation/marketing.py File modules/marketing_automation/marketing.py (right): https://codereview.tryton.org/45751002/diff/140001/modules/marketing_automation/marketing.py#newcode91 modules/marketing_automation/marketing.py:91: ('model', 'in', cls._get_models()), On 2018/10/27 11:52:14, ced wrote: > ...
2 weeks, 5 days ago (2018-10-29 17:03:46 UTC) #36
reviewbot
https://codereview.tryton.org/45751002/diff/180001/modules/marketing_automation/setup.py#newcode61 modules/marketing_automation/setup.py:61: E501 line too long (83 > 79 characters) https://codereview.tryton.org/45751002/diff/180001/modules/marketing_automation/setup.py#newcode71 modules/marketing_automation/setup.py:71: E501 line too ...
2 weeks, 5 days ago (2018-10-29 17:24:37 UTC) #37
ced
https://codereview.tryton.org/45751002/diff/140001/modules/marketing_automation/marketing.py File modules/marketing_automation/marketing.py (right): https://codereview.tryton.org/45751002/diff/140001/modules/marketing_automation/marketing.py#newcode339 modules/marketing_automation/marketing.py:339: activity_condition = fields.Boolean("Activity Condition", required=True) On 2018/10/29 17:03:45, nicoe ...
2 weeks, 5 days ago (2018-10-29 17:27:50 UTC) #38
nicoe
https://codereview.tryton.org/45751002/diff/140001/modules/marketing_automation/marketing.py File modules/marketing_automation/marketing.py (right): https://codereview.tryton.org/45751002/diff/140001/modules/marketing_automation/marketing.py#newcode339 modules/marketing_automation/marketing.py:339: activity_condition = fields.Boolean("Activity Condition", required=True) On 2018/10/29 17:27:50, ced ...
2 weeks, 4 days ago (2018-10-30 08:30:15 UTC) #39
ced
https://codereview.tryton.org/45751002/diff/140001/modules/marketing_automation/marketing.py File modules/marketing_automation/marketing.py (right): https://codereview.tryton.org/45751002/diff/140001/modules/marketing_automation/marketing.py#newcode150 modules/marketing_automation/marketing.py:150: parent_condition = fields.Boolean("Parent Condition", On 2018/10/29 17:03:46, nicoe wrote: ...
2 weeks, 4 days ago (2018-10-30 09:07:15 UTC) #40
nicoe
Add views & fix remarks
2 weeks, 4 days ago (2018-10-30 18:04:37 UTC) #41
reviewbot
2 weeks, 4 days ago (2018-10-30 18:24:50 UTC) #42
https://codereview.tryton.org/45751002/diff/200001/modules/marketing_automati...
modules/marketing_automation/setup.py:61:
E501 line too long (83 > 79 characters)

https://codereview.tryton.org/45751002/diff/200001/modules/marketing_automati...
modules/marketing_automation/setup.py:71:
E501 line too long (80 > 79 characters)

https://codereview.tryton.org/45751002/diff/200001/modules/marketing_automati...
modules/marketing_automation/setup.py:85:
E501 line too long (85 > 79 characters)

https://codereview.tryton.org/45751002/diff/200001/modules/marketing_automati...
modules/marketing_automation/tests/__init__.py:5:
E501 line too long (90 > 79 characters)

https://codereview.tryton.org/45751002/diff/200001/modules/web_shortener/__in...
modules/web_shortener/__init__.py:7:
F401 'routes' imported but unused

https://codereview.tryton.org/45751002/diff/200001/modules/web_shortener/setu...
modules/web_shortener/setup.py:84:
E501 line too long (85 > 79 characters)

https://codereview.tryton.org/45751002/diff/200001/modules/web_shortener/web....
modules/web_shortener/web.py:24:
E302 expected 2 blank lines, found 0

https://codereview.tryton.org/45751002/diff/200001/trytond/trytond/wsgi.py#ne...
trytond/trytond/wsgi.py:167:
F401 'trytond' imported but unused

https://codereview.tryton.org/45751002/diff/200001/trytond/trytond/wsgi.py#ne...
trytond/trytond/wsgi.py:166:
E402 module level import not at top of file

https://codereview.tryton.org/45751002/diff/200001/trytond/trytond/wsgi.py#ne...
trytond/trytond/wsgi.py:167:
E402 module level import not at top of file

URL: https://codereview.tryton.org/45751002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766