Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(362)

Issue 45801002: goocalendar: Add minimal height for event box

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 1 day ago by pokoli
Modified:
1 week, 4 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

bug19

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M goocalendar/_calendar.py View 1 chunk +2 lines, -1 line 5 comments Download

Messages

Total messages: 7
pokoli
2 weeks, 1 day ago (2018-11-02 11:58:23 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/45801002
2 weeks, 1 day ago (2018-11-02 11:58:44 UTC) #2
ced
I think it will be good to add such small event in example. https://codereview.tryton.org/45801002/diff/1/goocalendar/_calendar.py File ...
2 weeks, 1 day ago (2018-11-02 17:03:22 UTC) #3
pokoli
> I think it will be good to add such small event in example. There ...
2 weeks, 1 day ago (2018-11-02 17:07:22 UTC) #4
ced
https://codereview.tryton.org/45801002/diff/1/goocalendar/_calendar.py File goocalendar/_calendar.py (right): https://codereview.tryton.org/45801002/diff/1/goocalendar/_calendar.py#newcode705 goocalendar/_calendar.py:705: event_item.height = max(20, y_off2) On 2018/11/02 17:07:22, pokoli wrote: ...
2 weeks, 1 day ago (2018-11-02 17:29:56 UTC) #5
pokoli
https://codereview.tryton.org/45801002/diff/1/goocalendar/_calendar.py File goocalendar/_calendar.py (right): https://codereview.tryton.org/45801002/diff/1/goocalendar/_calendar.py#newcode705 goocalendar/_calendar.py:705: event_item.height = max(20, y_off2) On 2018/11/02 17:29:56, ced wrote: ...
1 week, 4 days ago (2018-11-06 17:43:25 UTC) #6
ced
1 week, 4 days ago (2018-11-06 18:48:07 UTC) #7
https://codereview.tryton.org/45801002/diff/1/goocalendar/_calendar.py
File goocalendar/_calendar.py (right):

https://codereview.tryton.org/45801002/diff/1/goocalendar/_calendar.py#newcod...
goocalendar/_calendar.py:705: event_item.height = max(20, y_off2)
On 2018/11/06 17:43:25, pokoli wrote:
> On 2018/11/02 17:29:56, ced wrote:
> > On 2018/11/02 17:07:22, pokoli wrote:
> > > On 2018/11/02 17:03:22, ced wrote:
> > > > Where does 20 come from?
> > > 
> > > It's the minimum to be able to show the text of the event. 
> > 
> > But it should depend of the font size, no?
> 
> But how I know the font size that the user is using?

I do not know. Maybe goocanvas use relative size?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766