Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1241)

Issue 45831002: tryton-env: Add domain inversion for reference fields (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months ago by pokoli
Modified:
1 month, 1 week ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update to tip and fix comments #

Total comments: 4

Patch Set 3 : ADd test for multiple dots #

Patch Set 4 : Count dots instead of removing .id #

Total comments: 1

Patch Set 5 : Use split instead of regexp #

Total comments: 1

Patch Set 6 : Remove unused regexp #

Patch Set 7 : update to tip and reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -12 lines) Patch
M sao/CHANGELOG View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M sao/src/common.js View 1 2 3 4 5 6 1 chunk +15 lines, -6 lines 0 comments Download
M sao/tests/sao.js View 1 2 6 1 chunk +4 lines, -0 lines 0 comments Download
M tryton/CHANGELOG View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M tryton/tryton/common/domain_inversion.py View 1 2 3 6 3 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 23
pokoli
6 months ago (2018-11-22 16:10:11 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/45831002
6 months ago (2018-11-22 16:18:49 UTC) #2
ced
https://codereview.tryton.org/45831002/diff/1/sao/src/common.js File sao/src/common.js (right): https://codereview.tryton.org/45831002/diff/1/sao/src/common.js#newcode2275 sao/src/common.js:2275: (domain.length == 1)) { Maybe domain could be expanded ...
2 months, 1 week ago (2019-03-10 16:34:14 UTC) #3
pokoli
Update to tip and fix comments
2 months, 1 week ago (2019-03-15 15:36:53 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/45831002
2 months, 1 week ago (2019-03-15 15:40:06 UTC) #5
ced
https://codereview.tryton.org/45831002/diff/279091002/sao/src/common.js File sao/src/common.js (right): https://codereview.tryton.org/45831002/diff/279091002/sao/src/common.js#newcode2346 sao/src/common.js:2346: if (domain.length == 4 && name.endsWith('.id')) { I think ...
2 months ago (2019-03-20 22:53:13 UTC) #6
pokoli
ADd test for multiple dots
2 months ago (2019-03-21 14:29:20 UTC) #7
pokoli
https://codereview.tryton.org/45831002/diff/279091002/sao/src/common.js File sao/src/common.js (right): https://codereview.tryton.org/45831002/diff/279091002/sao/src/common.js#newcode2346 sao/src/common.js:2346: if (domain.length == 4 && name.endsWith('.id')) { On 2019/03/20 ...
2 months ago (2019-03-21 14:29:37 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/45831002
2 months ago (2019-03-21 14:42:02 UTC) #9
ced
https://codereview.tryton.org/45831002/diff/279091002/sao/src/common.js File sao/src/common.js (right): https://codereview.tryton.org/45831002/diff/279091002/sao/src/common.js#newcode2346 sao/src/common.js:2346: if (domain.length == 4 && name.endsWith('.id')) { On 2019/03/21 ...
2 months ago (2019-03-21 14:53:57 UTC) #10
pokoli
Count dots instead of removing .id
1 month, 3 weeks ago (2019-03-31 10:02:07 UTC) #11
reviewbot
patch is not applicable URL: https://codereview.tryton.org/45831002
1 month, 3 weeks ago (2019-03-31 10:12:58 UTC) #12
ced
https://codereview.tryton.org/45831002/diff/263201002/sao/src/common.js File sao/src/common.js (right): https://codereview.tryton.org/45831002/diff/263201002/sao/src/common.js#newcode2353 sao/src/common.js:2353: if ((name.match(regexp) || []).length == count && I do ...
1 month, 2 weeks ago (2019-04-02 21:59:43 UTC) #13
pokoli
Use split instead of regexp
1 month, 1 week ago (2019-04-10 16:33:09 UTC) #14
reviewbot
patch is not applicable URL: https://codereview.tryton.org/45831002
1 month, 1 week ago (2019-04-10 16:42:54 UTC) #15
ced
https://codereview.tryton.org/45831002/diff/279221002/sao/src/common.js File sao/src/common.js (right): https://codereview.tryton.org/45831002/diff/279221002/sao/src/common.js#newcode2352 sao/src/common.js:2352: var regexp = new RegExp('\\.', 'g'); it is not ...
1 month, 1 week ago (2019-04-11 11:53:21 UTC) #16
pokoli
Remove unused regexp
1 month, 1 week ago (2019-04-11 12:37:22 UTC) #17
pokoli
update to tip and reupload
1 month, 1 week ago (2019-04-11 12:39:49 UTC) #18
reviewbot
flake8 OK URL: https://codereview.tryton.org/45831002
1 month, 1 week ago (2019-04-11 13:16:09 UTC) #19
ced
LGTM
1 month, 1 week ago (2019-04-12 17:49:47 UTC) #20
rietveld-bot_tryton.org
New changeset 235955d39ba9 by Sergi Almacellas Abellana in branch 'default': Add domain inversion for reference ...
1 month, 1 week ago (2019-04-14 12:18:24 UTC) #21
rietveld-bot_tryton.org
New changeset ea8dd19e5913 by Sergi Almacellas Abellana in branch 'default': Add domain inversion for reference ...
1 month, 1 week ago (2019-04-14 12:18:29 UTC) #22
rietveld-bot_tryton.org
1 month, 1 week ago (2019-04-14 12:18:32 UTC) #23
New changeset a589d24d937c by Sergi Almacellas Abellana in branch 'default':
Add domain inversion for reference fields
https://hg.tryton.org/tryton-env/rev/a589d24d937c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766