Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(553)

Issue 45861002: trytond: Remove actual stopped self from the transactions stack (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks ago by ced
Modified:
4 days, 9 hours ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Stopping non-current transaction should not remove the last transaction but itself. issue7973

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M trytond/transaction.py View 1 chunk +5 lines, -2 lines 2 comments Download

Messages

Total messages: 6
ced
2 weeks ago (2019-01-07 17:53:12 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/45861002
2 weeks ago (2019-01-07 18:07:55 UTC) #2
pokoli
https://codereview.tryton.org/45861002/diff/1/trytond/transaction.py File trytond/transaction.py (right): https://codereview.tryton.org/45861002/diff/1/trytond/transaction.py#newcode155 trytond/transaction.py:155: transactions.reverse() Why reversing and then undoing the reverse?
1 week, 3 days ago (2019-01-11 17:51:51 UTC) #3
ced
https://codereview.tryton.org/45861002/diff/1/trytond/transaction.py File trytond/transaction.py (right): https://codereview.tryton.org/45861002/diff/1/trytond/transaction.py#newcode155 trytond/transaction.py:155: transactions.reverse() On 2019/01/11 17:51:51, pokoli wrote: > Why reversing ...
1 week, 3 days ago (2019-01-11 18:33:00 UTC) #4
rietveld-bot_tryton.org
New changeset 677c4fc1c843 by Cédric Krier in branch 'default': Remove actual stopped self from the ...
4 days, 9 hours ago (2019-01-17 16:13:45 UTC) #5
rietveld-bot_tryton.org
4 days, 9 hours ago (2019-01-17 16:13:53 UTC) #6
New changeset 36e666e80791 by Cédric Krier in branch 'default':
Remove actual stopped self from the transactions stack
https://hg.tryton.org/tryton-env/rev/36e666e80791
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766