Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 46431002: account_asset: Allow to set when the depreciation move should be created (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by pokoli
Modified:
3 weeks, 3 days ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Set depreciation moves as a company configuration #

Patch Set 3 : Use selection field and remove domain from multivalue field #

Total comments: 13

Patch Set 4 : Fix comments #

Total comments: 2

Patch Set 5 : Fix comments #

Total comments: 6

Patch Set 6 : Use selection for month, add defaults and update docs #

Total comments: 3

Patch Set 7 : Fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -5 lines) Patch
M CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M __init__.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M account.py View 1 2 3 4 5 6 3 chunks +56 lines, -2 lines 0 comments Download
M asset.py View 1 2 3 4 5 2 chunks +7 lines, -2 lines 0 comments Download
M doc/index.rst View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M view/configuration_form.xml View 1 2 3 4 5 6 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 27
pokoli
2 months, 2 weeks ago (2018-05-09 15:15:26 UTC) #1
reviewbot
https://codereview.tryton.org/46431002/diff/1/asset.py#newcode49 asset.py:49: E711 comparison to None should be 'if cond is None:' https://codereview.tryton.org/46431002/diff/1/asset.py#newcode938 asset.py:938: E731 ...
2 months, 2 weeks ago (2018-05-09 15:15:39 UTC) #2
ced
https://codereview.tryton.org/46431002/diff/1/asset.py File asset.py (right): https://codereview.tryton.org/46431002/diff/1/asset.py#newcode369 asset.py:369: bymonthday=self.bymonthday or -1) For me, it should be: (self.bymonthday ...
2 months, 1 week ago (2018-05-10 16:00:54 UTC) #3
pokoli
Set depreciation moves as a company configuration
2 months ago (2018-05-17 14:28:16 UTC) #4
pokoli
https://codereview.tryton.org/46431002/diff/1/asset.py File asset.py (right): https://codereview.tryton.org/46431002/diff/1/asset.py#newcode369 asset.py:369: bymonthday=self.bymonthday or -1) On 2018/05/10 16:00:53, ced wrote: > ...
2 months ago (2018-05-17 14:28:50 UTC) #5
reviewbot
https://codereview.tryton.org/46431002/diff/20001/asset.py#newcode49 asset.py:49: E711 comparison to None should be 'if cond is None:' https://codereview.tryton.org/46431002/diff/20001/asset.py#newcode917 asset.py:917: E731 ...
2 months ago (2018-05-17 14:42:43 UTC) #6
ced
https://codereview.tryton.org/46431002/diff/1/asset.py File asset.py (right): https://codereview.tryton.org/46431002/diff/1/asset.py#newcode369 asset.py:369: bymonthday=self.bymonthday or -1) On 2018/05/17 14:28:50, pokoli wrote: > ...
2 months ago (2018-05-17 15:00:14 UTC) #7
pokoli
https://codereview.tryton.org/46431002/diff/1/asset.py File asset.py (right): https://codereview.tryton.org/46431002/diff/1/asset.py#newcode369 asset.py:369: bymonthday=self.bymonthday or -1) On 2018/05/17 15:00:14, ced wrote: > ...
2 months ago (2018-05-17 15:30:38 UTC) #8
ced
https://codereview.tryton.org/46431002/diff/1/asset.py File asset.py (right): https://codereview.tryton.org/46431002/diff/1/asset.py#newcode369 asset.py:369: bymonthday=self.bymonthday or -1) On 2018/05/17 15:30:38, pokoli wrote: > ...
2 months ago (2018-05-17 15:59:04 UTC) #9
ced
https://codereview.tryton.org/46431002/diff/1/asset.py File asset.py (right): https://codereview.tryton.org/46431002/diff/1/asset.py#newcode369 asset.py:369: bymonthday=self.bymonthday or -1) On 2018/05/17 15:59:03, ced wrote: > ...
1 month, 3 weeks ago (2018-05-28 21:17:42 UTC) #10
pokoli
Use selection field and remove domain from multivalue field
1 month, 3 weeks ago (2018-05-29 07:51:20 UTC) #11
reviewbot
https://codereview.tryton.org/46431002/diff/40001/asset.py#newcode49 asset.py:49: E711 comparison to None should be 'if cond is None:' https://codereview.tryton.org/46431002/diff/40001/asset.py#newcode917 asset.py:917: E731 ...
1 month, 3 weeks ago (2018-05-29 08:00:05 UTC) #12
ced
The doc could be updated. https://codereview.tryton.org/46431002/diff/40001/account.py File account.py (right): https://codereview.tryton.org/46431002/diff/40001/account.py#newcode32 account.py:32: asset_bymonth = fields.MultiValue(fields.Integer("Aseet Move ...
1 month, 2 weeks ago (2018-06-06 07:06:15 UTC) #13
pokoli
Fix comments
1 month, 2 weeks ago (2018-06-06 14:10:23 UTC) #14
pokoli
https://codereview.tryton.org/46431002/diff/40001/account.py File account.py (right): https://codereview.tryton.org/46431002/diff/40001/account.py#newcode32 account.py:32: asset_bymonth = fields.MultiValue(fields.Integer("Aseet Move Month", On 2018/06/06 07:06:15, ced ...
1 month, 2 weeks ago (2018-06-06 14:10:26 UTC) #15
ced
https://codereview.tryton.org/46431002/diff/40001/account.py File account.py (right): https://codereview.tryton.org/46431002/diff/40001/account.py#newcode32 account.py:32: asset_bymonth = fields.MultiValue(fields.Integer("Aseet Move Month", On 2018/06/06 14:10:25, pokoli ...
1 month, 2 weeks ago (2018-06-06 14:32:17 UTC) #16
reviewbot
https://codereview.tryton.org/46431002/diff/60001/asset.py#newcode49 asset.py:49: E711 comparison to None should be 'if cond is None:' https://codereview.tryton.org/46431002/diff/60001/asset.py#newcode917 asset.py:917: E731 ...
1 month, 2 weeks ago (2018-06-06 14:35:32 UTC) #17
pokoli
Fix comments
1 month, 2 weeks ago (2018-06-07 08:45:29 UTC) #18
reviewbot
https://codereview.tryton.org/46431002/diff/80001/asset.py#newcode49 asset.py:49: E711 comparison to None should be 'if cond is None:' https://codereview.tryton.org/46431002/diff/80001/asset.py#newcode917 asset.py:917: E731 ...
1 month, 2 weeks ago (2018-06-07 09:00:33 UTC) #19
ced
https://codereview.tryton.org/46431002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/46431002/diff/80001/account.py#newcode16 account.py:16: ], "Asset Move Month day", Should it not be ...
1 month, 2 weeks ago (2018-06-08 06:59:02 UTC) #20
pokoli
Use selection for month, add defaults and update docs
1 month, 1 week ago (2018-06-11 10:46:46 UTC) #21
reviewbot
https://codereview.tryton.org/46431002/diff/100001/asset.py#newcode49 asset.py:49: E711 comparison to None should be 'if cond is None:' https://codereview.tryton.org/46431002/diff/100001/asset.py#newcode917 asset.py:917: E731 ...
1 month, 1 week ago (2018-06-11 10:52:47 UTC) #22
ced
https://codereview.tryton.org/46431002/diff/100001/account.py File account.py (right): https://codereview.tryton.org/46431002/diff/100001/account.py#newcode15 account.py:15: ("-1", 'Last'), Usually we use single quote for code ...
1 month ago (2018-06-22 09:09:14 UTC) #23
pokoli
Fix comments
1 month ago (2018-06-22 11:46:03 UTC) #24
reviewbot
https://codereview.tryton.org/46431002/diff/120001/asset.py#newcode49 asset.py:49: E711 comparison to None should be 'if cond is None:' https://codereview.tryton.org/46431002/diff/120001/asset.py#newcode917 asset.py:917: E731 ...
1 month ago (2018-06-22 12:04:42 UTC) #25
ced
LGTM
4 weeks ago (2018-06-25 09:18:44 UTC) #26
rietveld-bot_tryton.org
3 weeks, 3 days ago (2018-06-29 07:43:37 UTC) #27
New changeset 3bb9cca8f431 by Sergi Almacellas Abellana in branch 'default':
Allow to set when the depreciation move should be created
https://hg.tryton.org/modules/account_asset/rev/3bb9cca8f431
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69