Issue 46471002: analytic_invoice: Add company domain on asset analytic accounts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 46471002: analytic_invoice: Add company domain on asset analytic accounts

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 months ago by pokoli

Modified:
8 months ago

Reviewers:
ced, reviewbot

Visibility:
Public.

More Reviews

Patch Set 2 : Add company domain on asset analytic lines #

Total comments: 1

Patch Set 3 : Add default integer value on company eval #

Total comments: 1

Created: 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	asset.py	View	1 2	2 chunks	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

ced

https://codereview.tryton.org/46471002/diff/1/invoice.py File invoice.py (right): https://codereview.tryton.org/46471002/diff/1/invoice.py#newcode17 invoice.py:17: analytic_company = fields.Function(fields.Many2One( In account_invoice, there is already a ...

8 months ago (2018-05-23 21:44:01 UTC) #3

ced

https://codereview.tryton.org/46471002/diff/20001/asset.py File asset.py (right): https://codereview.tryton.org/46471002/diff/20001/asset.py#newcode20 asset.py:20: ('company', '=', Eval('company')), Eval should have a integer as ...

8 months ago (2018-05-24 08:32:32 UTC) #5

ced

https://codereview.tryton.org/46471002/diff/40001/asset.py File asset.py (right): https://codereview.tryton.org/46471002/diff/40001/asset.py#newcode22 asset.py:22: cls.analytic_accounts.depends.append('company') Should not we have a on_change_company to remove ...

8 months ago (2018-05-24 09:14:33 UTC) #8

flake8 OK
URL: https://codereview.tryton.org/46471002

Expand All Messages | Collapse All Messages