Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 46471002: analytic_invoice: Add company domain on asset analytic accounts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by pokoli
Modified:
2 years, 9 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add company domain on asset analytic lines #

Total comments: 1

Patch Set 3 : Add default integer value on company eval #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M asset.py View 1 2 2 chunks +9 lines, -0 lines 2 comments Download

Messages

Total messages: 13
pokoli
4 years, 8 months ago (2018-05-21 10:02:12 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/46471002
4 years, 8 months ago (2018-05-21 10:20:01 UTC) #2
ced
https://codereview.tryton.org/46471002/diff/1/invoice.py File invoice.py (right): https://codereview.tryton.org/46471002/diff/1/invoice.py#newcode17 invoice.py:17: analytic_company = fields.Function(fields.Many2One( In account_invoice, there is already a ...
4 years, 8 months ago (2018-05-23 21:44:01 UTC) #3
pokoli
Add company domain on asset analytic lines
4 years, 8 months ago (2018-05-24 08:26:31 UTC) #4
ced
https://codereview.tryton.org/46471002/diff/20001/asset.py File asset.py (right): https://codereview.tryton.org/46471002/diff/20001/asset.py#newcode20 asset.py:20: ('company', '=', Eval('company')), Eval should have a integer as ...
4 years, 8 months ago (2018-05-24 08:32:32 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/46471002
4 years, 8 months ago (2018-05-24 08:49:24 UTC) #6
pokoli
Add default integer value on company eval
4 years, 8 months ago (2018-05-24 08:50:58 UTC) #7
ced
https://codereview.tryton.org/46471002/diff/40001/asset.py File asset.py (right): https://codereview.tryton.org/46471002/diff/40001/asset.py#newcode22 asset.py:22: cls.analytic_accounts.depends.append('company') Should not we have a on_change_company to remove ...
4 years, 8 months ago (2018-05-24 09:14:33 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/46471002
4 years, 8 months ago (2018-05-24 09:21:42 UTC) #9
ced
LGTM https://codereview.tryton.org/46471002/diff/40001/asset.py File asset.py (right): https://codereview.tryton.org/46471002/diff/40001/asset.py#newcode22 asset.py:22: cls.analytic_accounts.depends.append('company') On 2018/05/24 09:14:33, ced wrote: > Should ...
2 years, 9 months ago (2020-04-17 15:52:39 UTC) #10
rietveld-bot_tryton.org
New changeset 23df221a67f3 by Sergi Almacellas Abellana in branch 'default': Add company domain on asset ...
2 years, 9 months ago (2020-04-18 15:45:02 UTC) #11
rietveld-bot_tryton.org
New changeset b0b9a02023e8 by Sergi Almacellas Abellana in branch 'default': Add company domain on asset ...
2 years, 9 months ago (2020-04-18 15:45:06 UTC) #12
rietveld-bot_tryton.org
2 years, 9 months ago (2020-04-25 10:55:47 UTC) #13
New changeset e7c0b6446e17 by Sergi Almacellas Abellana in branch '5.4':
Add company domain on asset analytic accounts
https://hg.tryton.org/modules/analytic_invoice/rev/e7c0b6446e17


New changeset 95e207047ded by Sergi Almacellas Abellana in branch '5.2':
Add company domain on asset analytic accounts
https://hg.tryton.org/modules/analytic_invoice/rev/95e207047ded


New changeset 56d673829a7e by Sergi Almacellas Abellana in branch '5.0':
Add company domain on asset analytic accounts
https://hg.tryton.org/modules/analytic_invoice/rev/56d673829a7e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted