analytic_invoice: Add company domain on asset analytic accounts

issue7198

[reviewbot, 2018-05-21 10:20:01]

flake8 OK
URL: https://codereview.tryton.org/46471002

[ced, 2018-05-23 21:44:01]

https://codereview.tryton.org/46471002/diff/1/invoice.py
File invoice.py (right):

https://codereview.tryton.org/46471002/diff/1/invoice.py#newcode17
invoice.py:17: analytic_company = fields.Function(fields.Many2One(
In account_invoice, there is already a company domain for account, I think we
should use the same instead of adding one more field.

[pokoli, 2018-05-24 08:26:31]

Add company domain on asset analytic lines

[ced, 2018-05-24 08:32:32]

https://codereview.tryton.org/46471002/diff/20001/asset.py
File asset.py (right):

https://codereview.tryton.org/46471002/diff/20001/asset.py#newcode20
asset.py:20: ('company', '=', Eval('company')),
Eval should have a integer as default, -1

[reviewbot, 2018-05-24 08:49:24]

flake8 OK
URL: https://codereview.tryton.org/46471002

[pokoli, 2018-05-24 08:50:58]

Add default integer value on company eval

[ced, 2018-05-24 09:14:33]

https://codereview.tryton.org/46471002/diff/40001/asset.py
File asset.py (right):

https://codereview.tryton.org/46471002/diff/40001/asset.py#newcode22
asset.py:22: cls.analytic_accounts.depends.append('company')
Should not we have a on_change_company to remove analytic_accounts if it is no
more valid?

[reviewbot, 2018-05-24 09:21:42]

flake8 OK
URL: https://codereview.tryton.org/46471002

[ced, 2020-04-17 15:52:39]

LGTM

https://codereview.tryton.org/46471002/diff/40001/asset.py
File asset.py (right):

https://codereview.tryton.org/46471002/diff/40001/asset.py#newcode22
asset.py:22: cls.analytic_accounts.depends.append('company')
On 2018/05/24 09:14:33, ced wrote:
> Should not we have a on_change_company to remove analytic_accounts if it is no
> more valid?

Indeed we do not have such thing for other document.

[rietveld-bot_tryton.org, 2020-04-18 15:45:02]

New changeset 23df221a67f3 by Sergi Almacellas Abellana in branch 'default':
Add company domain on asset analytic accounts
https://hg.tryton.org/modules/analytic_invoice/rev/23df221a67f3

[rietveld-bot_tryton.org, 2020-04-18 15:45:06]

New changeset b0b9a02023e8 by Sergi Almacellas Abellana in branch 'default':
Add company domain on asset analytic accounts
https://hg.tryton.org/tryton-env/rev/b0b9a02023e8

[rietveld-bot_tryton.org, 2020-04-25 10:55:47]

New changeset e7c0b6446e17 by Sergi Almacellas Abellana in branch '5.4':
Add company domain on asset analytic accounts
https://hg.tryton.org/modules/analytic_invoice/rev/e7c0b6446e17


New changeset 95e207047ded by Sergi Almacellas Abellana in branch '5.2':
Add company domain on asset analytic accounts
https://hg.tryton.org/modules/analytic_invoice/rev/95e207047ded


New changeset 56d673829a7e by Sergi Almacellas Abellana in branch '5.0':
Add company domain on asset analytic accounts
https://hg.tryton.org/modules/analytic_invoice/rev/56d673829a7e