Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 46631002: tryton-env: Add stock quality inspection module

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by pokoli
Modified:
2 months, 3 weeks ago
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update to tip and add extra dependency with production #

Patch Set 3 : Add extra_depends #

Total comments: 4

Patch Set 4 : Update to tip #

Patch Set 5 : Improve access rights #

Patch Set 6 : Update to tip, add pattern selection and icons #

Total comments: 5

Patch Set 7 : Fix remarks, tests and update to tip #

Patch Set 8 : Update to tip and allow manual creation of inspections #

Patch Set 9 : Remove non needed test files #

Patch Set 10 : Update to tip #

Patch Set 11 : Remove __all__ attribute #

Patch Set 12 : Improve views #

Total comments: 6

Patch Set 13 : Fix remarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2607 lines, -0 lines) Patch
M .hgsub View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
A modules/stock_quality_inspection/.drone.yml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +78 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/.flake8 View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/.isort.cfg View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/COPYRIGHT View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +14 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/LICENSE View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +674 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/MANIFEST.in View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/README.rst View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
A modules/stock_quality_inspection/__init__.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +24 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/configuration.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +63 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/configuration.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +22 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/doc/conf.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +61 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/doc/design.rst View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +40 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/doc/index.rst View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +10 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/doc/releases.rst View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +7 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/doc/usage.rst View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +21 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/icons/LICENSE View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +202 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/icons/tryton-quality.svg View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
A modules/stock_quality_inspection/product.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +76 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/product.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +12 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/production.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +29 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/quality.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +304 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/quality.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +338 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/setup.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +157 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/stock.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +73 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/tests/__init__.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/tests/scenario_stock_quality_inspection.rst View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +142 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/tests/test_module.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +13 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/tests/test_scenario.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +22 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/tox.ini View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +17 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/tryton.cfg View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +12 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/view/configuration_form.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +7 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/view/control_form.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +17 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/view/control_selection_form.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +31 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/view/control_selection_list.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +13 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/view/control_selection_list_sequence.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +13 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/view/control_tree.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +7 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/view/inspection_form.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +35 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/view/inspection_tree.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +11 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/view/template_form.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +10 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/view/test_form.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +17 lines, -0 lines 0 comments Download
A modules/stock_quality_inspection/view/test_tree.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +8 lines, -0 lines 0 comments Download
M readthedocs/index.rst View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A readthedocs/quality.rst View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 28
pokoli
4 years, 6 months ago (2018-08-02 13:58:21 UTC) #1
reviewbot
https://codereview.tryton.org/46631002/diff/1/setup.py#newcode83 setup.py:83: E501 line too long (85 > 79 characters) https://codereview.tryton.org/46631002/diff/1/tests/__init__.py#newcode4 tests/__init__.py:4: E501 line too ...
4 years, 6 months ago (2018-08-02 13:59:51 UTC) #2
pokoli
Update to tip and add extra dependency with production
3 years, 9 months ago (2019-04-17 15:06:01 UTC) #3
pokoli
Add extra_depends
3 years, 9 months ago (2019-04-17 15:07:05 UTC) #4
reviewbot
https://codereview.tryton.org/46631002/diff/285131002/setup.py#newcode93 setup.py:93: E501 line too long (85 > 79 characters) https://codereview.tryton.org/46631002/diff/285131002/tests/__init__.py#newcode4 tests/__init__.py:4: E501 line too ...
3 years, 9 months ago (2019-04-17 15:11:04 UTC) #5
dave1
https://codereview.tryton.org/46631002/diff/285131002/INSTALL File INSTALL (right): https://codereview.tryton.org/46631002/diff/285131002/INSTALL#newcode1 INSTALL:1: Installing aritmos_quality_inspection Should this be trytond_quality_inspection? https://codereview.tryton.org/46631002/diff/285131002/INSTALL#newcode15 INSTALL:15: Once ...
3 years, 9 months ago (2019-04-19 12:02:07 UTC) #6
pokoli
Update to tip
1 year, 4 months ago (2021-09-20 09:23:10 UTC) #7
reviewbot
patch is not applicable URL: https://codereview.tryton.org/46631002
1 year, 4 months ago (2021-09-20 09:23:43 UTC) #8
pokoli
Improve access rights
1 year, 4 months ago (2021-09-20 09:44:44 UTC) #9
reviewbot
patch is not applicable URL: https://codereview.tryton.org/46631002
1 year, 4 months ago (2021-09-20 09:55:05 UTC) #10
pokoli
Update to tip, add pattern selection and icons
1 year, 2 months ago (2021-12-03 13:20:34 UTC) #11
reviewbot
https://codereview.tryton.org/46631002/diff/374391002/modules/quality_inspection/setup.py#newcode1 modules/quality_inspection/setup.py:1: TokenError: EOF in multi-line statement https://codereview.tryton.org/46631002/diff/374391002/modules/quality_inspection/setup.py#newcode18 modules/quality_inspection/setup.py:18: unexpected indentation https://codereview.tryton.org/46631002/diff/374391002/modules/quality_inspection/setup.py#newcode19 modules/quality_inspection/setup.py:19: missing whitespace ...
1 year, 2 months ago (2021-12-03 13:33:01 UTC) #12
vbastos
On 2021/12/03 13:20:34, pokoli wrote: > Update to tip, add pattern selection and icons For ...
1 year, 1 month ago (2021-12-08 10:42:12 UTC) #13
hodeinavarro
There are some field references that need to be updated to 'quality_controls' instead of 'controls'. ...
10 months, 3 weeks ago (2022-03-17 10:02:54 UTC) #14
pokoli
Fix remarks, tests and update to tip
10 months, 2 weeks ago (2022-03-21 16:01:15 UTC) #15
reviewbot
checks OK URL: https://codereview.tryton.org/46631002
10 months, 2 weeks ago (2022-03-21 16:05:53 UTC) #16
pokoli
Update to tip and allow manual creation of inspections
9 months, 2 weeks ago (2022-04-21 11:59:41 UTC) #17
reviewbot
ERROR: /tmp/reviewbot-vpq8jmk6/modules/quality_inspection/tests/tools.py Imports are incorrectly sorted and/or formatted. URL: https://codereview.tryton.org/46631002
9 months, 2 weeks ago (2022-04-21 12:37:20 UTC) #18
pokoli
Remove non needed test files
9 months, 2 weeks ago (2022-04-21 12:47:27 UTC) #19
reviewbot
checks OK URL: https://codereview.tryton.org/46631002
9 months, 2 weeks ago (2022-04-21 13:01:07 UTC) #20
pokoli
Update to tip
3 months, 3 weeks ago (2022-10-10 07:02:35 UTC) #21
pokoli
Remove __all__ attribute
3 months, 3 weeks ago (2022-10-10 07:11:34 UTC) #22
pokoli
Improve views
3 months, 3 weeks ago (2022-10-10 07:41:47 UTC) #23
reviewbot
checks OK URL: https://codereview.tryton.org/46631002
3 months, 3 weeks ago (2022-10-10 07:43:44 UTC) #24
ced
https://codereview.tryton.org/46631002/diff/427941003/.hgsub File .hgsub (right): https://codereview.tryton.org/46631002/diff/427941003/.hgsub#newcode130 .hgsub:130: modules/quality_inspection = modules/quality_inspection The module is deeply linked to ...
3 months, 3 weeks ago (2022-10-10 14:34:20 UTC) #25
pokoli
Fix remarks
2 months, 3 weeks ago (2022-11-07 09:45:44 UTC) #26
pokoli
https://codereview.tryton.org/46631002/diff/427941003/.hgsub File .hgsub (right): https://codereview.tryton.org/46631002/diff/427941003/.hgsub#newcode130 .hgsub:130: modules/quality_inspection = modules/quality_inspection On 2022/10/10 14:34:20, ced wrote: > ...
2 months, 3 weeks ago (2022-11-07 09:46:37 UTC) #27
reviewbot
2 months, 3 weeks ago (2022-11-07 09:56:00 UTC) #28
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted