Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 46691002: tryton-env: Add tab domain in url

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by xcodinas
Modified:
2 weeks ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove unused variable #

Patch Set 3 : add changelog #

Patch Set 4 : Merge both reviews #

Total comments: 1

Patch Set 5 : Put changelog entry on top #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M sao/CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M sao/src/sao.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M sao/src/screen.js View 1 2 3 1 chunk +4 lines, -0 lines 1 comment Download
M tryton/CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tryton/tryton/gui/main.py View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M tryton/tryton/gui/window/view_form/screen/screen.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13
xcodinas
1 month ago (2018-11-13 16:43:55 UTC) #1
reviewbot
https://codereview.tryton.org/46691002/diff/1/tryton/gui/main.py#newcode899 tryton/gui/main.py:899: F841 local variable 'e' is assigned to but never used URL: https://codereview.tryton.org/46691002
1 month ago (2018-11-13 17:12:06 UTC) #2
xcodinas
Remove unused variable
1 month ago (2018-11-14 08:00:04 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/46691002
1 month ago (2018-11-14 08:13:48 UTC) #4
ced
Missing changelog
4 weeks, 1 day ago (2018-11-19 21:02:00 UTC) #5
xcodinas
add changelog
4 weeks ago (2018-11-20 08:21:48 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/46691002
4 weeks ago (2018-11-20 08:34:34 UTC) #7
xcodinas
4 weeks ago (2018-11-20 14:50:35 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/46691002
4 weeks ago (2018-11-20 15:07:00 UTC) #9
pokoli
https://codereview.tryton.org/46691002/diff/60001/sao/CHANGELOG File sao/CHANGELOG (right): https://codereview.tryton.org/46691002/diff/60001/sao/CHANGELOG#newcode3 sao/CHANGELOG:3: * Add tab domain in url should be on ...
3 weeks, 5 days ago (2018-11-22 11:03:34 UTC) #10
xcodinas
3 weeks, 5 days ago (2018-11-22 11:22:47 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/46691002
3 weeks, 5 days ago (2018-11-22 11:41:41 UTC) #12
ced
2 weeks ago (2018-12-04 12:53:50 UTC) #13
https://codereview.tryton.org/46691002/diff/80001/sao/src/screen.js
File sao/src/screen.js (right):

https://codereview.tryton.org/46691002/diff/80001/sao/src/screen.js#newcode1821
sao/src/screen.js:1821: dumps(this.attributes.tab_domain)]);
I think it is more readable to break like in line 1814
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766