Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 46711002: tryton: Rely on editing property of renderer to set value (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ced
Modified:
1 month, 1 week ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

In Python3, the 'remove-widget' is not trigger when the selected row is changed. This makes the attribute editabletree_entry not reliable. Instead we should use the editing property of the renderer and manage the editable reference on the widget (which is a cleaner separation concept). This allows also to remove duplicate code in set_value by calling on_editing_done. issue7936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M tryton/gui/window/view_form/view/list_gtk/editabletree.py View 2 chunks +4 lines, -21 lines 0 comments Download
M tryton/gui/window/view_form/view/list_gtk/widget.py View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5
ced
2 months, 1 week ago (2019-01-11 12:56:15 UTC) #1
reviewbot
https://codereview.tryton.org/46711002/diff/1/tryton/gui/window/view_form/view/list_gtk/editabletree.py#newcode184 tryton/gui/window/view_form/view/list_gtk/editabletree.py:184: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/46711002
2 months, 1 week ago (2019-01-11 13:17:33 UTC) #2
rietveld-bot_tryton.org
New changeset 90eb14f40b6e by Cédric Krier in branch 'default': Rely on editing property of renderer ...
1 month, 2 weeks ago (2019-01-30 09:11:47 UTC) #3
rietveld-bot_tryton.org
New changeset 7b73ec8525bf by Cédric Krier in branch 'default': Rely on editing property of renderer ...
1 month, 2 weeks ago (2019-01-30 09:11:52 UTC) #4
rietveld-bot_tryton.org
1 month, 1 week ago (2019-02-10 22:51:00 UTC) #5
New changeset 45cdea8c7ee6 by Cédric Krier in branch '5.0':
Rely on editing property of renderer to set value
https://hg.tryton.org/tryton/rev/45cdea8c7ee6


New changeset 83726d19143a by Cédric Krier in branch '4.8':
Rely on editing property of renderer to set value
https://hg.tryton.org/tryton/rev/83726d19143a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766