Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(231)

Issue 46711002: tryton: Rely on editing property of renderer to set value

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by ced
Modified:
1 week, 3 days ago
Reviewers:
reviewbot
Visibility:
Public.

Description

In Python3, the 'remove-widget' is not trigger when the selected row is changed. This makes the attribute editabletree_entry not reliable. Instead we should use the editing property of the renderer and manage the editable reference on the widget (which is a cleaner separation concept). This allows also to remove duplicate code in set_value by calling on_editing_done. issue7936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M tryton/gui/window/view_form/view/list_gtk/editabletree.py View 2 chunks +4 lines, -21 lines 0 comments Download
M tryton/gui/window/view_form/view/list_gtk/widget.py View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2
ced
1 week, 3 days ago (2019-01-11 12:56:15 UTC) #1
reviewbot
1 week, 3 days ago (2019-01-11 13:17:33 UTC) #2
https://codereview.tryton.org/46711002/diff/1/tryton/gui/window/view_form/vie...
tryton/gui/window/view_form/view/list_gtk/editabletree.py:184:
E127 continuation line over-indented for visual indent

URL: https://codereview.tryton.org/46711002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766