Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(116)

Issue 46791002: tryton-env: Add sale_product_customer

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 weeks ago by mrichez
Modified:
5 days, 4 hours ago
Reviewers:
pokoli, reviewbot, ced, dave
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove useless message.xml #

Total comments: 15

Patch Set 3 : Improve doc following remarks #

Total comments: 18

Patch Set 4 : Applying last remarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1407 lines, -0 lines) Patch
M .hgsub View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale_product_customer/.drone.yml View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
A modules/sale_product_customer/COPYRIGHT View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
A modules/sale_product_customer/INSTALL View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A modules/sale_product_customer/LICENSE View 1 2 3 1 chunk +674 lines, -0 lines 0 comments Download
A modules/sale_product_customer/MANIFEST.in View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A modules/sale_product_customer/README View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A modules/sale_product_customer/__init__.py View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A modules/sale_product_customer/doc/index.rst View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
A modules/sale_product_customer/product.py View 1 2 3 1 chunk +102 lines, -0 lines 0 comments Download
A modules/sale_product_customer/product.xml View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
A modules/sale_product_customer/sale.py View 1 2 3 1 chunk +62 lines, -0 lines 0 comments Download
A modules/sale_product_customer/sale.xml View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download
A modules/sale_product_customer/setup.py View 1 2 3 1 chunk +123 lines, -0 lines 0 comments Download
A modules/sale_product_customer/tests/__init__.py View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A modules/sale_product_customer/tests/scenario_sale_product_customer.rst View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download
A modules/sale_product_customer/tests/test_sale_product_customer.py View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
A modules/sale_product_customer/tox.ini View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A modules/sale_product_customer/tryton.cfg View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/product_customer_form.xml View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/product_customer_tree.xml View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/product_customer_tree_sequence.xml View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/sale_line_form.xml View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/template_form.xml View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M readthedocs/sale.rst View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22
mrichez
4 weeks ago (2019-02-20 09:05:21 UTC) #1
reviewbot
https://codereview.tryton.org/46791002/diff/1/setup.py#newcode71 setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/1/setup.py#newcode85 setup.py:85: E501 line too ...
4 weeks ago (2019-02-20 09:13:47 UTC) #2
mrichez
Remove useless message.xml
4 weeks ago (2019-02-20 09:15:10 UTC) #3
reviewbot
https://codereview.tryton.org/46791002/diff/20001/setup.py#newcode71 setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/20001/setup.py#newcode85 setup.py:85: E501 line too ...
4 weeks ago (2019-02-20 09:35:58 UTC) #4
mrichez
Remove useless message.xml
4 weeks ago (2019-02-20 10:06:12 UTC) #5
reviewbot
https://codereview.tryton.org/46791002/diff/40001/setup.py#newcode71 setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/40001/setup.py#newcode85 setup.py:85: E501 line too ...
4 weeks ago (2019-02-20 10:17:52 UTC) #6
pokoli
https://codereview.tryton.org/46791002/diff/40001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/46791002/diff/40001/doc/index.rst#newcode4 doc/index.rst:4: The sale_product_customer module add to the sale line the ...
4 weeks ago (2019-02-20 12:56:35 UTC) #7
mrichez
https://codereview.tryton.org/46791002/diff/40001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/46791002/diff/40001/doc/index.rst#newcode4 doc/index.rst:4: The sale_product_customer module add to the sale line the ...
4 weeks ago (2019-02-20 14:27:54 UTC) #8
mrichez
https://codereview.tryton.org/46791002/diff/40001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/46791002/diff/40001/doc/index.rst#newcode4 doc/index.rst:4: The sale_product_customer module add to the sale line the ...
4 weeks ago (2019-02-20 14:51:41 UTC) #9
dave
https://codereview.tryton.org/46791002/diff/40001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/46791002/diff/40001/doc/index.rst#newcode4 doc/index.rst:4: The sale_product_customer module add to the sale line the ...
4 weeks ago (2019-02-20 17:56:36 UTC) #10
mrichez
https://codereview.tryton.org/46791002/diff/40001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/46791002/diff/40001/doc/index.rst#newcode4 doc/index.rst:4: The sale_product_customer module add to the sale line the ...
3 weeks, 5 days ago (2019-02-22 09:35:24 UTC) #11
mrichez
Improve doc following remarks
3 weeks, 5 days ago (2019-02-22 09:36:52 UTC) #12
reviewbot
https://codereview.tryton.org/46791002/diff/60001/setup.py#newcode71 setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/60001/setup.py#newcode85 setup.py:85: E501 line too ...
3 weeks, 5 days ago (2019-02-22 10:13:13 UTC) #13
ced
https://codereview.tryton.org/46791002/diff/60001/COPYRIGHT File COPYRIGHT (right): https://codereview.tryton.org/46791002/diff/60001/COPYRIGHT#newcode1 COPYRIGHT:1: Copyright (C) 2019 Maxime Richez For other contributions, you ...
1 week, 3 days ago (2019-03-10 13:11:21 UTC) #14
ced
Could you make patch against tryton-env and add the module in .hgsub and readthedocs.
1 week, 3 days ago (2019-03-10 16:27:52 UTC) #15
mrichez
https://codereview.tryton.org/46791002/diff/60001/COPYRIGHT File COPYRIGHT (right): https://codereview.tryton.org/46791002/diff/60001/COPYRIGHT#newcode1 COPYRIGHT:1: Copyright (C) 2019 Maxime Richez On 2019/03/10 13:11:20, ced ...
1 week, 2 days ago (2019-03-11 12:22:45 UTC) #16
mrichez
On 2019/03/10 16:27:52, ced wrote: > Could you make patch against tryton-env and add the ...
1 week, 2 days ago (2019-03-11 12:24:25 UTC) #17
ced
On 2019/03/11 12:24:25, mrichez wrote: > On 2019/03/10 16:27:52, ced wrote: > > Could you ...
1 week, 2 days ago (2019-03-11 12:52:14 UTC) #18
mrichez
1 week, 2 days ago (2019-03-11 14:32:09 UTC) #19
reviewbot
patch is not applicable URL: https://codereview.tryton.org/46791002
1 week, 2 days ago (2019-03-11 14:39:23 UTC) #20
mrichez
1 week, 1 day ago (2019-03-12 08:04:06 UTC) #21
reviewbot
1 week, 1 day ago (2019-03-12 08:10:22 UTC) #22
https://codereview.tryton.org/46791002/diff/263091002/modules/sale_product_cu...
modules/sale_product_customer/setup.py:71:
E501 line too long (81 > 79 characters)

https://codereview.tryton.org/46791002/diff/263091002/modules/sale_product_cu...
modules/sale_product_customer/setup.py:85:
E501 line too long (85 > 79 characters)

https://codereview.tryton.org/46791002/diff/263091002/modules/sale_product_cu...
modules/sale_product_customer/tests/__init__.py:5:
E501 line too long (92 > 79 characters)

URL: https://codereview.tryton.org/46791002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766