Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2153)

Issue 46791002: tryton-env: Add sale_product_customer module (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by mrichez
Modified:
1 month, 3 weeks ago
Reviewers:
pokoli, reviewbot, rietveld-bot, ced, dave
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove useless message.xml #

Total comments: 15

Patch Set 3 : Improve doc following remarks #

Total comments: 18

Patch Set 4 : Applying last remarks #

Total comments: 6

Patch Set 5 : Applying Ced's remarks #

Total comments: 6

Patch Set 6 : Apply last remarks #

Total comments: 4

Patch Set 7 : Apply last remark #

Patch Set 8 : Add product_customer on sale line tree views #

Total comments: 2

Patch Set 9 : Apply Ced's remark #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1431 lines, -0 lines) Patch
M .hgsub View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale_product_customer/.drone.yml View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
A modules/sale_product_customer/COPYRIGHT View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
A modules/sale_product_customer/INSTALL View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A modules/sale_product_customer/LICENSE View 1 2 3 1 chunk +674 lines, -0 lines 0 comments Download
A modules/sale_product_customer/MANIFEST.in View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A modules/sale_product_customer/README View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A modules/sale_product_customer/__init__.py View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A modules/sale_product_customer/doc/index.rst View 1 2 3 4 5 6 1 chunk +14 lines, -0 lines 0 comments Download
A modules/sale_product_customer/product.py View 1 2 3 4 1 chunk +102 lines, -0 lines 0 comments Download
A modules/sale_product_customer/product.xml View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
A modules/sale_product_customer/sale.py View 1 2 3 1 chunk +62 lines, -0 lines 0 comments Download
A modules/sale_product_customer/sale.xml View 1 2 3 4 5 6 7 1 chunk +77 lines, -0 lines 0 comments Download
A modules/sale_product_customer/setup.py View 1 2 3 1 chunk +123 lines, -0 lines 0 comments Download
A modules/sale_product_customer/tests/__init__.py View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A modules/sale_product_customer/tests/scenario_sale_product_customer.rst View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download
A modules/sale_product_customer/tests/test_sale_product_customer.py View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
A modules/sale_product_customer/tox.ini View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A modules/sale_product_customer/tryton.cfg View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/product_customer_form.xml View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/product_customer_tree.xml View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/product_customer_tree_sequence.xml View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/sale_line_form.xml View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/sale_line_tree.xml View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/sale_line_tree_sequence.xml View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/template_form.xml View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M readthedocs/sale.rst View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 53
mrichez
3 months ago (2019-02-20 09:05:21 UTC) #1
reviewbot
https://codereview.tryton.org/46791002/diff/1/setup.py#newcode71 setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/1/setup.py#newcode85 setup.py:85: E501 line too ...
3 months ago (2019-02-20 09:13:47 UTC) #2
mrichez
Remove useless message.xml
3 months ago (2019-02-20 09:15:10 UTC) #3
reviewbot
https://codereview.tryton.org/46791002/diff/20001/setup.py#newcode71 setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/20001/setup.py#newcode85 setup.py:85: E501 line too ...
3 months ago (2019-02-20 09:35:58 UTC) #4
mrichez
Remove useless message.xml
3 months ago (2019-02-20 10:06:12 UTC) #5
reviewbot
https://codereview.tryton.org/46791002/diff/40001/setup.py#newcode71 setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/40001/setup.py#newcode85 setup.py:85: E501 line too ...
3 months ago (2019-02-20 10:17:52 UTC) #6
pokoli
https://codereview.tryton.org/46791002/diff/40001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/46791002/diff/40001/doc/index.rst#newcode4 doc/index.rst:4: The sale_product_customer module add to the sale line the ...
3 months ago (2019-02-20 12:56:35 UTC) #7
mrichez
https://codereview.tryton.org/46791002/diff/40001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/46791002/diff/40001/doc/index.rst#newcode4 doc/index.rst:4: The sale_product_customer module add to the sale line the ...
3 months ago (2019-02-20 14:27:54 UTC) #8
mrichez
https://codereview.tryton.org/46791002/diff/40001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/46791002/diff/40001/doc/index.rst#newcode4 doc/index.rst:4: The sale_product_customer module add to the sale line the ...
3 months ago (2019-02-20 14:51:41 UTC) #9
dave
https://codereview.tryton.org/46791002/diff/40001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/46791002/diff/40001/doc/index.rst#newcode4 doc/index.rst:4: The sale_product_customer module add to the sale line the ...
3 months ago (2019-02-20 17:56:36 UTC) #10
mrichez
https://codereview.tryton.org/46791002/diff/40001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/46791002/diff/40001/doc/index.rst#newcode4 doc/index.rst:4: The sale_product_customer module add to the sale line the ...
3 months ago (2019-02-22 09:35:24 UTC) #11
mrichez
Improve doc following remarks
3 months ago (2019-02-22 09:36:52 UTC) #12
reviewbot
https://codereview.tryton.org/46791002/diff/60001/setup.py#newcode71 setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/60001/setup.py#newcode85 setup.py:85: E501 line too ...
3 months ago (2019-02-22 10:13:13 UTC) #13
ced
https://codereview.tryton.org/46791002/diff/60001/COPYRIGHT File COPYRIGHT (right): https://codereview.tryton.org/46791002/diff/60001/COPYRIGHT#newcode1 COPYRIGHT:1: Copyright (C) 2019 Maxime Richez For other contributions, you ...
2 months, 2 weeks ago (2019-03-10 13:11:21 UTC) #14
ced
Could you make patch against tryton-env and add the module in .hgsub and readthedocs.
2 months, 2 weeks ago (2019-03-10 16:27:52 UTC) #15
mrichez
https://codereview.tryton.org/46791002/diff/60001/COPYRIGHT File COPYRIGHT (right): https://codereview.tryton.org/46791002/diff/60001/COPYRIGHT#newcode1 COPYRIGHT:1: Copyright (C) 2019 Maxime Richez On 2019/03/10 13:11:20, ced ...
2 months, 1 week ago (2019-03-11 12:22:45 UTC) #16
mrichez
On 2019/03/10 16:27:52, ced wrote: > Could you make patch against tryton-env and add the ...
2 months, 1 week ago (2019-03-11 12:24:25 UTC) #17
ced
On 2019/03/11 12:24:25, mrichez wrote: > On 2019/03/10 16:27:52, ced wrote: > > Could you ...
2 months, 1 week ago (2019-03-11 12:52:14 UTC) #18
mrichez
2 months, 1 week ago (2019-03-11 14:32:09 UTC) #19
reviewbot
patch is not applicable URL: https://codereview.tryton.org/46791002
2 months, 1 week ago (2019-03-11 14:39:23 UTC) #20
mrichez
2 months, 1 week ago (2019-03-12 08:04:06 UTC) #21
reviewbot
https://codereview.tryton.org/46791002/diff/263091002/modules/sale_product_customer/setup.py#newcode71 modules/sale_product_customer/setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/263091002/modules/sale_product_customer/setup.py#newcode85 modules/sale_product_customer/setup.py:85: E501 line too ...
2 months, 1 week ago (2019-03-12 08:10:22 UTC) #22
ced
https://codereview.tryton.org/46791002/diff/263091002/modules/sale_product_customer/doc/index.rst File modules/sale_product_customer/doc/index.rst (right): https://codereview.tryton.org/46791002/diff/263091002/modules/sale_product_customer/doc/index.rst#newcode6 modules/sale_product_customer/doc/index.rst:6: for the same product in which case the selection ...
2 months ago (2019-03-22 12:29:17 UTC) #23
mrichez
https://codereview.tryton.org/46791002/diff/263091002/modules/sale_product_customer/doc/index.rst File modules/sale_product_customer/doc/index.rst (right): https://codereview.tryton.org/46791002/diff/263091002/modules/sale_product_customer/doc/index.rst#newcode6 modules/sale_product_customer/doc/index.rst:6: for the same product in which case the selection ...
2 months ago (2019-03-22 14:24:07 UTC) #24
mrichez
2 months ago (2019-03-22 14:25:20 UTC) #25
reviewbot
https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/setup.py#newcode71 modules/sale_product_customer/setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/setup.py#newcode85 modules/sale_product_customer/setup.py:85: E501 line too ...
2 months ago (2019-03-22 14:41:03 UTC) #26
ced
https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/doc/index.rst File modules/sale_product_customer/doc/index.rst (right): https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/doc/index.rst#newcode5 modules/sale_product_customer/doc/index.rst:5: automatically added to sales lines. passive form is more ...
2 months ago (2019-03-22 15:34:09 UTC) #27
dave
https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/doc/index.rst File modules/sale_product_customer/doc/index.rst (right): https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/doc/index.rst#newcode5 modules/sale_product_customer/doc/index.rst:5: automatically added to sales lines. On 2019/03/22 15:34:09, ced ...
2 months ago (2019-03-24 10:00:48 UTC) #28
ced
https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/doc/index.rst File modules/sale_product_customer/doc/index.rst (right): https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/doc/index.rst#newcode5 modules/sale_product_customer/doc/index.rst:5: automatically added to sales lines. On 2019/03/24 10:00:48, dave ...
2 months ago (2019-03-24 11:35:43 UTC) #29
mrichez
https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/doc/index.rst File modules/sale_product_customer/doc/index.rst (right): https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/doc/index.rst#newcode5 modules/sale_product_customer/doc/index.rst:5: automatically added to sales lines. On 2019/03/24 11:35:43, ced ...
1 month, 4 weeks ago (2019-03-25 08:52:19 UTC) #30
ced
https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/doc/index.rst File modules/sale_product_customer/doc/index.rst (right): https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/doc/index.rst#newcode5 modules/sale_product_customer/doc/index.rst:5: automatically added to sales lines. On 2019/03/25 08:52:19, mrichez ...
1 month, 4 weeks ago (2019-03-25 09:14:28 UTC) #31
mrichez
https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/doc/index.rst File modules/sale_product_customer/doc/index.rst (right): https://codereview.tryton.org/46791002/diff/261171002/modules/sale_product_customer/doc/index.rst#newcode5 modules/sale_product_customer/doc/index.rst:5: automatically added to sales lines. On 2019/03/25 09:14:28, ced ...
1 month, 4 weeks ago (2019-03-25 10:40:04 UTC) #32
mrichez
1 month, 4 weeks ago (2019-03-25 10:41:36 UTC) #33
reviewbot
https://codereview.tryton.org/46791002/diff/259251002/modules/sale_product_customer/setup.py#newcode71 modules/sale_product_customer/setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/259251002/modules/sale_product_customer/setup.py#newcode85 modules/sale_product_customer/setup.py:85: E501 line too ...
1 month, 4 weeks ago (2019-03-25 11:21:52 UTC) #34
ced
https://codereview.tryton.org/46791002/diff/259251002/modules/sale_product_customer/doc/index.rst File modules/sale_product_customer/doc/index.rst (right): https://codereview.tryton.org/46791002/diff/259251002/modules/sale_product_customer/doc/index.rst#newcode7 modules/sale_product_customer/doc/index.rst:7: A link to the customer's product is automatically added ...
1 month, 4 weeks ago (2019-03-26 09:29:52 UTC) #35
mrichez
https://codereview.tryton.org/46791002/diff/259251002/modules/sale_product_customer/doc/index.rst File modules/sale_product_customer/doc/index.rst (right): https://codereview.tryton.org/46791002/diff/259251002/modules/sale_product_customer/doc/index.rst#newcode7 modules/sale_product_customer/doc/index.rst:7: A link to the customer's product is automatically added ...
1 month, 4 weeks ago (2019-03-26 09:43:18 UTC) #36
dave
https://codereview.tryton.org/46791002/diff/259251002/modules/sale_product_customer/doc/index.rst File modules/sale_product_customer/doc/index.rst (right): https://codereview.tryton.org/46791002/diff/259251002/modules/sale_product_customer/doc/index.rst#newcode7 modules/sale_product_customer/doc/index.rst:7: A link to the customer's product is automatically added ...
1 month, 4 weeks ago (2019-03-26 12:01:12 UTC) #37
mrichez
https://codereview.tryton.org/46791002/diff/259251002/modules/sale_product_customer/doc/index.rst File modules/sale_product_customer/doc/index.rst (right): https://codereview.tryton.org/46791002/diff/259251002/modules/sale_product_customer/doc/index.rst#newcode7 modules/sale_product_customer/doc/index.rst:7: A link to the customer's product is automatically added ...
1 month, 4 weeks ago (2019-03-26 13:06:56 UTC) #38
mrichez
1 month, 4 weeks ago (2019-03-26 13:08:51 UTC) #39
reviewbot
https://codereview.tryton.org/46791002/diff/257201002/modules/sale_product_customer/setup.py#newcode71 modules/sale_product_customer/setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/257201002/modules/sale_product_customer/setup.py#newcode85 modules/sale_product_customer/setup.py:85: E501 line too ...
1 month, 4 weeks ago (2019-03-26 13:15:08 UTC) #40
ced
I think product_customer should be added to the sale line tree views also.
1 month, 3 weeks ago (2019-03-28 09:41:07 UTC) #41
mrichez
On 2019/03/28 09:41:07, ced wrote: > I think product_customer should be added to the sale ...
1 month, 3 weeks ago (2019-03-28 11:55:15 UTC) #42
ced
On 2019/03/28 11:55:15, mrichez wrote: > On 2019/03/28 09:41:07, ced wrote: > > I think ...
1 month, 3 weeks ago (2019-03-28 12:10:51 UTC) #43
mrichez
1 month, 3 weeks ago (2019-03-28 12:48:40 UTC) #44
reviewbot
https://codereview.tryton.org/46791002/diff/287191002/modules/sale_product_customer/setup.py#newcode71 modules/sale_product_customer/setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/287191002/modules/sale_product_customer/setup.py#newcode85 modules/sale_product_customer/setup.py:85: E501 line too ...
1 month, 3 weeks ago (2019-03-28 13:10:30 UTC) #45
ced
https://codereview.tryton.org/46791002/diff/287191002/readthedocs/sale.rst File readthedocs/sale.rst (right): https://codereview.tryton.org/46791002/diff/287191002/readthedocs/sale.rst#newcode33 readthedocs/sale.rst:33: Define product code and name for customer on sale ...
1 month, 3 weeks ago (2019-03-28 18:17:20 UTC) #46
mrichez
https://codereview.tryton.org/46791002/diff/287191002/readthedocs/sale.rst File readthedocs/sale.rst (right): https://codereview.tryton.org/46791002/diff/287191002/readthedocs/sale.rst#newcode33 readthedocs/sale.rst:33: Define product code and name for customer on sale ...
1 month, 3 weeks ago (2019-03-29 07:56:10 UTC) #47
mrichez
1 month, 3 weeks ago (2019-03-29 07:59:17 UTC) #48
reviewbot
https://codereview.tryton.org/46791002/diff/255211002/modules/sale_product_customer/setup.py#newcode71 modules/sale_product_customer/setup.py:71: E501 line too long (81 > 79 characters) https://codereview.tryton.org/46791002/diff/255211002/modules/sale_product_customer/setup.py#newcode85 modules/sale_product_customer/setup.py:85: E501 line too ...
1 month, 3 weeks ago (2019-03-29 08:20:31 UTC) #49
ced
LGTM
1 month, 3 weeks ago (2019-03-29 08:31:34 UTC) #50
rietveld-bot_tryton.org
New changeset dd2edf3ed942 by Maxime Richez in branch 'default': Add sale_product_customer module https://hg.tryton.org/modules/sale_product_customer/rev/dd2edf3ed942
1 month, 3 weeks ago (2019-03-30 14:51:50 UTC) #51
rietveld-bot_tryton.org
New changeset 6b5de3d9fe77 by Maxime Richez in branch 'default': Add sale_product_customer module https://hg.tryton.org/readthedocs/rev/6b5de3d9fe77
1 month, 3 weeks ago (2019-03-30 14:51:55 UTC) #52
rietveld-bot_tryton.org
1 month, 3 weeks ago (2019-03-30 14:51:56 UTC) #53
New changeset 93083109e60a by Maxime Richez in branch 'default':
Add sale_product_customer module
https://hg.tryton.org/tryton-env/rev/93083109e60a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766