Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1729)

Issue 47321002: trytond: Do not call table_query for testing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months ago by ced
Modified:
5 months, 2 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Only the callable property of table_query is used to test if the ModelSQL uses a table query or not. issue5726

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M doc/ref/models/models.rst View 1 chunk +1 line, -1 line 0 comments Download
M trytond/model/modelsql.py View 18 chunks +24 lines, -20 lines 0 comments Download
M trytond/model/modelstorage.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4
ced
6 months ago (2018-04-14 23:43:22 UTC) #1
reviewbot
https://codereview.tryton.org/47321002/diff/1/trytond/model/modelsql.py#newcode352 trytond/model/modelsql.py:352: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/47321002
6 months ago (2018-04-14 23:56:45 UTC) #2
pokoli
LGTM
5 months, 3 weeks ago (2018-04-25 09:06:48 UTC) #3
rietveld-bot_tryton.org
5 months, 2 weeks ago (2018-04-30 13:55:36 UTC) #4
New changeset d82b88073486 by Cédric Krier in branch 'default':
Do not call table_query for testing
http://hg.tryton.org/trytond/rev/d82b88073486
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766