Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 47331002: sao: Move max-width CSS Integer to apply only on form (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by ced
Modified:
3 months ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

The rule breaks the display of the widget on editable tree as it should expand to the width of the cell. issue7357

Patch Set 1 #

Total comments: 1

Patch Set 2 : Limit to integer and float #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/sao.less View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/view/form.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7
ced
3 months, 1 week ago (2018-04-16 09:54:06 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/47331002
3 months, 1 week ago (2018-04-16 10:06:40 UTC) #2
pokoli
https://codereview.tryton.org/47331002/diff/1/src/sao.less File src/sao.less (right): https://codereview.tryton.org/47331002/diff/1/src/sao.less#newcode234 src/sao.less:234: max-width: 8em; This will apply the max-width also to ...
3 months ago (2018-04-18 07:58:48 UTC) #3
ced
Limit to integer and float
3 months ago (2018-04-18 08:14:21 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/47331002
3 months ago (2018-04-18 08:24:53 UTC) #5
pokoli
LGTM
3 months ago (2018-04-18 08:47:56 UTC) #6
rietveld-bot_tryton.org
3 months ago (2018-04-18 22:13:47 UTC) #7
New changeset 9847ea59ea34 by Cédric Krier in branch 'default':
Move max-width CSS Integer to apply only on form
http://hg.tryton.org/sao/rev/9847ea59ea34
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69