Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(107)

Issue 47421002: trytond: Add tree name clause only if not yet present (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by ced
Modified:
7 months ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

We can not rely on the deepcopy of the field because the Mixin maybe added after the class that define the field. In this case we modify the reference field for the deepcopy. issue7434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M trytond/model/tree.py View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4
ced
7 months ago (2018-05-16 13:37:56 UTC) #1
reviewbot
https://codereview.tryton.org/47421002/diff/1/trytond/model/tree.py#newcode51 trytond/model/tree.py:51: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/47421002
7 months ago (2018-05-16 13:47:28 UTC) #2
pokoli
LGTM
7 months ago (2018-05-17 14:59:30 UTC) #3
rietveld-bot_tryton.org
7 months ago (2018-05-17 16:26:57 UTC) #4
New changeset 6836081bd4c4 by Cédric Krier in branch 'default':
Add tree name clause only if not yet present
https://hg.tryton.org/trytond/rev/6836081bd4c4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766