Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(427)

Issue 47441002: account_payment_sepa: Use single report for mandate

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by pokoli
Modified:
4 years, 8 months ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -34 lines) Patch
M mandate.fodt View 12 chunks +34 lines, -32 lines 0 comments Download
M payment.py View 2 chunks +8 lines, -2 lines 1 comment Download
M payment.xml View 1 chunk +1 line, -0 lines 0 comments Download
M setup.py View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/scenario_sepa_mandate.rst View 1 chunk +74 lines, -0 lines 1 comment Download
M tests/test_account_payment_sepa.py View 3 chunks +7 lines, -0 lines 1 comment Download

Messages

Total messages: 3
pokoli
4 years, 8 months ago (2018-05-24 10:40:47 UTC) #1
reviewbot
https://codereview.tryton.org/47441002/diff/1/payment.py#newcode29 payment.py:29: E402 module level import not at top of file https://codereview.tryton.org/47441002/diff/1/payment.py#newcode696 payment.py:696: E127 continuation ...
4 years, 8 months ago (2018-05-24 10:54:42 UTC) #2
ced
4 years, 8 months ago (2018-05-31 15:56:53 UTC) #3
https://codereview.tryton.org/47441002/diff/1/payment.py
File payment.py (right):

https://codereview.tryton.org/47441002/diff/1/payment.py#newcode609
payment.py:609: context['mandate'] = context['record']
I do not think it is necessary. This make the template less reusable.

https://codereview.tryton.org/47441002/diff/1/tests/scenario_sepa_mandate.rst
File tests/scenario_sepa_mandate.rst (right):

https://codereview.tryton.org/47441002/diff/1/tests/scenario_sepa_mandate.rst...
tests/scenario_sepa_mandate.rst:58: >>> mandate.identification = '1'
Will it not be good to test the sequence assignation also?

https://codereview.tryton.org/47441002/diff/1/tests/test_account_payment_sepa.py
File tests/test_account_payment_sepa.py (right):

https://codereview.tryton.org/47441002/diff/1/tests/test_account_payment_sepa...
tests/test_account_payment_sepa.py:456: def test_sepa_mandate_report(self):
The report is already tested here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted