Issue 47441002: account_payment_sepa: Use single report for mandate

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 47441002: account_payment_sepa: Use single report for mandate

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 8 months ago by pokoli

Modified:
4 years, 8 months ago

Reviewers:
ced, reviewbot

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 3

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+127 lines, -34 lines)			Patch
M	mandate.fodt	View	12 chunks	+34 lines, -32 lines	0 comments	Download
M	payment.py	View	2 chunks	+8 lines, -2 lines	1 comment	Download
M	payment.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	setup.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	tests/scenario_sepa_mandate.rst	View	1 chunk	+74 lines, -0 lines	1 comment	Download
M	tests/test_account_payment_sepa.py	View	3 chunks	+7 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reviewbot

https://codereview.tryton.org/47441002/diff/1/payment.py#newcode29 payment.py:29: E402 module level import not at top of file https://codereview.tryton.org/47441002/diff/1/payment.py#newcode696 payment.py:696: E127 continuation ...

4 years, 8 months ago (2018-05-24 10:54:42 UTC) #2

ced

4 years, 8 months ago (2018-05-31 15:56:53 UTC) #3

https://codereview.tryton.org/47441002/diff/1/payment.py
File payment.py (right):

https://codereview.tryton.org/47441002/diff/1/payment.py#newcode609
payment.py:609: context['mandate'] = context['record']
I do not think it is necessary. This make the template less reusable.

https://codereview.tryton.org/47441002/diff/1/tests/scenario_sepa_mandate.rst
File tests/scenario_sepa_mandate.rst (right):

https://codereview.tryton.org/47441002/diff/1/tests/scenario_sepa_mandate.rst...
tests/scenario_sepa_mandate.rst:58: >>> mandate.identification = '1'
Will it not be good to test the sequence assignation also?

https://codereview.tryton.org/47441002/diff/1/tests/test_account_payment_sepa.py
File tests/test_account_payment_sepa.py (right):

https://codereview.tryton.org/47441002/diff/1/tests/test_account_payment_sepa...
tests/test_account_payment_sepa.py:456: def test_sepa_mandate_report(self):
The report is already tested here.

Expand All Messages | Collapse All Messages