Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(201)

Issue 47511002: trytond: Remove button if it is not allowed to access some of its dependant fields

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by pokoli
Modified:
3 days, 11 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add changelog #

Patch Set 3 : Remove field definition if the user is not allowed to access it #

Total comments: 2

Patch Set 4 : Remove buttons and add test #

Total comments: 3

Patch Set 5 : Add changelog, fix comment, test with access and follow AAA #

Total comments: 3

Patch Set 6 : Fix comments and update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -16 lines) Patch
M CHANGELOG View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M trytond/model/modelview.py View 1 2 3 4 5 1 chunk +27 lines, -16 lines 0 comments Download
M trytond/tests/__init__.py View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M trytond/tests/modelview.py View 1 2 3 4 5 2 chunks +21 lines, -0 lines 0 comments Download
M trytond/tests/modelview.xml View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
M trytond/tests/test_modelview.py View 1 2 3 4 5 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 17
pokoli
1 month, 1 week ago (2018-06-05 15:41:42 UTC) #1
pokoli
Add changelog
1 month, 1 week ago (2018-06-05 15:46:12 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/47511002
1 month, 1 week ago (2018-06-05 15:56:57 UTC) #3
pokoli
Remove field definition if the user is not allowed to access it
1 month, 1 week ago (2018-06-06 09:44:27 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/47511002
1 month, 1 week ago (2018-06-06 10:02:59 UTC) #5
ced
https://codereview.tryton.org/47511002/diff/40001/trytond/model/modelview.py File trytond/model/modelview.py (right): https://codereview.tryton.org/47511002/diff/40001/trytond/model/modelview.py#newcode459 trytond/model/modelview.py:459: fields_def.setdefault(depend, {'name': depend}) Why not just test here if ...
1 month, 1 week ago (2018-06-06 10:10:18 UTC) #6
pokoli
https://codereview.tryton.org/47511002/diff/40001/trytond/model/modelview.py File trytond/model/modelview.py (right): https://codereview.tryton.org/47511002/diff/40001/trytond/model/modelview.py#newcode459 trytond/model/modelview.py:459: fields_def.setdefault(depend, {'name': depend}) On 2018/06/06 10:10:18, ced wrote: > ...
1 month, 1 week ago (2018-06-06 10:20:18 UTC) #7
ced
As said in https://bugs.tryton.org/msg41316 it is the button that should be removed and not remove ...
3 weeks, 2 days ago (2018-06-21 21:42:56 UTC) #8
pokoli
Remove buttons and add test
1 week, 4 days ago (2018-07-04 09:29:43 UTC) #9
reviewbot
https://codereview.tryton.org/47511002/diff/60001/trytond/model/modelview.py#newcode652 trytond/model/modelview.py:652: E501 line too long (93 > 79 characters) URL: https://codereview.tryton.org/47511002
1 week, 4 days ago (2018-07-04 09:50:30 UTC) #10
ced
Missing CHANGELOG entry. https://codereview.tryton.org/47511002/diff/60001/trytond/model/modelview.py File trytond/model/modelview.py (right): https://codereview.tryton.org/47511002/diff/60001/trytond/model/modelview.py#newcode418 trytond/model/modelview.py:418: # Remove field without read acces ...
1 week, 2 days ago (2018-07-05 23:05:38 UTC) #11
pokoli
Add changelog, fix comment, test with access and follow AAA
1 week, 2 days ago (2018-07-06 10:46:53 UTC) #12
reviewbot
https://codereview.tryton.org/47511002/diff/80001/trytond/model/modelview.py#newcode652 trytond/model/modelview.py:652: E501 line too long (93 > 79 characters) URL: https://codereview.tryton.org/47511002
1 week, 2 days ago (2018-07-06 10:48:24 UTC) #13
ced
https://codereview.tryton.org/47511002/diff/80001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/47511002/diff/80001/CHANGELOG#newcode1 CHANGELOG:1: * Remove button if not allow to access some ...
4 days, 7 hours ago (2018-07-11 13:31:27 UTC) #14
pokoli
Fix comments and update to tip
4 days, 6 hours ago (2018-07-11 14:50:39 UTC) #15
reviewbot
https://codereview.tryton.org/47511002/diff/100001/trytond/tests/__init__.py#newcode11 trytond/tests/__init__.py:11: F403 'from modelview import *' used; unable to detect undefined names https://codereview.tryton.org/47511002/diff/100001/trytond/tests/__init__.py#newcode12 trytond/tests/__init__.py:12: ...
4 days, 5 hours ago (2018-07-11 15:22:08 UTC) #16
ced
3 days, 11 hours ago (2018-07-12 09:10:54 UTC) #17
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69