Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 47571002: sale: Show number and reference in sale rec_name (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by smn
Modified:
1 week, 2 days ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : sale: Avoid multiple returns, add CHANGELOG #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M CHANGELOG View 1 1 chunk +1 line, -0 lines 0 comments Download
M sale.py View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7
smn
2 months, 3 weeks ago (2018-07-02 08:23:42 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/47571002
2 months, 3 weeks ago (2018-07-02 08:31:50 UTC) #2
ced
Missing CHANGELOG entry. https://codereview.tryton.org/47571002/diff/1/sale.py File sale.py (right): https://codereview.tryton.org/47571002/diff/1/sale.py#newcode681 sale.py:681: return '(%s)' % self.id Idem as ...
2 months, 2 weeks ago (2018-07-05 22:51:50 UTC) #3
smn
sale: Avoid multiple returns, add CHANGELOG
2 months, 2 weeks ago (2018-07-08 06:42:33 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/47571002
2 months, 2 weeks ago (2018-07-08 07:15:38 UTC) #5
ced
LGTM
2 months, 1 week ago (2018-07-11 13:37:55 UTC) #6
rietveld-bot_tryton.org
2 months, 1 week ago (2018-07-11 15:17:59 UTC) #7
New changeset fcf1a3a19bfd by Sergio Morillo in branch 'default':
Show number and reference in sale rec_name
https://hg.tryton.org/modules/sale/rev/fcf1a3a19bfd
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766