Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 47581002: sao: Add Array.from replacement for IE11 support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by pokoli
Modified:
1 month, 3 weeks ago
Reviewers:
xcodinas, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use array.foreach instead of from polyfil #

Total comments: 1

Patch Set 3 : Add comment #

Patch Set 4 : Remove trailing space #

Total comments: 1

Patch Set 5 : Comment about not strictly equivalent #

Total comments: 2

Patch Set 6 : Clarify comment #

Patch Set 7 : Simplify comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/sao.js View 1 2 3 4 5 6 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 21
pokoli
2 months, 2 weeks ago (2018-07-03 15:39:48 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/47581002
2 months, 2 weeks ago (2018-07-03 15:50:38 UTC) #2
xcodinas
Maybe it should be nice to have a comment to know why are you adding ...
2 months, 2 weeks ago (2018-07-04 07:22:19 UTC) #3
pokoli
Use array.foreach instead of Form polyfil
2 months, 2 weeks ago (2018-07-04 08:13:02 UTC) #4
pokoli
On 2018/07/04 07:22:19, xcodinas wrote: > Maybe it should be nice to have a comment ...
2 months, 2 weeks ago (2018-07-04 08:14:46 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/47581002
2 months, 2 weeks ago (2018-07-04 08:17:42 UTC) #6
ced
could we talk of Polyfill if it is not a complete replacement. https://codereview.tryton.org/47581002/diff/20001/src/sao.js File src/sao.js ...
2 months, 2 weeks ago (2018-07-05 23:00:36 UTC) #7
pokoli
Add comment
2 months, 2 weeks ago (2018-07-06 10:36:03 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/47581002
2 months, 2 weeks ago (2018-07-06 10:48:03 UTC) #9
pokoli
Remove trailing space
2 months, 2 weeks ago (2018-07-06 11:08:08 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/47581002
2 months, 2 weeks ago (2018-07-06 11:12:43 UTC) #11
ced
https://codereview.tryton.org/47581002/diff/60001/src/sao.js File src/sao.js (right): https://codereview.tryton.org/47581002/diff/60001/src/sao.js#newcode61 src/sao.js:61: // Use foreach as equivalent because polyfill is too ...
2 months, 1 week ago (2018-07-11 13:25:21 UTC) #12
pokoli
Comment about not strictly equivalent
2 months, 1 week ago (2018-07-11 14:02:15 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/47581002
2 months, 1 week ago (2018-07-11 14:18:09 UTC) #14
ced
https://codereview.tryton.org/47581002/diff/80001/src/sao.js File src/sao.js (right): https://codereview.tryton.org/47581002/diff/80001/src/sao.js#newcode61 src/sao.js:61: // Foreach is not strictly equivalent but works for ...
2 months, 1 week ago (2018-07-11 14:38:30 UTC) #15
pokoli
https://codereview.tryton.org/47581002/diff/80001/src/sao.js File src/sao.js (right): https://codereview.tryton.org/47581002/diff/80001/src/sao.js#newcode61 src/sao.js:61: // Foreach is not strictly equivalent but works for ...
1 month, 3 weeks ago (2018-07-31 14:07:00 UTC) #16
pokoli
Simplify comment
1 month, 3 weeks ago (2018-07-31 14:08:27 UTC) #17
ced
LGTM
1 month, 3 weeks ago (2018-07-31 14:32:05 UTC) #18
reviewbot
flake8 OK URL: https://codereview.tryton.org/47581002
1 month, 3 weeks ago (2018-07-31 14:35:30 UTC) #19
rietveld-bot_tryton.org
New changeset a9eca28564c2 by Sergi Almacellas Abellana in branch 'default': Add Array.from replacement for IE11 ...
1 month, 3 weeks ago (2018-08-01 08:38:08 UTC) #20
rietveld-bot_tryton.org
1 month, 3 weeks ago (2018-08-01 08:38:18 UTC) #21
New changeset 4240979e04cf by Sergi Almacellas Abellana in branch 'default':
Add Array.from replacement for IE11 support
https://hg.tryton.org/tryton-env/rev/4240979e04cf
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766