Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 47581002: sao: Add Array.from replacement for IE11 support

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by pokoli
Modified:
4 days, 6 hours ago
Reviewers:
xcodinas, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use array.foreach instead of from polyfil #

Total comments: 1

Patch Set 3 : Add comment #

Patch Set 4 : Remove trailing space #

Total comments: 1

Patch Set 5 : Comment about not strictly equivalent #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/sao.js View 1 2 3 4 1 chunk +11 lines, -0 lines 1 comment Download

Messages

Total messages: 15
pokoli
1 week, 5 days ago (2018-07-03 15:39:48 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/47581002
1 week, 5 days ago (2018-07-03 15:50:38 UTC) #2
xcodinas
Maybe it should be nice to have a comment to know why are you adding ...
1 week, 4 days ago (2018-07-04 07:22:19 UTC) #3
pokoli
Use array.foreach instead of Form polyfil
1 week, 4 days ago (2018-07-04 08:13:02 UTC) #4
pokoli
On 2018/07/04 07:22:19, xcodinas wrote: > Maybe it should be nice to have a comment ...
1 week, 4 days ago (2018-07-04 08:14:46 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/47581002
1 week, 4 days ago (2018-07-04 08:17:42 UTC) #6
ced
could we talk of Polyfill if it is not a complete replacement. https://codereview.tryton.org/47581002/diff/20001/src/sao.js File src/sao.js ...
1 week, 2 days ago (2018-07-05 23:00:36 UTC) #7
pokoli
Add comment
1 week, 2 days ago (2018-07-06 10:36:03 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/47581002
1 week, 2 days ago (2018-07-06 10:48:03 UTC) #9
pokoli
Remove trailing space
1 week, 2 days ago (2018-07-06 11:08:08 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/47581002
1 week, 2 days ago (2018-07-06 11:12:43 UTC) #11
ced
https://codereview.tryton.org/47581002/diff/60001/src/sao.js File src/sao.js (right): https://codereview.tryton.org/47581002/diff/60001/src/sao.js#newcode61 src/sao.js:61: // Use foreach as equivalent because polyfill is too ...
4 days, 7 hours ago (2018-07-11 13:25:21 UTC) #12
pokoli
Comment about not strictly equivalent
4 days, 7 hours ago (2018-07-11 14:02:15 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/47581002
4 days, 6 hours ago (2018-07-11 14:18:09 UTC) #14
ced
4 days, 6 hours ago (2018-07-11 14:38:30 UTC) #15
https://codereview.tryton.org/47581002/diff/80001/src/sao.js
File src/sao.js (right):

https://codereview.tryton.org/47581002/diff/80001/src/sao.js#newcode61
src/sao.js:61: // Foreach is not strictly equivalent but works for most cases
Foreach -> implementation is not…
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69