Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 47601002: trytond: Add help texts.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by udono
Modified:
2 days, 8 hours ago
Reviewers:
reviewbot
Visibility:
Public.

Description

COLLABORATOR=dave@liberteq.org issue7034

Patch Set 1 #

Patch Set 2 : Update tip #

Patch Set 3 : Add help to ir.model.button instead of view. #

Patch Set 4 : Update to tip rev6571df5d8026 #

Patch Set 5 : Improve help text #

Total comments: 10

Patch Set 6 : Fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -38 lines) Patch
M trytond/ir/ui/icon.py View 1 2 3 4 1 chunk +7 lines, -3 lines 0 comments Download
M trytond/ir/ui/menu.py View 1 2 3 4 5 2 chunks +19 lines, -9 lines 0 comments Download
M trytond/ir/ui/view.py View 1 2 3 4 5 6 chunks +48 lines, -24 lines 0 comments Download
M trytond/ir/ui/view.xml View 1 2 5 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15
udono
5 months ago (2018-07-16 06:40:51 UTC) #1
reviewbot
https://codereview.tryton.org/47601002/diff/1/trytond/ir/ui/menu.py#newcode163 trytond/ir/ui/menu.py:163: E731 do not assign a lambda expression, use a def URL: https://codereview.tryton.org/47601002
5 months ago (2018-07-16 06:42:42 UTC) #2
udono
Update tip
4 months, 2 weeks ago (2018-08-06 13:11:10 UTC) #3
udono
Add help to ir.model.button instead of view.
4 months, 2 weeks ago (2018-08-06 13:12:32 UTC) #4
reviewbot
https://codereview.tryton.org/47601002/diff/40001/trytond/ir/ui/menu.py#newcode163 trytond/ir/ui/menu.py:163: E731 do not assign a lambda expression, use a def URL: https://codereview.tryton.org/47601002
4 months, 2 weeks ago (2018-08-06 13:41:13 UTC) #5
udono
the patch applies on rev42cd96d58788
2 weeks, 6 days ago (2018-11-28 16:22:26 UTC) #6
dave
Update to tip rev6571df5d8026
2 weeks, 1 day ago (2018-12-03 13:53:44 UTC) #7
reviewbot
https://codereview.tryton.org/47601002/diff/60001/trytond/ir/ui/menu.py#newcode172 trytond/ir/ui/menu.py:172: E731 do not assign a lambda expression, use a def URL: https://codereview.tryton.org/47601002
2 weeks, 1 day ago (2018-12-03 14:15:46 UTC) #8
dave
Improve help text
2 weeks ago (2018-12-04 15:35:17 UTC) #9
reviewbot
https://codereview.tryton.org/47601002/diff/80001/trytond/ir/ui/menu.py#newcode175 trytond/ir/ui/menu.py:175: E731 do not assign a lambda expression, use a def URL: https://codereview.tryton.org/47601002
2 weeks ago (2018-12-04 15:44:03 UTC) #10
udono
https://codereview.tryton.org/47601002/diff/80001/trytond/ir/ui/menu.py File trytond/ir/ui/menu.py (right): https://codereview.tryton.org/47601002/diff/80001/trytond/ir/ui/menu.py#newcode83 trytond/ir/ui/menu.py:83: "UI menu" Menu https://codereview.tryton.org/47601002/diff/80001/trytond/ir/ui/view.py File trytond/ir/ui/view.py (right): https://codereview.tryton.org/47601002/diff/80001/trytond/ir/ui/view.py#newcode213 trytond/ir/ui/view.py:213: ...
2 weeks ago (2018-12-04 16:54:33 UTC) #11
dave
Fix comments
2 weeks ago (2018-12-04 20:10:05 UTC) #12
dave
https://codereview.tryton.org/47601002/diff/80001/trytond/ir/ui/menu.py File trytond/ir/ui/menu.py (right): https://codereview.tryton.org/47601002/diff/80001/trytond/ir/ui/menu.py#newcode83 trytond/ir/ui/menu.py:83: "UI menu" On 2018/12/04 16:54:32, udono wrote: > Menu ...
2 weeks ago (2018-12-04 20:11:32 UTC) #13
reviewbot
https://codereview.tryton.org/47601002/diff/100001/trytond/ir/ui/menu.py#newcode175 trytond/ir/ui/menu.py:175: E731 do not assign a lambda expression, use a def URL: https://codereview.tryton.org/47601002
2 weeks ago (2018-12-04 20:34:39 UTC) #14
udono
2 days, 8 hours ago (2018-12-16 17:24:15 UTC) #15
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766