Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2206)

Issue 47621002: sao: Move global search in navbar (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months ago by ced
Modified:
10 months ago
Reviewers:
xcodinas, rietveld-bot, reviewbot
Visibility:
Public.

Description

This gives more places to display menu entries in the dropdown. And provide more spaces for the menu on small screen. issue7485

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove trailing space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -28 lines) Patch
M index.html View 1 chunk +2 lines, -0 lines 0 comments Download
M src/sao.js View 1 10 chunks +19 lines, -28 lines 0 comments Download

Messages

Total messages: 8
ced
10 months ago (2018-07-21 16:15:39 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/47621002
10 months ago (2018-07-21 16:35:01 UTC) #2
xcodinas
https://codereview.tryton.org/47621002/diff/1/src/sao.js File src/sao.js (right): https://codereview.tryton.org/47621002/diff/1/src/sao.js#newcode527 src/sao.js:527: if (!jQuery('#user-favorites').children('.dropdown-menu') .length) { Space not needed https://codereview.tryton.org/47621002/diff/1/src/sao.js#newcode806 src/sao.js:806: ...
10 months ago (2018-07-23 08:19:26 UTC) #3
ced
Remove trailing space
10 months ago (2018-07-23 09:28:57 UTC) #4
ced
https://codereview.tryton.org/47621002/diff/1/src/sao.js File src/sao.js (right): https://codereview.tryton.org/47621002/diff/1/src/sao.js#newcode806 src/sao.js:806: 'placeholder': Sao.i18n.gettext('Action') On 2018/07/23 08:19:25, xcodinas wrote: > Why ...
10 months ago (2018-07-23 09:29:22 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/47621002
10 months ago (2018-07-23 09:33:50 UTC) #6
rietveld-bot_tryton.org
New changeset dced00d04227 by Cédric Krier in branch 'default': Move global search in navbar https://hg.tryton.org/sao/rev/dced00d04227
10 months ago (2018-07-25 22:25:36 UTC) #7
rietveld-bot_tryton.org
10 months ago (2018-07-25 22:25:43 UTC) #8
New changeset eeaa41a70a7a by Cédric Krier in branch 'default':
Move global search in navbar
https://hg.tryton.org/tryton-env/rev/eeaa41a70a7a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766