Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(65)

Issue 47721002: account: Ensure end periods is set when computing GL debit and credit amounts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by pokoli
Modified:
4 months, 1 week ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

As the diference between end_periods and start_periods is computed, the end periods should have a value when the start periods is set otherwise and empty list of periods is used issue7838

Patch Set 1 #

Total comments: 1

Patch Set 2 : Return all periods in get_period_ids #

Patch Set 3 : Use in operator insted of startswith #

Total comments: 2

Patch Set 4 : Set period when empty and add test in scenario #

Total comments: 1

Patch Set 5 : Group general ledger tests #

Patch Set 6 : Register period before GeneralLedgerAccount #

Patch Set 7 : Undo last patchset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M account.py View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M tests/scenario_reports.rst View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 25
pokoli
5 months, 2 weeks ago (2018-11-03 17:37:15 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/47721002
5 months, 2 weeks ago (2018-11-03 17:49:08 UTC) #2
ced
https://codereview.tryton.org/47721002/diff/1/account.py File account.py (right): https://codereview.tryton.org/47721002/diff/1/account.py#newcode1437 account.py:1437: end_period_ids = cls.get_period_ids('end_%s' % name) This should be done ...
5 months, 2 weeks ago (2018-11-04 09:38:36 UTC) #3
pokoli
Return all periods in get_period_ids
5 months, 2 weeks ago (2018-11-05 14:53:05 UTC) #4
pokoli
Use in operator insted of startswith
5 months, 2 weeks ago (2018-11-05 14:55:18 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/47721002
5 months, 2 weeks ago (2018-11-05 15:10:59 UTC) #6
ced
I'm wondering if we should not improve the scenario to test this case. https://codereview.tryton.org/47721002/diff/40001/account.py File ...
5 months, 1 week ago (2018-11-05 22:31:46 UTC) #7
pokoli
Set period when empty and add test in scenario
5 months, 1 week ago (2018-11-11 20:56:03 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/47721002
5 months, 1 week ago (2018-11-11 21:06:41 UTC) #9
ced
https://codereview.tryton.org/47721002/diff/60001/tests/scenario_reports.rst File tests/scenario_reports.rst (right): https://codereview.tryton.org/47721002/diff/60001/tests/scenario_reports.rst#newcode96 tests/scenario_reports.rst:96: I would prefer to keep GL test together
4 months, 4 weeks ago (2018-11-19 20:56:16 UTC) #10
pokoli
Group general ledger tests
4 months, 4 weeks ago (2018-11-20 11:04:15 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/47721002
4 months, 4 weeks ago (2018-11-20 11:12:39 UTC) #12
ced
LGTM
4 months, 3 weeks ago (2018-11-26 21:26:55 UTC) #13
pokoli
Register period before GeneralLedgerAccount
4 months, 3 weeks ago (2018-11-27 11:43:29 UTC) #14
reviewbot
https://codereview.tryton.org/47721002/diff/100001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/47721002/diff/100001/__init__.py#newcode6 __init__.py:6: ...
4 months, 3 weeks ago (2018-11-27 12:16:12 UTC) #15
ced
On 2018/11/27 11:43:29, pokoli wrote: > Register period before GeneralLedgerAccount Why?
4 months, 2 weeks ago (2018-11-29 13:31:17 UTC) #16
pokoli
On 2018/11/29 13:31:17, ced wrote: > On 2018/11/27 11:43:29, pokoli wrote: > > Register period ...
4 months, 2 weeks ago (2018-11-29 16:10:13 UTC) #17
ced
On 2018/11/29 16:10:13, pokoli wrote: > On 2018/11/29 13:31:17, ced wrote: > > On 2018/11/27 ...
4 months, 2 weeks ago (2018-11-29 16:22:23 UTC) #18
pokoli
On 2018/11/29 16:22:23, ced wrote: > On 2018/11/29 16:10:13, pokoli wrote: > > On 2018/11/29 ...
4 months, 2 weeks ago (2018-11-29 18:25:28 UTC) #19
pokoli
On 2018/11/29 16:22:23, ced wrote: > I think it deserves a bug report and a ...
4 months, 2 weeks ago (2018-11-29 18:33:39 UTC) #20
pokoli
Undo last patchset
4 months, 2 weeks ago (2018-11-29 18:34:18 UTC) #21
reviewbot
flake8 OK URL: https://codereview.tryton.org/47721002
4 months, 2 weeks ago (2018-11-29 18:37:59 UTC) #22
rietveld-bot_tryton.org
New changeset e2cc34d17a01 by Sergi Almacellas Abellana in branch 'default': Ensure end periods is set ...
4 months, 2 weeks ago (2018-12-03 10:47:32 UTC) #23
rietveld-bot_tryton.org
New changeset d81180fd7dbb by Sergi Almacellas Abellana in branch 'default': Ensure end periods is set ...
4 months, 2 weeks ago (2018-12-03 10:47:42 UTC) #24
rietveld-bot_tryton.org
4 months, 1 week ago (2018-12-10 17:53:05 UTC) #25
New changeset 6d4a3af7753e by Sergi Almacellas Abellana in branch '5.0':
Ensure end periods is set when computing GL debit and credit amounts
https://hg.tryton.org/modules/account/rev/6d4a3af7753e


New changeset 2477f6b74ce6 by Sergi Almacellas Abellana in branch '4.8':
Ensure end periods is set when computing GL debit and credit amounts
https://hg.tryton.org/modules/account/rev/2477f6b74ce6


New changeset 387eb9cd3e93 by Sergi Almacellas Abellana in branch '4.6':
Ensure end periods is set when computing GL debit and credit amounts
https://hg.tryton.org/modules/account/rev/387eb9cd3e93


New changeset f90edfdcc907 by Sergi Almacellas Abellana in branch '4.4':
Ensure end periods is set when computing GL debit and credit amounts
https://hg.tryton.org/modules/account/rev/f90edfdcc907


New changeset 6f96a9fe7730 by Sergi Almacellas Abellana in branch '4.2':
Ensure end periods is set when computing GL debit and credit amounts
https://hg.tryton.org/modules/account/rev/6f96a9fe7730
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766