Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(370)

Issue 47721002: account: Ensure end periods is set when computing GL debit and credit amounts

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks ago by pokoli
Modified:
6 days, 10 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

As the diference between end_periods and start_periods is computed, the end periods should have a value when the start periods is set otherwise and empty list of periods is used issue7838

Patch Set 1 #

Total comments: 1

Patch Set 2 : Return all periods in get_period_ids #

Patch Set 3 : Use in operator insted of startswith #

Total comments: 2

Patch Set 4 : Set period when empty and add test in scenario #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M account.py View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M tests/scenario_reports.rst View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9
pokoli
2 weeks ago (2018-11-03 17:37:15 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/47721002
2 weeks ago (2018-11-03 17:49:08 UTC) #2
ced
https://codereview.tryton.org/47721002/diff/1/account.py File account.py (right): https://codereview.tryton.org/47721002/diff/1/account.py#newcode1437 account.py:1437: end_period_ids = cls.get_period_ids('end_%s' % name) This should be done ...
1 week, 6 days ago (2018-11-04 09:38:36 UTC) #3
pokoli
Return all periods in get_period_ids
1 week, 5 days ago (2018-11-05 14:53:05 UTC) #4
pokoli
Use in operator insted of startswith
1 week, 5 days ago (2018-11-05 14:55:18 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/47721002
1 week, 5 days ago (2018-11-05 15:10:59 UTC) #6
ced
I'm wondering if we should not improve the scenario to test this case. https://codereview.tryton.org/47721002/diff/40001/account.py File ...
1 week, 5 days ago (2018-11-05 22:31:46 UTC) #7
pokoli
Set period when empty and add test in scenario
6 days, 11 hours ago (2018-11-11 20:56:03 UTC) #8
reviewbot
6 days, 10 hours ago (2018-11-11 21:06:41 UTC) #9
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766