Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Issue 48391002: account_dunning_letter: Group dunnings by company and party

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by pokoli
Modified:
4 years, 8 months ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -165 lines) Patch
M dunning.py View 5 chunks +11 lines, -10 lines 0 comments Download
M letter.fodt View 9 chunks +141 lines, -155 lines 0 comments Download

Messages

Total messages: 3
pokoli
4 years, 8 months ago (2018-05-24 12:42:06 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/48391002
4 years, 8 months ago (2018-05-24 12:57:34 UTC) #2
ced
4 years, 8 months ago (2018-05-31 16:15:56 UTC) #3
I find it too bad to loose the company headers.
I think it will be better to make the report single and that the records of
Report are a list of tuple company and dunnings. This way we will have one
report per company with all the dunnings.
This technique could also be used on other company reports and so we keep the
current behavior for mono-company setup.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted