Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(221)

Issue 48431002: tryton: Update to Python 3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 2 weeks ago by ced
Modified:
2 weeks, 5 days ago
Reviewers:
timitos3000, rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use io.open #

Patch Set 3 : Require new version of GooCalendar #

Patch Set 4 : Fix flake8 #

Patch Set 5 : Decode base64 bytes in jsonrpc #

Patch Set 6 : Fix division integer by using divmod #

Patch Set 7 : Add python_requires #

Total comments: 2

Patch Set 8 : Remove debug print #

Patch Set 9 : Fix sort and "No closing quoration" exception #

Patch Set 10 : Update to tip #

Patch Set 11 : Update to tip #

Patch Set 12 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+509 lines, -474 lines) Patch
M bin/tryton View 1 chunk +1 line, -1 line 0 comments Download
M doc/conf.py View 2 chunks +2 lines, -2 lines 0 comments Download
M doc/installation.rst View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M setup.py View 1 2 3 4 5 6 3 chunks +12 lines, -5 lines 0 comments Download
M tryton/action/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/action/main.py View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M tryton/client.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tryton/common/__init__.py View 1 chunk +5 lines, -5 lines 0 comments Download
M tryton/common/button.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/common/cellrendererbinary.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/common/cellrendererfloat.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/common/cellrendererinteger.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/common/common.py View 1 2 3 4 5 6 7 8 9 33 chunks +63 lines, -59 lines 0 comments Download
M tryton/common/completion.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tryton/common/datetime_.py View 1 2 3 4 5 11 chunks +13 lines, -11 lines 0 comments Download
M tryton/common/domain_inversion.py View 1 2 3 14 chunks +15 lines, -13 lines 0 comments Download
M tryton/common/domain_parser.py View 1 2 3 4 5 6 7 8 13 chunks +46 lines, -46 lines 0 comments Download
M tryton/common/environment.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/common/htmltextbuffer.py View 1 2 3 4 5 6 7 15 chunks +21 lines, -24 lines 0 comments Download
M tryton/common/popup_menu.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tryton/common/selection.py View 1 2 3 2 chunks +7 lines, -5 lines 0 comments Download
M tryton/common/timedelta.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tryton/config.py View 6 chunks +17 lines, -17 lines 0 comments Download
M tryton/exceptions.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/fingerprints.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tryton/gui/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/main.py View 1 2 3 4 5 6 7 8 9 7 chunks +17 lines, -16 lines 0 comments Download
M tryton/gui/window/__init__.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tryton/gui/window/about.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/attachment.py View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M tryton/gui/window/board.py View 2 chunks +4 lines, -1 line 0 comments Download
M tryton/gui/window/dblogin.py View 13 chunks +17 lines, -17 lines 0 comments Download
M tryton/gui/window/form.py View 3 chunks +5 lines, -2 lines 0 comments Download
M tryton/gui/window/limit.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/preference.py View 1 2 3 1 chunk +7 lines, -5 lines 0 comments Download
M tryton/gui/window/view_board/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/view_form/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/view_form/model/field.py View 1 2 3 4 5 6 7 8 9 10 11 13 chunks +28 lines, -19 lines 0 comments Download
M tryton/gui/window/view_form/model/group.py View 6 chunks +7 lines, -7 lines 0 comments Download
M tryton/gui/window/view_form/model/record.py View 1 2 3 4 5 6 7 8 9 10 11 19 chunks +24 lines, -24 lines 0 comments Download
M tryton/gui/window/view_form/screen/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/view_form/screen/screen.py View 1 2 3 4 5 6 7 8 9 10 11 10 chunks +12 lines, -12 lines 0 comments Download
M tryton/gui/window/view_form/view/calendar_.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/view_form/view/calendar_gtk/calendar_.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/view_form/view/form.py View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +7 lines, -7 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/dictionary.py View 6 chunks +10 lines, -10 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/image.py View 1 2 3 3 chunks +6 lines, -4 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/many2many.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/many2one.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/one2many.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/richtextbox.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/state_widget.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/textbox.py View 2 chunks +2 lines, -3 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/widget.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/view_form/view/graph.py View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/graph_gtk/bar.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tryton/gui/window/view_form/view/graph_gtk/graph.py View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M tryton/gui/window/view_form/view/graph_gtk/line.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/graph_gtk/pie.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tryton/gui/window/view_form/view/list.py View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -4 lines 0 comments Download
M tryton/gui/window/view_form/view/list_gtk/editabletree.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/list_gtk/widget.py View 1 2 3 4 chunks +9 lines, -5 lines 0 comments Download
M tryton/gui/window/view_form/view/screen_container.py View 4 chunks +5 lines, -5 lines 0 comments Download
M tryton/gui/window/win_export.py View 1 2 3 5 chunks +6 lines, -8 lines 0 comments Download
M tryton/gui/window/win_form.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tryton/gui/window/win_import.py View 3 chunks +7 lines, -8 lines 0 comments Download
M tryton/gui/window/window.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tryton/gui/window/wizard.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tryton/ipc.py View 1 2 3 4 chunks +5 lines, -4 lines 0 comments Download
M tryton/jsonrpc.py View 1 2 3 4 5 6 7 8 9 10 11 16 chunks +28 lines, -28 lines 0 comments Download
M tryton/plugins/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/pyson.py View 8 chunks +15 lines, -15 lines 0 comments Download
M tryton/rpc.py View 5 chunks +5 lines, -5 lines 0 comments Download
M tryton/signal_event.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/translate.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23
ced
1 month, 2 weeks ago (2018-06-01 12:01:57 UTC) #1
ced
Use io.open
1 month, 2 weeks ago (2018-06-01 12:15:58 UTC) #2
ced
Require new version of GooCalendar
1 month, 2 weeks ago (2018-06-01 12:20:04 UTC) #3
reviewbot
https://codereview.tryton.org/48431002/diff/40001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/48431002/diff/40001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
1 month, 2 weeks ago (2018-06-01 12:25:44 UTC) #4
ced
Fix flake8
1 month, 2 weeks ago (2018-06-01 12:49:32 UTC) #5
reviewbot
https://codereview.tryton.org/48431002/diff/60001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/48431002/diff/60001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
1 month, 2 weeks ago (2018-06-01 13:28:42 UTC) #6
ced
Decode base64 bytes in jsonrpc
1 month, 1 week ago (2018-06-06 14:24:44 UTC) #7
reviewbot
https://codereview.tryton.org/48431002/diff/80001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/48431002/diff/80001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
1 month, 1 week ago (2018-06-06 14:35:29 UTC) #8
ced
Fix division integer by using divmod
1 month, 1 week ago (2018-06-07 08:39:34 UTC) #9
reviewbot
https://codereview.tryton.org/48431002/diff/100001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/48431002/diff/100001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
1 month, 1 week ago (2018-06-07 09:00:31 UTC) #10
ced
Add python_requires
1 month, 1 week ago (2018-06-07 10:43:08 UTC) #11
reviewbot
https://codereview.tryton.org/48431002/diff/120001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/48431002/diff/120001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
1 month, 1 week ago (2018-06-07 11:02:45 UTC) #12
timitos3000
https://codereview.tryton.org/48431002/diff/120001/tryton/common/htmltextbuffer.py File tryton/common/htmltextbuffer.py (right): https://codereview.tryton.org/48431002/diff/120001/tryton/common/htmltextbuffer.py#newcode280 tryton/common/htmltextbuffer.py:280: print(normalize_markup(text, method='xml')) Debug code? https://codereview.tryton.org/48431002/diff/120001/tryton/common/htmltextbuffer.py#newcode282 tryton/common/htmltextbuffer.py:282: print(text) Debug code?
1 month ago (2018-06-11 18:05:23 UTC) #13
ced
Remove debug print
1 month ago (2018-06-12 07:04:02 UTC) #14
reviewbot
https://codereview.tryton.org/48431002/diff/140001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/48431002/diff/140001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
1 month ago (2018-06-12 07:34:56 UTC) #15
ced
Fix sort and "No closing quoration" exception
1 month ago (2018-06-12 09:39:43 UTC) #16
reviewbot
https://codereview.tryton.org/48431002/diff/160001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/48431002/diff/160001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
1 month ago (2018-06-12 10:00:46 UTC) #17
ced
Update to tip
3 weeks, 5 days ago (2018-06-19 14:13:05 UTC) #18
reviewbot
https://codereview.tryton.org/48431002/diff/180001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/48431002/diff/180001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
3 weeks, 5 days ago (2018-06-19 14:27:29 UTC) #19
ced
Update to tip
3 weeks, 4 days ago (2018-06-20 08:23:51 UTC) #20
reviewbot
https://codereview.tryton.org/48431002/diff/200001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/48431002/diff/200001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
3 weeks, 4 days ago (2018-06-20 08:33:59 UTC) #21
ced
Update to tip
2 weeks, 5 days ago (2018-06-26 17:06:29 UTC) #22
rietveld-bot_tryton.org
2 weeks, 5 days ago (2018-06-26 17:09:02 UTC) #23
New changeset a4bbf6d65099 by Cédric Krier in branch 'default':
Update to Python 3
https://hg.tryton.org/tryton/rev/a4bbf6d65099
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69