Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(399)

Issue 48521002: tryton: Use GtkApplication (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by ced
Modified:
1 month, 4 weeks ago
Visibility:
Public.

Description

- Connect to the database before starting the application to generate the ID - Use application menu - Use HeaderBar to receive the global search entry and favorites - Use MenuButton for tab menu - Remove IPC and rely on GtkApplication command - Use GtkApplication.get_active_window for get_toplevel_window - Use Singleton pattern for Main issue7563

Patch Set 1 #

Patch Set 2 : flake8 and use Action as placeholder for global search #

Patch Set 3 : Update to tip #

Total comments: 2

Patch Set 4 : Update to tip #

Patch Set 5 : Avoid rpc common import loop #

Patch Set 6 : Increase size of global search #

Patch Set 7 : Use button for favorite #

Unified diffs Side-by-side diffs Delta from patch set Stats (+685 lines, -1444 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M bin/tryton View 1 chunk +2 lines, -22 lines 0 comments Download
M doc/usage.rst View 8 chunks +50 lines, -200 lines 0 comments Download
M tryton/__init__.py View 1 chunk +197 lines, -0 lines 0 comments Download
M tryton/action/main.py View 2 chunks +5 lines, -4 lines 0 comments Download
M tryton/client.py View 1 2 3 4 1 chunk +65 lines, -295 lines 0 comments Download
M tryton/common/common.py View 1 2 3 4 5 6 chunks +21 lines, -18 lines 0 comments Download
M tryton/config.py View 1 7 chunks +3 lines, -12 lines 0 comments Download
M tryton/gui/main.py View 1 2 3 4 5 6 20 chunks +250 lines, -628 lines 0 comments Download
M tryton/gui/window/__init__.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tryton/gui/window/board.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/dblogin.py View 4 chunks +11 lines, -13 lines 0 comments Download
M tryton/gui/window/email.py View 2 chunks +4 lines, -1 line 0 comments Download
M tryton/gui/window/form.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/limit.py View 2 chunks +4 lines, -1 line 0 comments Download
M tryton/gui/window/nomodal.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/preference.py View 2 chunks +7 lines, -4 lines 0 comments Download
M tryton/gui/window/revision.py View 2 chunks +5 lines, -3 lines 0 comments Download
M tryton/gui/window/shortcuts.py View 2 chunks +4 lines, -1 line 0 comments Download
M tryton/gui/window/tabcontent.py View 1 2 3 4 chunks +7 lines, -12 lines 0 comments Download
M tryton/gui/window/view_form/screen/screen.py View 1 2 5 chunks +4 lines, -5 lines 0 comments Download
M tryton/gui/window/view_form/view/calendar_gtk/toolbar.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/widget.py View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/graph.py View 2 chunks +5 lines, -3 lines 0 comments Download
M tryton/gui/window/view_form/view/screen_container.py View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M tryton/gui/window/win_csv.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tryton/gui/window/win_form.py View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M tryton/gui/window/win_search.py View 2 chunks +5 lines, -2 lines 0 comments Download
M tryton/gui/window/window.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tryton/gui/window/wizard.py View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
R tryton/ipc.py View 1 chunk +0 lines, -185 lines 0 comments Download
M tryton/rpc.py View 1 2 3 4 5 3 chunks +13 lines, -21 lines 0 comments Download

Messages

Total messages: 16
ced
2 months, 2 weeks ago (2018-07-06 12:57:35 UTC) #1
reviewbot
https://codereview.tryton.org/48521002/diff/1/tryton/__init__.py#newcode180 tryton/__init__.py:180: F401 'goocalendar' imported but unused https://codereview.tryton.org/48521002/diff/1/tryton/__init__.py#newcode4 tryton/__init__.py:4: E402 module level import not at ...
2 months, 2 weeks ago (2018-07-06 13:10:41 UTC) #2
ced
flake8 and use Action as placeholder for global search
2 months, 2 weeks ago (2018-07-06 14:25:52 UTC) #3
ced
Update to tip
2 months, 2 weeks ago (2018-07-06 14:34:43 UTC) #4
reviewbot
https://codereview.tryton.org/48521002/diff/40001/tryton/__init__.py#newcode180 tryton/__init__.py:180: F401 'goocalendar' imported but unused https://codereview.tryton.org/48521002/diff/40001/tryton/__init__.py#newcode4 tryton/__init__.py:4: E402 module level import not at ...
2 months, 2 weeks ago (2018-07-06 14:52:26 UTC) #5
pokoli
https://codereview.tryton.org/48521002/diff/40001/tryton/client.py File tryton/client.py (right): https://codereview.tryton.org/48521002/diff/40001/tryton/client.py#newcode67 tryton/client.py:67: 'database': CONFIG['login.db'], I think the login should also be ...
2 months, 2 weeks ago (2018-07-06 15:04:55 UTC) #6
ced
https://codereview.tryton.org/48521002/diff/40001/tryton/client.py File tryton/client.py (right): https://codereview.tryton.org/48521002/diff/40001/tryton/client.py#newcode67 tryton/client.py:67: 'database': CONFIG['login.db'], On 2018/07/06 15:04:55, pokoli wrote: > I ...
2 months, 2 weeks ago (2018-07-06 15:28:22 UTC) #7
timitos3000
2 months, 2 weeks ago (2018-07-06 18:09:30 UTC) #8
ced
Update to tip
2 months, 1 week ago (2018-07-10 16:02:08 UTC) #9
reviewbot
https://codereview.tryton.org/48521002/diff/60001/tryton/__init__.py#newcode180 tryton/__init__.py:180: F401 'goocalendar' imported but unused https://codereview.tryton.org/48521002/diff/60001/tryton/__init__.py#newcode4 tryton/__init__.py:4: E402 module level import not at ...
2 months, 1 week ago (2018-07-10 16:14:56 UTC) #10
ced
Avoid rpc common import loop
2 months, 1 week ago (2018-07-11 14:43:50 UTC) #11
reviewbot
https://codereview.tryton.org/48521002/diff/80001/tryton/__init__.py#newcode180 tryton/__init__.py:180: F401 'goocalendar' imported but unused https://codereview.tryton.org/48521002/diff/80001/tryton/__init__.py#newcode4 tryton/__init__.py:4: E402 module level import not at ...
2 months, 1 week ago (2018-07-11 15:21:44 UTC) #12
ced
Increase size of global search
2 months ago (2018-07-20 13:59:11 UTC) #13
reviewbot
https://codereview.tryton.org/48521002/diff/100001/tryton/__init__.py#newcode180 tryton/__init__.py:180: F401 'goocalendar' imported but unused https://codereview.tryton.org/48521002/diff/100001/tryton/__init__.py#newcode4 tryton/__init__.py:4: E402 module level import not at ...
2 months ago (2018-07-20 14:02:56 UTC) #14
ced
Use button for favorite
2 months ago (2018-07-21 15:53:50 UTC) #15
reviewbot
2 months ago (2018-07-21 16:02:09 UTC) #16
https://codereview.tryton.org/48521002/diff/120001/tryton/__init__.py#newcode180
tryton/__init__.py:180:
F401 'goocalendar' imported but unused

https://codereview.tryton.org/48521002/diff/120001/tryton/__init__.py#newcode4
tryton/__init__.py:4:
E402 module level import not at top of file

https://codereview.tryton.org/48521002/diff/120001/tryton/__init__.py#newcode6
tryton/__init__.py:6:
E402 module level import not at top of file

https://codereview.tryton.org/48521002/diff/120001/tryton/__init__.py#newcode7
tryton/__init__.py:7:
E402 module level import not at top of file

https://codereview.tryton.org/48521002/diff/120001/tryton/__init__.py#newcode20
tryton/__init__.py:20:
E402 module level import not at top of file

https://codereview.tryton.org/48521002/diff/120001/tryton/__init__.py#newcode101
tryton/__init__.py:101:
E402 module level import not at top of file

https://codereview.tryton.org/48521002/diff/120001/tryton/__init__.py#newcode165
tryton/__init__.py:165:
E402 module level import not at top of file

https://codereview.tryton.org/48521002/diff/120001/tryton/__init__.py#newcode177
tryton/__init__.py:177:
E402 module level import not at top of file

https://codereview.tryton.org/48521002/diff/120001/tryton/gui/window/__init__...
tryton/gui/window/__init__.py:3:
F403 'from window import *' used; unable to detect undefined names

URL: https://codereview.tryton.org/48521002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766