Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(365)

Issue 48581002: account_invoice: Set cancel state when refund with credit note (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ced
Modified:
1 month ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

and clear partial payments. Other modules may trigger events base on the paid or cancel state of the invoice. So we should allow the user to not trigger the paid event when he cancel an invoice with a credit note. issue7682 issue4775

Patch Set 1 #

Total comments: 4

Patch Set 2 : Update to tip #

Total comments: 1

Patch Set 3 : Rename canceled into cancelled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -71 lines) Patch
M CHANGELOG View 1 1 chunk +3 lines, -0 lines 0 comments Download
M doc/index.rst View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M invoice.py View 1 2 17 chunks +52 lines, -68 lines 0 comments Download
M tests/scenario_invoice.rst View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12
ced
2 months, 1 week ago (2018-09-06 13:19:33 UTC) #1
reviewbot
https://codereview.tryton.org/48581002/diff/1/invoice.py#newcode609 invoice.py:609: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/48581002
2 months, 1 week ago (2018-09-06 13:33:53 UTC) #2
pokoli
https://codereview.tryton.org/48581002/diff/1/invoice.py File invoice.py (right): https://codereview.tryton.org/48581002/diff/1/invoice.py#newcode2738 invoice.py:2738: 'readonly': ~Eval('with_refund_allowed'), does it really make sense to make ...
1 month, 2 weeks ago (2018-10-03 18:47:40 UTC) #3
ced
https://codereview.tryton.org/48581002/diff/1/invoice.py File invoice.py (right): https://codereview.tryton.org/48581002/diff/1/invoice.py#newcode2738 invoice.py:2738: 'readonly': ~Eval('with_refund_allowed'), On 2018/10/03 18:47:40, pokoli wrote: > does ...
1 month, 2 weeks ago (2018-10-03 21:58:17 UTC) #4
ced
Update to tip
1 month, 2 weeks ago (2018-10-03 22:27:33 UTC) #5
reviewbot
https://codereview.tryton.org/48581002/diff/20001/invoice.py#newcode609 invoice.py:609: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/48581002
1 month, 2 weeks ago (2018-10-03 22:28:15 UTC) #6
pokoli
https://codereview.tryton.org/48581002/diff/20001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/48581002/diff/20001/doc/index.rst#newcode46 doc/index.rst:46: to refund is checked, the original invoice will be ...
1 month, 1 week ago (2018-10-08 10:02:45 UTC) #7
ced
Rename canceled into cancelled
1 month, 1 week ago (2018-10-08 10:18:48 UTC) #8
reviewbot
https://codereview.tryton.org/48581002/diff/40001/invoice.py#newcode609 invoice.py:609: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/48581002
1 month, 1 week ago (2018-10-08 10:31:55 UTC) #9
pokoli
LGTM
1 month, 1 week ago (2018-10-09 08:39:00 UTC) #10
rietveld-bot_tryton.org
New changeset 22eabf722a91 by Cédric Krier in branch 'default': Set cancel state when refund with ...
1 month ago (2018-10-15 20:56:13 UTC) #11
rietveld-bot_tryton.org
1 month ago (2018-10-15 20:56:16 UTC) #12
New changeset 8562668620b7 by Cédric Krier in branch 'default':
Set cancel state when refund with credit note
https://hg.tryton.org/tryton-env/rev/8562668620b7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766