Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 48631002: account_statement: Use grouped line class also for origins (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by ced
Modified:
3 hours, 14 minutes ago
Reviewers:
udono, rietveld-bot, reviewbot
Visibility:
Public.

Description

The statement report expect to loop over an object that has a descriptions attribute. issue7763

Patch Set 1 #

Patch Set 2 : Add test and fix them #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M statement.py View 1 2 chunks +12 lines, -9 lines 3 comments Download
M tests/scenario_statement_origin.rst View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 10
ced
1 week, 3 days ago (2018-10-05 21:12:36 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/48631002
1 week, 3 days ago (2018-10-05 21:30:42 UTC) #2
udono
LGTM
1 week, 2 days ago (2018-10-06 03:03:26 UTC) #3
ced
Add test and fix them
1 week, 2 days ago (2018-10-06 06:05:05 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/48631002
1 week, 2 days ago (2018-10-06 06:27:52 UTC) #5
udono
https://codereview.tryton.org/48631002/diff/20001/statement.py File statement.py (right): https://codereview.tryton.org/48631002/diff/20001/statement.py#newcode342 statement.py:342: lines = self.origins or self.lines I do not understand ...
1 week ago (2018-10-08 18:13:21 UTC) #6
ced
https://codereview.tryton.org/48631002/diff/20001/statement.py File statement.py (right): https://codereview.tryton.org/48631002/diff/20001/statement.py#newcode342 statement.py:342: lines = self.origins or self.lines On 2018/10/08 18:13:21, udono ...
1 week ago (2018-10-08 22:31:10 UTC) #7
udono
LGTM https://codereview.tryton.org/48631002/diff/20001/statement.py File statement.py (right): https://codereview.tryton.org/48631002/diff/20001/statement.py#newcode342 statement.py:342: lines = self.origins or self.lines On 2018/10/08 22:31:10, ...
6 days, 16 hours ago (2018-10-09 07:22:35 UTC) #8
rietveld-bot_tryton.org
New changeset d18b8d31eca4 by Cédric Krier in branch 'default': Use grouped line class also for ...
3 hours, 14 minutes ago (2018-10-15 20:54:30 UTC) #9
rietveld-bot_tryton.org
3 hours, 14 minutes ago (2018-10-15 20:54:35 UTC) #10
New changeset 7986a746c79c by Cédric Krier in branch 'default':
Use grouped line class also for origins
https://hg.tryton.org/tryton-env/rev/7986a746c79c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766