Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(98)

Issue 48701002: stock_lot_sled: Search queries inside Select and add different lot instances (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by ced
Modified:
2 months, 1 week ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

When compute_quantities_query is called with with_childs, the selected move table is a union. So we must search inside this union for the actual move table. As we may need to join with lot table multiple times, we must ensure to always use a different instance of the table to avoid alias clash. issue7882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M stock.py View 5 chunks +11 lines, -7 lines 0 comments Download
M tests/test_stock_lot_sled.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
ced
2 months, 3 weeks ago (2018-12-31 01:12:24 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/48701002
2 months, 3 weeks ago (2018-12-31 01:43:49 UTC) #2
rietveld-bot_tryton.org
2 months, 1 week ago (2019-01-17 16:10:14 UTC) #3
New changeset a7b3ecf1a98c by Cédric Krier in branch 'default':
Search queries inside Select and add different lot instances
https://hg.tryton.org/tryton-env/rev/a7b3ecf1a98c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766