Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 48711002: tryton: Replace filter window by popover (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by ced
Modified:
1 month, 3 weeks ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

The fix the focus not being set under some window manager. issue8061

Patch Set 1 #

Patch Set 2 : replace show by present #

Patch Set 3 : Use Popover #

Patch Set 4 : Do not take unecessary height #

Patch Set 5 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -69 lines) Patch
M CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M tryton/gui/window/view_form/screen/screen.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tryton/gui/window/view_form/view/screen_container.py View 1 2 3 9 chunks +17 lines, -68 lines 0 comments Download

Messages

Total messages: 12
ced
2 months, 2 weeks ago (2019-01-30 22:58:40 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/48711002
2 months, 2 weeks ago (2019-01-30 23:13:20 UTC) #2
ced
replace show by present
2 months, 2 weeks ago (2019-01-31 13:18:01 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/48711002
2 months, 2 weeks ago (2019-01-31 13:37:58 UTC) #4
ced
Use Popover
2 months ago (2019-02-11 22:17:22 UTC) #5
reviewbot
patch is not applicable URL: https://codereview.tryton.org/48711002
2 months ago (2019-02-11 22:41:23 UTC) #6
ced
Do not take unecessary height
2 months ago (2019-02-12 00:03:49 UTC) #7
reviewbot
patch is not applicable URL: https://codereview.tryton.org/48711002
2 months ago (2019-02-12 00:06:41 UTC) #8
ced
Update to tip
2 months ago (2019-02-12 00:10:20 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/48711002
2 months ago (2019-02-12 00:44:32 UTC) #10
rietveld-bot_tryton.org
New changeset d1b442b6c85e by Cédric Krier in branch 'default': Replace filter window by popover https://hg.tryton.org/tryton/rev/d1b442b6c85e
1 month, 3 weeks ago (2019-02-26 14:50:43 UTC) #11
rietveld-bot_tryton.org
1 month, 3 weeks ago (2019-02-26 14:50:44 UTC) #12
New changeset 292dc08e7d00 by Cédric Krier in branch 'default':
Replace filter window by popover
https://hg.tryton.org/tryton-env/rev/292dc08e7d00
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766