Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(725)

Issue 48721002: trytond: Cast timestamp as datetime for sqlite back-end (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by ced
Modified:
3 days, 9 hours ago
Reviewers:
rietveld-bot, nicoe, reviewbot
Visibility:
Public.

Description

SQLite backend returns a string for the datetime so the comparison between timestamp fails. issue8080

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M trytond/cache.py View 4 chunks +14 lines, -3 lines 4 comments Download
M trytond/tests/test_cache.py View 3 chunks +19 lines, -0 lines 4 comments Download

Messages

Total messages: 8
ced
1 week, 3 days ago (2019-02-06 16:25:16 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/48721002
1 week, 3 days ago (2019-02-06 16:37:56 UTC) #2
nicoe
https://codereview.tryton.org/48721002/diff/1/trytond/cache.py File trytond/cache.py (right): https://codereview.tryton.org/48721002/diff/1/trytond/cache.py#newcode20 trytond/cache.py:20: def _cast(column): Shouldn't such a method be defined somewhere ...
1 week, 3 days ago (2019-02-06 17:57:14 UTC) #3
ced
https://codereview.tryton.org/48721002/diff/1/trytond/cache.py File trytond/cache.py (right): https://codereview.tryton.org/48721002/diff/1/trytond/cache.py#newcode20 trytond/cache.py:20: def _cast(column): On 2019/02/06 17:57:13, nicoe wrote: > Shouldn't ...
1 week, 3 days ago (2019-02-06 18:30:56 UTC) #4
nicoe
https://codereview.tryton.org/48721002/diff/1/trytond/cache.py File trytond/cache.py (right): https://codereview.tryton.org/48721002/diff/1/trytond/cache.py#newcode20 trytond/cache.py:20: def _cast(column): On 2019/02/06 18:30:55, ced wrote: > On ...
1 week, 2 days ago (2019-02-06 22:38:54 UTC) #5
ced
https://codereview.tryton.org/48721002/diff/1/trytond/cache.py File trytond/cache.py (right): https://codereview.tryton.org/48721002/diff/1/trytond/cache.py#newcode20 trytond/cache.py:20: def _cast(column): On 2019/02/06 22:38:54, nicoe wrote: > On ...
1 week, 2 days ago (2019-02-06 22:58:18 UTC) #6
rietveld-bot_tryton.org
New changeset 4ae2d4ab6704 by Cédric Krier in branch 'default': Cast timestamp as datetime for sqlite ...
3 days, 9 hours ago (2019-02-13 09:23:57 UTC) #7
rietveld-bot_tryton.org
3 days, 9 hours ago (2019-02-13 09:24:01 UTC) #8
New changeset 3d43b7fa6331 by Cédric Krier in branch 'default':
Cast timestamp as datetime for sqlite back-end
https://hg.tryton.org/tryton-env/rev/3d43b7fa6331
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766