Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 49381002: account_asset: Add company as Depreciation Table report filter

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by pokoli
Modified:
4 years, 8 months ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M asset.py View 6 chunks +12 lines, -2 lines 1 comment Download
M view/print_depreciation_table_start.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
pokoli
4 years, 8 months ago (2018-05-24 11:54:24 UTC) #1
reviewbot
https://codereview.tryton.org/49381002/diff/1/asset.py#newcode49 asset.py:49: E711 comparison to None should be 'if cond is None:' https://codereview.tryton.org/49381002/diff/1/asset.py#newcode915 asset.py:915: E731 ...
4 years, 8 months ago (2018-05-24 11:58:20 UTC) #2
ced
4 years, 8 months ago (2018-05-31 16:05:09 UTC) #3
Missing changelog

https://codereview.tryton.org/49381002/diff/1/asset.py
File asset.py (right):

https://codereview.tryton.org/49381002/diff/1/asset.py#newcode857
asset.py:857: context['company'] = Company(data['company'])
It may be good to have an assert that check all records are from the company.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted