Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(398)

Issue 49461002: stock: Add count wizard on inventory (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by ced
Modified:
1 month, 3 weeks ago
Reviewers:
pokoli, reviewbot, rietveld-bot, timitos3000
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update doc #

Total comments: 15

Patch Set 3 : Rename quantity fields #

Patch Set 4 : Test quantity_resulting in scenario #

Patch Set 5 : Update tot ip #

Total comments: 2

Patch Set 6 : Fix doc typo #

Patch Set 7 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -14 lines) Patch
M CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M __init__.py View 3 chunks +6 lines, -3 lines 0 comments Download
M doc/index.rst View 1 2 3 4 5 1 chunk +8 lines, -5 lines 0 comments Download
M inventory.py View 1 2 3 4 5 6 4 chunks +153 lines, -2 lines 0 comments Download
M inventory.xml View 1 chunk +26 lines, -1 line 0 comments Download
A tests/scenario_stock_inventory_count.rst View 1 2 3 1 chunk +120 lines, -0 lines 0 comments Download
M tests/test_stock.py View 1 chunk +5 lines, -0 lines 0 comments Download
A view/inventory_count_quantity_form.xml View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A view/inventory_count_search_form.xml View 1 chunk +7 lines, -0 lines 0 comments Download
M view/inventory_form.xml View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 25
ced
3 months, 1 week ago (2018-06-13 10:15:57 UTC) #1
reviewbot
https://codereview.tryton.org/49461002/diff/1/__init__.py#newcode5 __init__.py:5: F403 'from location import *' used; unable to detect undefined names https://codereview.tryton.org/49461002/diff/1/__init__.py#newcode6 __init__.py:6: ...
3 months, 1 week ago (2018-06-13 10:28:03 UTC) #2
ced
Update doc
3 months, 1 week ago (2018-06-13 10:52:13 UTC) #3
reviewbot
https://codereview.tryton.org/49461002/diff/20001/__init__.py#newcode5 __init__.py:5: F403 'from location import *' used; unable to detect undefined names https://codereview.tryton.org/49461002/diff/20001/__init__.py#newcode6 __init__.py:6: ...
3 months, 1 week ago (2018-06-13 11:03:30 UTC) #4
pokoli
https://codereview.tryton.org/49461002/diff/20001/inventory.py File inventory.py (right): https://codereview.tryton.org/49461002/diff/20001/inventory.py#newcode569 inventory.py:569: line.quantity += self.quantity.quantity_added I think it will be better ...
3 months, 1 week ago (2018-06-13 14:14:38 UTC) #5
ced
https://codereview.tryton.org/49461002/diff/20001/inventory.py File inventory.py (right): https://codereview.tryton.org/49461002/diff/20001/inventory.py#newcode569 inventory.py:569: line.quantity += self.quantity.quantity_added On 2018/06/13 14:14:38, pokoli wrote: > ...
3 months, 1 week ago (2018-06-13 14:46:08 UTC) #6
pokoli
https://codereview.tryton.org/49461002/diff/20001/inventory.py File inventory.py (right): https://codereview.tryton.org/49461002/diff/20001/inventory.py#newcode569 inventory.py:569: line.quantity += self.quantity.quantity_added On 2018/06/13 14:46:08, ced wrote: > ...
3 months, 1 week ago (2018-06-14 07:40:40 UTC) #7
timitos3000
https://codereview.tryton.org/49461002/diff/20001/inventory.py File inventory.py (right): https://codereview.tryton.org/49461002/diff/20001/inventory.py#newcode543 inventory.py:543: values['quantity_added'] = 1 I think that this is not ...
3 months, 1 week ago (2018-06-14 08:24:58 UTC) #8
ced
https://codereview.tryton.org/49461002/diff/20001/inventory.py File inventory.py (right): https://codereview.tryton.org/49461002/diff/20001/inventory.py#newcode543 inventory.py:543: values['quantity_added'] = 1 On 2018/06/14 08:24:58, timitos3000 wrote: > ...
3 months, 1 week ago (2018-06-14 08:40:16 UTC) #9
timitos3000
https://codereview.tryton.org/49461002/diff/20001/inventory.py File inventory.py (right): https://codereview.tryton.org/49461002/diff/20001/inventory.py#newcode618 inventory.py:618: quantity = fields.Float( On 2018/06/14 08:40:16, ced wrote: > ...
3 months, 1 week ago (2018-06-14 09:32:32 UTC) #10
ced
https://codereview.tryton.org/49461002/diff/20001/inventory.py File inventory.py (right): https://codereview.tryton.org/49461002/diff/20001/inventory.py#newcode618 inventory.py:618: quantity = fields.Float( On 2018/06/14 09:32:32, timitos3000 wrote: > ...
3 months, 1 week ago (2018-06-14 10:35:02 UTC) #11
timitos3000
https://codereview.tryton.org/49461002/diff/20001/inventory.py File inventory.py (right): https://codereview.tryton.org/49461002/diff/20001/inventory.py#newcode618 inventory.py:618: quantity = fields.Float( On 2018/06/14 10:35:02, ced wrote: > ...
3 months, 1 week ago (2018-06-14 11:14:53 UTC) #12
ced
Rename quantity fields
3 months, 1 week ago (2018-06-14 12:06:38 UTC) #13
reviewbot
https://codereview.tryton.org/49461002/diff/40001/__init__.py#newcode5 __init__.py:5: F403 'from location import *' used; unable to detect undefined names https://codereview.tryton.org/49461002/diff/40001/__init__.py#newcode6 __init__.py:6: ...
3 months, 1 week ago (2018-06-14 12:24:34 UTC) #14
ced
Test quantity_resulting in scenario
3 months, 1 week ago (2018-06-14 12:41:21 UTC) #15
reviewbot
https://codereview.tryton.org/49461002/diff/60001/__init__.py#newcode5 __init__.py:5: F403 'from location import *' used; unable to detect undefined names https://codereview.tryton.org/49461002/diff/60001/__init__.py#newcode6 __init__.py:6: ...
3 months, 1 week ago (2018-06-14 13:05:44 UTC) #16
ced
Update tot ip
2 months, 3 weeks ago (2018-06-28 09:29:26 UTC) #17
reviewbot
https://codereview.tryton.org/49461002/diff/80001/__init__.py#newcode5 __init__.py:5: F403 'from location import *' used; unable to detect undefined names https://codereview.tryton.org/49461002/diff/80001/__init__.py#newcode6 __init__.py:6: ...
2 months, 3 weeks ago (2018-06-28 09:33:20 UTC) #18
timitos3000
https://codereview.tryton.org/49461002/diff/80001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/49461002/diff/80001/doc/index.rst#newcode265 doc/index.rst:265: Inventory lines consist of: a product and it's default ...
2 months, 3 weeks ago (2018-06-28 18:07:53 UTC) #19
ced
Fix doc typo
2 months, 3 weeks ago (2018-06-29 07:21:59 UTC) #20
reviewbot
https://codereview.tryton.org/49461002/diff/100001/__init__.py#newcode5 __init__.py:5: F403 'from location import *' used; unable to detect undefined names https://codereview.tryton.org/49461002/diff/100001/__init__.py#newcode6 __init__.py:6: ...
2 months, 3 weeks ago (2018-06-29 07:23:24 UTC) #21
timitos3000
LGTM
2 months, 2 weeks ago (2018-07-03 09:55:53 UTC) #22
ced
Update to tip
1 month, 3 weeks ago (2018-07-27 14:50:29 UTC) #23
reviewbot
https://codereview.tryton.org/49461002/diff/120001/__init__.py#newcode5 __init__.py:5: F403 'from location import *' used; unable to detect undefined names https://codereview.tryton.org/49461002/diff/120001/__init__.py#newcode6 __init__.py:6: ...
1 month, 3 weeks ago (2018-07-27 15:01:14 UTC) #24
rietveld-bot_tryton.org
1 month, 3 weeks ago (2018-07-27 15:14:04 UTC) #25
New changeset fe8c08e1d5f5 by Cédric Krier in branch 'default':
Add count wizard on inventory
https://hg.tryton.org/modules/stock/rev/fe8c08e1d5f5
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766